All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stanislav Fomichev <sdf@google.com>
To: Hao Luo <haoluo@google.com>
Cc: bpf@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net,
	andrii@kernel.org, martin.lau@linux.dev, song@kernel.org,
	yhs@fb.com, john.fastabend@gmail.com, kpsingh@kernel.org,
	jolsa@kernel.org
Subject: Re: [PATCH bpf-next v2 2/2] selftests/bpf: Excercise bpf_obj_get_info_by_fd for bpf2bpf
Date: Tue, 2 Aug 2022 09:24:14 -0700	[thread overview]
Message-ID: <CAKH8qBt1odxduc7KXTdq_NK_y7WZ8v35QUGkXKe6y9hSDc9OtA@mail.gmail.com> (raw)
In-Reply-To: <CA+khW7hWwXc3vXJaXSUzhWEwBAsH0JdxK6SC-H4DOXw+PxuUgA@mail.gmail.com>

On Mon, Aug 1, 2022 at 12:34 PM Hao Luo <haoluo@google.com> wrote:
>
> On Mon, Aug 1, 2022 at 10:39 AM Stanislav Fomichev <sdf@google.com> wrote:
> >
> > Apparently, no existing selftest covers it. Add a new one where
> > we load cgroup/bind4 program and attach fentry to it.
> > Calling bpf_obj_get_info_by_fd on the fentry program
> > should return non-zero btf_id/btf_obj_id instead of crashing the kernel.
> >
> > v2:
> > - use ret instead of err in find_prog_btf_id (Hao)
> > - remove verifier log (Hao)
> > - drop if conditional from ASSERT_OK(bpf_obj_get_info_by_fd(...)) (Hao)
> >
> > Signed-off-by: Stanislav Fomichev <sdf@google.com>
>
> I see Martin has comments based on v1, but v2 looks good to me.
>
> Acked-by: Hao Luo <haoluo@google.com>

Thank you for the review! I'll move some stuff around for v3, so I'll
have to ask you to have one more :-(

  reply	other threads:[~2022-08-02 16:24 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-01 17:39 [PATCH bpf-next v2 1/2] bpf: use proper target btf when exporting attach_btf_obj_id Stanislav Fomichev
2022-08-01 17:39 ` [PATCH bpf-next v2 2/2] selftests/bpf: Excercise bpf_obj_get_info_by_fd for bpf2bpf Stanislav Fomichev
2022-08-01 19:33   ` Hao Luo
2022-08-02 16:24     ` Stanislav Fomichev [this message]
2022-08-01 21:43   ` Andrii Nakryiko
2022-08-02 16:21     ` Stanislav Fomichev
2022-08-02 18:42       ` Andrii Nakryiko
2022-08-02 20:53         ` Stanislav Fomichev
2022-08-03  0:38           ` Andrii Nakryiko
2022-08-03 16:32 [PATCH bpf-next v2 1/2] bpf: use proper target btf when exporting attach_btf_obj_id Stanislav Fomichev
2022-08-03 16:32 ` [PATCH bpf-next v2 2/2] selftests/bpf: Excercise bpf_obj_get_info_by_fd for bpf2bpf Stanislav Fomichev
2022-08-03 16:51   ` Martin KaFai Lau
2022-08-03 17:10     ` Stanislav Fomichev
2022-08-03 17:19       ` Martin KaFai Lau
2022-08-03 18:27         ` Stanislav Fomichev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKH8qBt1odxduc7KXTdq_NK_y7WZ8v35QUGkXKe6y9hSDc9OtA@mail.gmail.com \
    --to=sdf@google.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=haoluo@google.com \
    --cc=john.fastabend@gmail.com \
    --cc=jolsa@kernel.org \
    --cc=kpsingh@kernel.org \
    --cc=martin.lau@linux.dev \
    --cc=song@kernel.org \
    --cc=yhs@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.