* Flaky bpf cg_storage_* tests @ 2023-03-28 17:39 Martin KaFai Lau 2023-03-28 18:08 ` Stanislav Fomichev 0 siblings, 1 reply; 4+ messages in thread From: Martin KaFai Lau @ 2023-03-28 17:39 UTC (permalink / raw) To: YiFei Zhu, Stanislav Fomichev; +Cc: bpf Hi YiFei and Stan, it is observed that the cg_stroage_* tests fail from time to time. A recent example is https://github.com/kernel-patches/bpf/actions/runs/4543867424/jobs/8009943115?pr=3924 Could you help to take a look? may be run it under netns and also have better filtering by ip/port when counting packets? Thanks! ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Flaky bpf cg_storage_* tests 2023-03-28 17:39 Flaky bpf cg_storage_* tests Martin KaFai Lau @ 2023-03-28 18:08 ` Stanislav Fomichev 2023-03-28 18:57 ` YiFei Zhu 0 siblings, 1 reply; 4+ messages in thread From: Stanislav Fomichev @ 2023-03-28 18:08 UTC (permalink / raw) To: Martin KaFai Lau; +Cc: YiFei Zhu, bpf On Tue, Mar 28, 2023 at 10:40 AM Martin KaFai Lau <martin.lau@linux.dev> wrote: > > Hi YiFei and Stan, it is observed that the cg_stroage_* tests fail from time to > time. A recent example is > https://github.com/kernel-patches/bpf/actions/runs/4543867424/jobs/8009943115?pr=3924 > > Could you help to take a look? may be run it under netns and also have better > filtering by ip/port when counting packets? Error: #43/2 cg_storage_multi/isolated test_isolated:PASS:skel-load 0 nsec test_isolated:PASS:parent-egress1-cg-attach 0 nsec test_isolated:PASS:parent-egress2-cg-attach 0 nsec test_isolated:PASS:parent-ingress-cg-attach 0 nsec test_isolated:PASS:first-connect-send 0 nsec test_isolated:FAIL:first-invoke invocations=2 Error: #43/3 cg_storage_multi/shared test_shared:PASS:skel-load 0 nsec test_shared:PASS:parent-egress1-cg-attach 0 nsec test_shared:PASS:parent-egress2-cg-attach 0 nsec test_shared:PASS:parent-ingress-cg-attach 0 nsec test_shared:PASS:first-connect-send 0 nsec test_shared:FAIL:first-invoke invocations=2 Probably because we're using tcp? And race with syn vs syn+ack (invocatoins=1 vs invocations=2)? YiFei, maybe we should count only pure syns? > Thanks! ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Flaky bpf cg_storage_* tests 2023-03-28 18:08 ` Stanislav Fomichev @ 2023-03-28 18:57 ` YiFei Zhu 2023-03-28 20:28 ` Stanislav Fomichev 0 siblings, 1 reply; 4+ messages in thread From: YiFei Zhu @ 2023-03-28 18:57 UTC (permalink / raw) To: Stanislav Fomichev; +Cc: Martin KaFai Lau, bpf On Tue, Mar 28, 2023 at 11:08 AM Stanislav Fomichev <sdf@google.com> wrote: > > On Tue, Mar 28, 2023 at 10:40 AM Martin KaFai Lau <martin.lau@linux.dev> wrote: > > > > Hi YiFei and Stan, it is observed that the cg_stroage_* tests fail from time to > > time. A recent example is > > https://github.com/kernel-patches/bpf/actions/runs/4543867424/jobs/8009943115?pr=3924 > > > > Could you help to take a look? may be run it under netns and also have better > > filtering by ip/port when counting packets? > > Error: #43/2 cg_storage_multi/isolated > test_isolated:PASS:skel-load 0 nsec > test_isolated:PASS:parent-egress1-cg-attach 0 nsec > test_isolated:PASS:parent-egress2-cg-attach 0 nsec > test_isolated:PASS:parent-ingress-cg-attach 0 nsec > test_isolated:PASS:first-connect-send 0 nsec > test_isolated:FAIL:first-invoke invocations=2 > > Error: #43/3 cg_storage_multi/shared > test_shared:PASS:skel-load 0 nsec > test_shared:PASS:parent-egress1-cg-attach 0 nsec > test_shared:PASS:parent-egress2-cg-attach 0 nsec > test_shared:PASS:parent-ingress-cg-attach 0 nsec > test_shared:PASS:first-connect-send 0 nsec > test_shared:FAIL:first-invoke invocations=2 > > Probably because we're using tcp? And race with syn vs syn+ack > (invocatoins=1 vs invocations=2)? I don't remember what I wrote in the test :) Nope it's not TCP. I see line 65: server_fd = start_server(AF_INET, SOCK_DGRAM, NULL, 0, 0); However I see line 169: * Assert that there is three runs, two with parent cgroup egress and * one with parent cgroup ingress, stored in separate parent storages. Expected 3 got 2, is it possible we are racing against ingress? > YiFei, maybe we should count only pure syns? > > > Thanks! ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Flaky bpf cg_storage_* tests 2023-03-28 18:57 ` YiFei Zhu @ 2023-03-28 20:28 ` Stanislav Fomichev 0 siblings, 0 replies; 4+ messages in thread From: Stanislav Fomichev @ 2023-03-28 20:28 UTC (permalink / raw) To: YiFei Zhu; +Cc: Martin KaFai Lau, bpf On Tue, Mar 28, 2023 at 11:57 AM YiFei Zhu <zhuyifei@google.com> wrote: > > On Tue, Mar 28, 2023 at 11:08 AM Stanislav Fomichev <sdf@google.com> wrote: > > > > On Tue, Mar 28, 2023 at 10:40 AM Martin KaFai Lau <martin.lau@linux.dev> wrote: > > > > > > Hi YiFei and Stan, it is observed that the cg_stroage_* tests fail from time to > > > time. A recent example is > > > https://github.com/kernel-patches/bpf/actions/runs/4543867424/jobs/8009943115?pr=3924 > > > > > > Could you help to take a look? may be run it under netns and also have better > > > filtering by ip/port when counting packets? > > > > Error: #43/2 cg_storage_multi/isolated > > test_isolated:PASS:skel-load 0 nsec > > test_isolated:PASS:parent-egress1-cg-attach 0 nsec > > test_isolated:PASS:parent-egress2-cg-attach 0 nsec > > test_isolated:PASS:parent-ingress-cg-attach 0 nsec > > test_isolated:PASS:first-connect-send 0 nsec > > test_isolated:FAIL:first-invoke invocations=2 > > > > Error: #43/3 cg_storage_multi/shared > > test_shared:PASS:skel-load 0 nsec > > test_shared:PASS:parent-egress1-cg-attach 0 nsec > > test_shared:PASS:parent-egress2-cg-attach 0 nsec > > test_shared:PASS:parent-ingress-cg-attach 0 nsec > > test_shared:PASS:first-connect-send 0 nsec > > test_shared:FAIL:first-invoke invocations=2 > > > > Probably because we're using tcp? And race with syn vs syn+ack > > (invocatoins=1 vs invocations=2)? > > I don't remember what I wrote in the test :) > > Nope it's not TCP. I see line 65: > server_fd = start_server(AF_INET, SOCK_DGRAM, NULL, 0, 0); > > However I see line 169: > * Assert that there is three runs, two with parent cgroup egress and > * one with parent cgroup ingress, stored in separate parent storages. > > Expected 3 got 2, is it possible we are racing against ingress? Not sure. Can you try to see if you can reproduce locally? > > YiFei, maybe we should count only pure syns? > > > > > Thanks! ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-03-28 20:28 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2023-03-28 17:39 Flaky bpf cg_storage_* tests Martin KaFai Lau 2023-03-28 18:08 ` Stanislav Fomichev 2023-03-28 18:57 ` YiFei Zhu 2023-03-28 20:28 ` Stanislav Fomichev
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.