* Re: [PATCH] tests/acceptance: Disable tests dependent of unreliable apt.armbian.com
2020-09-17 16:39 [PATCH] tests/acceptance: Disable tests dependent of unreliable apt.armbian.com Philippe Mathieu-Daudé
@ 2020-09-17 16:45 ` no-reply
2020-09-17 16:53 ` Thomas Huth
` (4 subsequent siblings)
5 siblings, 0 replies; 9+ messages in thread
From: no-reply @ 2020-09-17 16:45 UTC (permalink / raw)
To: philmd
Cc: ehabkost, qemu-devel, wainersm, kraxel, pavel.dovgaluk, crosa,
pbonzini, philmd
Patchew URL: https://patchew.org/QEMU/20200917163954.50514-1-philmd@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
N/A. Internal error while reading log file
The full log is available at
http://patchew.org/logs/20200917163954.50514-1-philmd@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] tests/acceptance: Disable tests dependent of unreliable apt.armbian.com
2020-09-17 16:39 [PATCH] tests/acceptance: Disable tests dependent of unreliable apt.armbian.com Philippe Mathieu-Daudé
2020-09-17 16:45 ` no-reply
@ 2020-09-17 16:53 ` Thomas Huth
2020-09-17 17:01 ` Philippe Mathieu-Daudé
2020-09-17 17:06 ` no-reply
` (3 subsequent siblings)
5 siblings, 1 reply; 9+ messages in thread
From: Thomas Huth @ 2020-09-17 16:53 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Cc: Eduardo Habkost, Wainer dos Santos Moschetta, Gerd Hoffmann,
Pavel Dovgalyuk, Cleber Rosa, Paolo Bonzini
On 17/09/2020 18.39, Philippe Mathieu-Daudé wrote:
> Armbian servers are not very reliable and confused the GitLab CI
> users a few times this month (path updated, archives moved, and
> now the SSL: CERTIFICATE_VERIFY_FAILED "certificate has expired"
> error). Time to disable these tests.
> Users can still use the artifacts from the cache (or manually add
> them to the cache).
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> tests/acceptance/boot_linux_console.py | 10 ++++++++++
> tests/acceptance/replay_kernel.py | 2 ++
> 2 files changed, 12 insertions(+)
These failures in the Gitlab-CI are quite annoying, indeed.
Acked-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] tests/acceptance: Disable tests dependent of unreliable apt.armbian.com
2020-09-17 16:53 ` Thomas Huth
@ 2020-09-17 17:01 ` Philippe Mathieu-Daudé
2020-09-18 4:54 ` Gerd Hoffmann
0 siblings, 1 reply; 9+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-09-17 17:01 UTC (permalink / raw)
To: Thomas Huth, qemu-devel
Cc: Eduardo Habkost, Wainer dos Santos Moschetta, Gerd Hoffmann,
Pavel Dovgalyuk, Cleber Rosa, Paolo Bonzini
On 9/17/20 6:53 PM, Thomas Huth wrote:
> On 17/09/2020 18.39, Philippe Mathieu-Daudé wrote:
>> Armbian servers are not very reliable and confused the GitLab CI
>> users a few times this month (path updated, archives moved, and
>> now the SSL: CERTIFICATE_VERIFY_FAILED "certificate has expired"
>> error). Time to disable these tests.
>> Users can still use the artifacts from the cache (or manually add
>> them to the cache).
>>
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> ---
>> tests/acceptance/boot_linux_console.py | 10 ++++++++++
>> tests/acceptance/replay_kernel.py | 2 ++
>> 2 files changed, 12 insertions(+)
>
> These failures in the Gitlab-CI are quite annoying, indeed.
I'd rather not go via this path, but since we don't save the
artifacts cache, I can't find a better way to not block all
the other developers using GitLab CI.
But I prefer we disable the tests until something better
emerge, rather that having the developers stopping running
these tests. So this is a quick band-aid patch.
>
> Acked-by: Thomas Huth <thuth@redhat.com>
>
Thanks!
Phil.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] tests/acceptance: Disable tests dependent of unreliable apt.armbian.com
2020-09-17 17:01 ` Philippe Mathieu-Daudé
@ 2020-09-18 4:54 ` Gerd Hoffmann
0 siblings, 0 replies; 9+ messages in thread
From: Gerd Hoffmann @ 2020-09-18 4:54 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: Thomas Huth, Eduardo Habkost, qemu-devel,
Wainer dos Santos Moschetta, Pavel Dovgalyuk, Cleber Rosa,
Paolo Bonzini
On Thu, Sep 17, 2020 at 07:01:22PM +0200, Philippe Mathieu-Daudé wrote:
> On 9/17/20 6:53 PM, Thomas Huth wrote:
> > On 17/09/2020 18.39, Philippe Mathieu-Daudé wrote:
> >> Armbian servers are not very reliable and confused the GitLab CI
> >> users a few times this month (path updated, archives moved, and
> >> now the SSL: CERTIFICATE_VERIFY_FAILED "certificate has expired"
> >> error). Time to disable these tests.
> >> Users can still use the artifacts from the cache (or manually add
> >> them to the cache).
> >>
> >> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> >> ---
> >> tests/acceptance/boot_linux_console.py | 10 ++++++++++
> >> tests/acceptance/replay_kernel.py | 2 ++
> >> 2 files changed, 12 insertions(+)
> >
> > These failures in the Gitlab-CI are quite annoying, indeed.
>
> I'd rather not go via this path, but since we don't save the
> artifacts cache, I can't find a better way to not block all
> the other developers using GitLab CI.
Well, we would need to cache them somewhere, either on qemu.org,
or maybe have a download job in ci which publishes them on
qemu.gitlab.io (gitlab pages).
> But I prefer we disable the tests until something better
> emerge, rather that having the developers stopping running
> these tests. So this is a quick band-aid patch.
Yep, lets disable them until we have a solution.
Acked-by: Gerd Hoffmann <kraxel@redhat.com>
take care,
Gerd
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] tests/acceptance: Disable tests dependent of unreliable apt.armbian.com
2020-09-17 16:39 [PATCH] tests/acceptance: Disable tests dependent of unreliable apt.armbian.com Philippe Mathieu-Daudé
2020-09-17 16:45 ` no-reply
2020-09-17 16:53 ` Thomas Huth
@ 2020-09-17 17:06 ` no-reply
2020-09-17 21:24 ` Willian Rampazzo
` (2 subsequent siblings)
5 siblings, 0 replies; 9+ messages in thread
From: no-reply @ 2020-09-17 17:06 UTC (permalink / raw)
To: philmd
Cc: ehabkost, qemu-devel, wainersm, kraxel, pavel.dovgaluk, crosa,
pbonzini, philmd
Patchew URL: https://patchew.org/QEMU/20200917163954.50514-1-philmd@redhat.com/
Hi,
This series failed build test on FreeBSD host. Please find the details below.
The full log is available at
http://patchew.org/logs/20200917163954.50514-1-philmd@redhat.com/testing.FreeBSD/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] tests/acceptance: Disable tests dependent of unreliable apt.armbian.com
2020-09-17 16:39 [PATCH] tests/acceptance: Disable tests dependent of unreliable apt.armbian.com Philippe Mathieu-Daudé
` (2 preceding siblings ...)
2020-09-17 17:06 ` no-reply
@ 2020-09-17 21:24 ` Willian Rampazzo
2020-09-18 11:34 ` Philippe Mathieu-Daudé
2020-09-18 17:45 ` Philippe Mathieu-Daudé
5 siblings, 0 replies; 9+ messages in thread
From: Willian Rampazzo @ 2020-09-17 21:24 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: Eduardo Habkost, qemu-devel, Wainer dos Santos Moschetta,
Gerd Hoffmann, Pavel Dovgalyuk, Cleber Rosa, Paolo Bonzini
On Thu, Sep 17, 2020 at 1:41 PM Philippe Mathieu-Daudé
<philmd@redhat.com> wrote:
>
> Armbian servers are not very reliable and confused the GitLab CI
> users a few times this month (path updated, archives moved, and
> now the SSL: CERTIFICATE_VERIFY_FAILED "certificate has expired"
> error). Time to disable these tests.
> Users can still use the artifacts from the cache (or manually add
> them to the cache).
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> tests/acceptance/boot_linux_console.py | 10 ++++++++++
> tests/acceptance/replay_kernel.py | 2 ++
> 2 files changed, 12 insertions(+)
>
> diff --git a/tests/acceptance/boot_linux_console.py b/tests/acceptance/boot_linux_console.py
> index 4a366ce93e4..68534693109 100644
> --- a/tests/acceptance/boot_linux_console.py
> +++ b/tests/acceptance/boot_linux_console.py
> @@ -485,6 +485,8 @@ def test_arm_exynos4210_initrd(self):
> self.wait_for_console_pattern('Boot successful.')
> # TODO user command, for now the uart is stuck
>
> + @skipUnless(os.getenv('ARMBIAN_ARTIFACTS_CACHED'),
> + 'Test artifacts fetched from unreliable apt.armbian.com')
> def test_arm_cubieboard_initrd(self):
> """
> :avocado: tags=arch:arm
> @@ -525,6 +527,8 @@ def test_arm_cubieboard_initrd(self):
> 'system-control@1c00000')
> # cubieboard's reboot is not functioning; omit reboot test.
>
> + @skipUnless(os.getenv('ARMBIAN_ARTIFACTS_CACHED'),
> + 'Test artifacts fetched from unreliable apt.armbian.com')
> def test_arm_cubieboard_sata(self):
> """
> :avocado: tags=arch:arm
> @@ -651,6 +655,8 @@ def test_arm_quanta_gsj_initrd(self):
> self.wait_for_console_pattern(
> 'Give root password for system maintenance')
>
> + @skipUnless(os.getenv('ARMBIAN_ARTIFACTS_CACHED'),
> + 'Test artifacts fetched from unreliable apt.armbian.com')
> def test_arm_orangepi(self):
> """
> :avocado: tags=arch:arm
> @@ -676,6 +682,8 @@ def test_arm_orangepi(self):
> console_pattern = 'Kernel command line: %s' % kernel_command_line
> self.wait_for_console_pattern(console_pattern)
>
> + @skipUnless(os.getenv('ARMBIAN_ARTIFACTS_CACHED'),
> + 'Test artifacts fetched from unreliable apt.armbian.com')
> def test_arm_orangepi_initrd(self):
> """
> :avocado: tags=arch:arm
> @@ -718,6 +726,8 @@ def test_arm_orangepi_initrd(self):
> # Wait for VM to shut down gracefully
> self.vm.wait()
>
> + @skipUnless(os.getenv('ARMBIAN_ARTIFACTS_CACHED'),
> + 'Test artifacts fetched from unreliable apt.armbian.com')
> def test_arm_orangepi_sd(self):
> """
> :avocado: tags=arch:arm
> diff --git a/tests/acceptance/replay_kernel.py b/tests/acceptance/replay_kernel.py
> index b79fc8daf8e..7b4310fccf3 100644
> --- a/tests/acceptance/replay_kernel.py
> +++ b/tests/acceptance/replay_kernel.py
> @@ -127,6 +127,8 @@ def test_arm_virt(self):
> self.run_rr(kernel_path, kernel_command_line, console_pattern, shift=1)
>
> @skipIf(os.getenv('GITLAB_CI'), 'Running on GitLab')
> + @skipUnless(os.getenv('ARMBIAN_ARTIFACTS_CACHED'),
> + 'Test artifacts fetched from unreliable apt.armbian.com')
> def test_arm_cubieboard_initrd(self):
> """
> :avocado: tags=arch:arm
> --
> 2.26.2
>
>
Reviewed-by: Willian Rampazzo <willianr@redhat.com>
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] tests/acceptance: Disable tests dependent of unreliable apt.armbian.com
2020-09-17 16:39 [PATCH] tests/acceptance: Disable tests dependent of unreliable apt.armbian.com Philippe Mathieu-Daudé
` (3 preceding siblings ...)
2020-09-17 21:24 ` Willian Rampazzo
@ 2020-09-18 11:34 ` Philippe Mathieu-Daudé
2020-09-18 17:45 ` Philippe Mathieu-Daudé
5 siblings, 0 replies; 9+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-09-18 11:34 UTC (permalink / raw)
To: qemu-devel
Cc: Eduardo Habkost, Wainer dos Santos Moschetta, Gerd Hoffmann,
Pavel Dovgalyuk, Cleber Rosa, Paolo Bonzini
On 9/17/20 6:39 PM, Philippe Mathieu-Daudé wrote:
> Armbian servers are not very reliable and confused the GitLab CI
> users a few times this month (path updated, archives moved, and
> now the SSL: CERTIFICATE_VERIFY_FAILED "certificate has expired"
> error). Time to disable these tests.
> Users can still use the artifacts from the cache (or manually add
> them to the cache).
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
[...]
> diff --git a/tests/acceptance/replay_kernel.py b/tests/acceptance/replay_kernel.py
> index b79fc8daf8e..7b4310fccf3 100644
> --- a/tests/acceptance/replay_kernel.py
> +++ b/tests/acceptance/replay_kernel.py
> @@ -127,6 +127,8 @@ def test_arm_virt(self):
> self.run_rr(kernel_path, kernel_command_line, console_pattern, shift=1)
>
> @skipIf(os.getenv('GITLAB_CI'), 'Running on GitLab')
> + @skipUnless(os.getenv('ARMBIAN_ARTIFACTS_CACHED'),
> + 'Test artifacts fetched from unreliable apt.armbian.com')
> def test_arm_cubieboard_initrd(self):
> """
> :avocado: tags=arch:arm
>
Oops for this one I forgot the "from avocado import skipUnless" line.
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] tests/acceptance: Disable tests dependent of unreliable apt.armbian.com
2020-09-17 16:39 [PATCH] tests/acceptance: Disable tests dependent of unreliable apt.armbian.com Philippe Mathieu-Daudé
` (4 preceding siblings ...)
2020-09-18 11:34 ` Philippe Mathieu-Daudé
@ 2020-09-18 17:45 ` Philippe Mathieu-Daudé
5 siblings, 0 replies; 9+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-09-18 17:45 UTC (permalink / raw)
To: qemu-devel
Cc: Eduardo Habkost, Wainer dos Santos Moschetta, Gerd Hoffmann,
Pavel Dovgalyuk, Cleber Rosa, Paolo Bonzini
On 9/17/20 6:39 PM, Philippe Mathieu-Daudé wrote:
> Armbian servers are not very reliable and confused the GitLab CI
> users a few times this month (path updated, archives moved, and
> now the SSL: CERTIFICATE_VERIFY_FAILED "certificate has expired"
> error). Time to disable these tests.
> Users can still use the artifacts from the cache (or manually add
> them to the cache).
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> tests/acceptance/boot_linux_console.py | 10 ++++++++++
> tests/acceptance/replay_kernel.py | 2 ++
> 2 files changed, 12 insertions(+)
Thanks, applied to my acceptance-testing tree.
^ permalink raw reply [flat|nested] 9+ messages in thread