All of lore.kernel.org
 help / color / mirror / Atom feed
From: Avi Fishman <avifishman70@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Brendan Higgins <brendanhiggins@google.com>,
	Rob Herring <robh+dt@kernel.org>,
	Russell King - ARM Linux <linux@armlinux.org.uk>,
	Mark Rutland <mark.rutland@arm.com>,
	Tomer Maimon <tmaimon77@gmail.com>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Julien Thierry <julien.thierry@arm.com>,
	Philippe Ombredanne <pombredanne@nexb.com>,
	DTML <devicetree@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	OpenBMC Maillist <openbmc@lists.ozlabs.org>
Subject: Re: [PATCH v9 2/3] arm: dts: add Nuvoton NPCM750 device tree
Date: Tue, 13 Feb 2018 11:29:32 +0200	[thread overview]
Message-ID: <CAKKbWA6Otc1ZO_yHpfhxPjbgvvn-QXcXG9sy5=3FZDY8d_20rw@mail.gmail.com> (raw)
In-Reply-To: <CAK8P3a0SJTAkv7_QtDW1sDWFDYHw8tFWZqO6EMwpZ_5KPbhq3Q@mail.gmail.com>

On Tue, Feb 13, 2018 at 10:30 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> On Tue, Feb 6, 2018 at 12:57 AM, Brendan Higgins
> <brendanhiggins@google.com> wrote:
>> Add a common device tree for all Nuvoton NPCM750 BMCs and a board
>> specific device tree for the NPCM750 (Poleg) evaluation board.
>>
>> Signed-off-by: Brendan Higgins <brendanhiggins@google.com>
>> Reviewed-by: Tomer Maimon <tmaimon77@gmail.com>
>> Reviewed-by: Avi Fishman <avifishman70@gmail.com>
>> Reviewed-by: Joel Stanley <joel@jms.id.au>
>> Reviewed-by: Rob Herring <robh@kernel.org>
>> Tested-by: Tomer Maimon <tmaimon77@gmail.com>
>> Tested-by: Avi Fishman <avifishman70@gmail.com>
> ...
>> +               enable-method = "nuvoton,npcm7xx-smp";
>
> I see this has already been reviewed quite a bit, but I'm curious
> about the 'npcm7xx'
> part here. Shouldn't that be a real chip name rather than a wildcard?
>
>        Arnd

There is a family of npcm7xx, some with SMP and some without.
For those who has it, it is common for all to use the same
"nuvoton,npcm7xx-smp".

Avi

WARNING: multiple messages have this Message-ID (diff)
From: avifishman70@gmail.com (Avi Fishman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v9 2/3] arm: dts: add Nuvoton NPCM750 device tree
Date: Tue, 13 Feb 2018 11:29:32 +0200	[thread overview]
Message-ID: <CAKKbWA6Otc1ZO_yHpfhxPjbgvvn-QXcXG9sy5=3FZDY8d_20rw@mail.gmail.com> (raw)
In-Reply-To: <CAK8P3a0SJTAkv7_QtDW1sDWFDYHw8tFWZqO6EMwpZ_5KPbhq3Q@mail.gmail.com>

On Tue, Feb 13, 2018 at 10:30 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> On Tue, Feb 6, 2018 at 12:57 AM, Brendan Higgins
> <brendanhiggins@google.com> wrote:
>> Add a common device tree for all Nuvoton NPCM750 BMCs and a board
>> specific device tree for the NPCM750 (Poleg) evaluation board.
>>
>> Signed-off-by: Brendan Higgins <brendanhiggins@google.com>
>> Reviewed-by: Tomer Maimon <tmaimon77@gmail.com>
>> Reviewed-by: Avi Fishman <avifishman70@gmail.com>
>> Reviewed-by: Joel Stanley <joel@jms.id.au>
>> Reviewed-by: Rob Herring <robh@kernel.org>
>> Tested-by: Tomer Maimon <tmaimon77@gmail.com>
>> Tested-by: Avi Fishman <avifishman70@gmail.com>
> ...
>> +               enable-method = "nuvoton,npcm7xx-smp";
>
> I see this has already been reviewed quite a bit, but I'm curious
> about the 'npcm7xx'
> part here. Shouldn't that be a real chip name rather than a wildcard?
>
>        Arnd

There is a family of npcm7xx, some with SMP and some without.
For those who has it, it is common for all to use the same
"nuvoton,npcm7xx-smp".

Avi

  reply	other threads:[~2018-02-13  9:30 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-05 23:57 [PATCH v9 0/3] arm: npcm: add basic support for Nuvoton BMCs Brendan Higgins
2018-02-05 23:57 ` Brendan Higgins
2018-02-05 23:57 ` Brendan Higgins
2018-02-05 23:57 ` [PATCH v9 1/3] " Brendan Higgins
2018-02-05 23:57   ` Brendan Higgins
2018-02-05 23:57 ` [PATCH v9 2/3] arm: dts: add Nuvoton NPCM750 device tree Brendan Higgins
2018-02-05 23:57   ` Brendan Higgins
2018-02-13  6:22   ` Joel Stanley
2018-02-13  6:22     ` Joel Stanley
2018-02-13  6:22     ` Joel Stanley
2018-02-13  6:22     ` Joel Stanley
2018-02-15  2:28     ` Joel Stanley
2018-02-15  2:28       ` Joel Stanley
2018-02-15  2:28       ` Joel Stanley
2018-02-15  3:59       ` Florian Fainelli
2018-02-15  3:59         ` Florian Fainelli
2018-02-15  3:59         ` Florian Fainelli
2018-02-16 19:14         ` Brendan Higgins
2018-02-16 19:14           ` Brendan Higgins
2018-02-16 19:14           ` Brendan Higgins
2018-02-16 19:14           ` Brendan Higgins
2018-02-13  8:30   ` Arnd Bergmann
2018-02-13  8:30     ` Arnd Bergmann
2018-02-13  8:30     ` Arnd Bergmann
2018-02-13  8:30     ` Arnd Bergmann
2018-02-13  9:29     ` Avi Fishman [this message]
2018-02-13  9:29       ` Avi Fishman
2018-02-13  9:29       ` Avi Fishman
2018-02-13 19:12       ` Brendan Higgins
2018-02-13 19:12         ` Brendan Higgins
2018-02-13 19:12         ` Brendan Higgins
2018-02-13 19:53         ` Arnd Bergmann
2018-02-13 19:53           ` Arnd Bergmann
2018-02-13 19:53           ` Arnd Bergmann
2018-02-05 23:57 ` [PATCH v9 3/3] MAINTAINERS: Add entry for the Nuvoton NPCM architecture Brendan Higgins
2018-02-05 23:57   ` Brendan Higgins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKKbWA6Otc1ZO_yHpfhxPjbgvvn-QXcXG9sy5=3FZDY8d_20rw@mail.gmail.com' \
    --to=avifishman70@gmail.com \
    --cc=arnd@arndb.de \
    --cc=brendanhiggins@google.com \
    --cc=devicetree@vger.kernel.org \
    --cc=f.fainelli@gmail.com \
    --cc=julien.thierry@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=openbmc@lists.ozlabs.org \
    --cc=pombredanne@nexb.com \
    --cc=robh+dt@kernel.org \
    --cc=tmaimon77@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.