* Re: [PATCH v2] USB: host: ehci-npcm7xx: Fix some error codes in probe
@ 2018-06-27 16:30 ` Avi Fishman
0 siblings, 0 replies; 3+ messages in thread
From: Avi Fishman @ 2018-06-27 16:30 UTC (permalink / raw)
To: dan.carpenter; +Cc: Alan Stern, Greg Kroah-Hartman, linux-usb, kernel-janitors
Signed-off-by: Avi Fishman <AviFishman70@gmail.com>
On Wed, Jun 27, 2018 at 4:37 PM Dan Carpenter <dan.carpenter@oracle.com> wrote:
>
> We accidentally return 1 instead of negative error codes.
>
> Fixes: df44831ee2dd ("USB host: Add USB ehci support for nuvoton npcm7xx platform")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> v2: fix typo in the commit message
>
> diff --git a/drivers/usb/host/ehci-npcm7xx.c b/drivers/usb/host/ehci-npcm7xx.c
> index c80a8792d3b0..adaf8fb4b459 100644
> --- a/drivers/usb/host/ehci-npcm7xx.c
> +++ b/drivers/usb/host/ehci-npcm7xx.c
> @@ -74,14 +74,14 @@ static int npcm7xx_ehci_hcd_drv_probe(struct platform_device *pdev)
> if (IS_ERR(gcr_regmap)) {
> dev_err(&pdev->dev, "%s: failed to find nuvoton,npcm750-gcr\n",
> __func__);
> - return IS_ERR(gcr_regmap);
> + return PTR_ERR(gcr_regmap);
> }
>
> rst_regmap = syscon_regmap_lookup_by_compatible("nuvoton,npcm750-rst");
> if (IS_ERR(rst_regmap)) {
> dev_err(&pdev->dev, "%s: failed to find nuvoton,npcm750-rst\n",
> __func__);
> - return IS_ERR(rst_regmap);
> + return PTR_ERR(rst_regmap);
> }
>
> /********* phy init ******/
^ permalink raw reply [flat|nested] 3+ messages in thread
* [v2] USB: host: ehci-npcm7xx: Fix some error codes in probe
@ 2018-06-27 16:30 ` Avi Fishman
0 siblings, 0 replies; 3+ messages in thread
From: Avi Fishman @ 2018-06-27 16:30 UTC (permalink / raw)
To: dan.carpenter; +Cc: Alan Stern, Greg Kroah-Hartman, linux-usb, kernel-janitors
Signed-off-by: Avi Fishman <AviFishman70@gmail.com>
On Wed, Jun 27, 2018 at 4:37 PM Dan Carpenter <dan.carpenter@oracle.com> wrote:
>
> We accidentally return 1 instead of negative error codes.
>
> Fixes: df44831ee2dd ("USB host: Add USB ehci support for nuvoton npcm7xx platform")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> v2: fix typo in the commit message
>
> diff --git a/drivers/usb/host/ehci-npcm7xx.c b/drivers/usb/host/ehci-npcm7xx.c
> index c80a8792d3b0..adaf8fb4b459 100644
> --- a/drivers/usb/host/ehci-npcm7xx.c
> +++ b/drivers/usb/host/ehci-npcm7xx.c
> @@ -74,14 +74,14 @@ static int npcm7xx_ehci_hcd_drv_probe(struct platform_device *pdev)
> if (IS_ERR(gcr_regmap)) {
> dev_err(&pdev->dev, "%s: failed to find nuvoton,npcm750-gcr\n",
> __func__);
> - return IS_ERR(gcr_regmap);
> + return PTR_ERR(gcr_regmap);
> }
>
> rst_regmap = syscon_regmap_lookup_by_compatible("nuvoton,npcm750-rst");
> if (IS_ERR(rst_regmap)) {
> dev_err(&pdev->dev, "%s: failed to find nuvoton,npcm750-rst\n",
> __func__);
> - return IS_ERR(rst_regmap);
> + return PTR_ERR(rst_regmap);
> }
>
> /********* phy init ******/
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v2] USB: host: ehci-npcm7xx: Fix some error codes in probe
@ 2018-06-27 8:37 Dan Carpenter
0 siblings, 0 replies; 3+ messages in thread
From: Dan Carpenter @ 2018-06-27 8:37 UTC (permalink / raw)
To: Alan Stern, Avi Fishman; +Cc: Greg Kroah-Hartman, linux-usb, kernel-janitors
We accidentally return 1 instead of negative error codes.
Fixes: df44831ee2dd ("USB host: Add USB ehci support for nuvoton npcm7xx platform")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
v2: fix typo in the commit message
diff --git a/drivers/usb/host/ehci-npcm7xx.c b/drivers/usb/host/ehci-npcm7xx.c
index c80a8792d3b0..adaf8fb4b459 100644
--- a/drivers/usb/host/ehci-npcm7xx.c
+++ b/drivers/usb/host/ehci-npcm7xx.c
@@ -74,14 +74,14 @@ static int npcm7xx_ehci_hcd_drv_probe(struct platform_device *pdev)
if (IS_ERR(gcr_regmap)) {
dev_err(&pdev->dev, "%s: failed to find nuvoton,npcm750-gcr\n",
__func__);
- return IS_ERR(gcr_regmap);
+ return PTR_ERR(gcr_regmap);
}
rst_regmap = syscon_regmap_lookup_by_compatible("nuvoton,npcm750-rst");
if (IS_ERR(rst_regmap)) {
dev_err(&pdev->dev, "%s: failed to find nuvoton,npcm750-rst\n",
__func__);
- return IS_ERR(rst_regmap);
+ return PTR_ERR(rst_regmap);
}
/********* phy init ******/
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-06-27 16:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-27 16:30 [PATCH v2] USB: host: ehci-npcm7xx: Fix some error codes in probe Avi Fishman
2018-06-27 16:30 ` [v2] " Avi Fishman
-- strict thread matches above, loose matches on Subject: below --
2018-06-27 8:37 [PATCH v2] " Dan Carpenter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.