* [PATCH v2] dt-bindings: timer: nuvoton: Clarify that interrupt of timer 0 should be specified
@ 2021-01-08 16:30 ` Jonathan Neuschäfer
0 siblings, 0 replies; 7+ messages in thread
From: Jonathan Neuschäfer @ 2021-01-08 16:30 UTC (permalink / raw)
To: devicetree
Cc: Jonathan Neuschäfer, Avi Fishman, Tomer Maimon, Tali Perry,
Patrick Venture, Nancy Yuen, Benjamin Fair, Daniel Lezcano,
Thomas Gleixner, Rob Herring, openbmc, linux-kernel
The NPCM750 Timer/Watchdog Controller has multiple interrupt lines,
connected to multiple timers. The driver uses timer 0 for timer
interrupts, so the interrupt line corresponding to timer 0 should be
specified in DT.
I removed the mention of "flags for falling edge", because the timer
controller uses high-level interrupts rather than falling-edge
interrupts, and whether flags should be specified is up the interrupt
controller's DT binding.
Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
---
v2:
- Fix a typo in the word "watchdog"
---
.../devicetree/bindings/timer/nuvoton,npcm7xx-timer.txt | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/timer/nuvoton,npcm7xx-timer.txt b/Documentation/devicetree/bindings/timer/nuvoton,npcm7xx-timer.txt
index ea22dfe485bee..97258f1a1505b 100644
--- a/Documentation/devicetree/bindings/timer/nuvoton,npcm7xx-timer.txt
+++ b/Documentation/devicetree/bindings/timer/nuvoton,npcm7xx-timer.txt
@@ -6,8 +6,7 @@ timer counters.
Required properties:
- compatible : "nuvoton,npcm750-timer" for Poleg NPCM750.
- reg : Offset and length of the register set for the device.
-- interrupts : Contain the timer interrupt with flags for
- falling edge.
+- interrupts : Contain the timer interrupt of timer 0.
- clocks : phandle of timer reference clock (usually a 25 MHz clock).
Example:
--
2.29.2
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH v2] dt-bindings: timer: nuvoton: Clarify that interrupt of timer 0 should be specified
@ 2021-01-08 16:30 ` Jonathan Neuschäfer
0 siblings, 0 replies; 7+ messages in thread
From: Jonathan Neuschäfer @ 2021-01-08 16:30 UTC (permalink / raw)
To: devicetree
Cc: Tomer Maimon, Avi Fishman, Patrick Venture, openbmc,
Daniel Lezcano, Jonathan Neuschäfer, Tali Perry,
Rob Herring, Thomas Gleixner, linux-kernel, Benjamin Fair
The NPCM750 Timer/Watchdog Controller has multiple interrupt lines,
connected to multiple timers. The driver uses timer 0 for timer
interrupts, so the interrupt line corresponding to timer 0 should be
specified in DT.
I removed the mention of "flags for falling edge", because the timer
controller uses high-level interrupts rather than falling-edge
interrupts, and whether flags should be specified is up the interrupt
controller's DT binding.
Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
---
v2:
- Fix a typo in the word "watchdog"
---
.../devicetree/bindings/timer/nuvoton,npcm7xx-timer.txt | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/timer/nuvoton,npcm7xx-timer.txt b/Documentation/devicetree/bindings/timer/nuvoton,npcm7xx-timer.txt
index ea22dfe485bee..97258f1a1505b 100644
--- a/Documentation/devicetree/bindings/timer/nuvoton,npcm7xx-timer.txt
+++ b/Documentation/devicetree/bindings/timer/nuvoton,npcm7xx-timer.txt
@@ -6,8 +6,7 @@ timer counters.
Required properties:
- compatible : "nuvoton,npcm750-timer" for Poleg NPCM750.
- reg : Offset and length of the register set for the device.
-- interrupts : Contain the timer interrupt with flags for
- falling edge.
+- interrupts : Contain the timer interrupt of timer 0.
- clocks : phandle of timer reference clock (usually a 25 MHz clock).
Example:
--
2.29.2
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v2] dt-bindings: timer: nuvoton: Clarify that interrupt of timer 0 should be specified
2021-01-08 16:30 ` Jonathan Neuschäfer
@ 2021-01-10 10:19 ` Avi Fishman
-1 siblings, 0 replies; 7+ messages in thread
From: Avi Fishman @ 2021-01-10 10:19 UTC (permalink / raw)
To: Jonathan Neuschäfer
Cc: devicetree, Tomer Maimon, Tali Perry, Patrick Venture,
Nancy Yuen, Benjamin Fair, Daniel Lezcano, Thomas Gleixner,
Rob Herring, OpenBMC Maillist, Linux Kernel Mailing List
On Fri, Jan 8, 2021 at 6:30 PM Jonathan Neuschäfer
<j.neuschaefer@gmx.net> wrote:
>
> The NPCM750 Timer/Watchdog Controller has multiple interrupt lines,
> connected to multiple timers. The driver uses timer 0 for timer
> interrupts, so the interrupt line corresponding to timer 0 should be
> specified in DT.
>
> I removed the mention of "flags for falling edge", because the timer
> controller uses high-level interrupts rather than falling-edge
> interrupts, and whether flags should be specified is up the interrupt
> controller's DT binding.
>
> Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
Reviewed-by Avi Fishman <avifishman70@gmail.com>
> ---
>
> v2:
> - Fix a typo in the word "watchdog"
> ---
> .../devicetree/bindings/timer/nuvoton,npcm7xx-timer.txt | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/timer/nuvoton,npcm7xx-timer.txt b/Documentation/devicetree/bindings/timer/nuvoton,npcm7xx-timer.txt
> index ea22dfe485bee..97258f1a1505b 100644
> --- a/Documentation/devicetree/bindings/timer/nuvoton,npcm7xx-timer.txt
> +++ b/Documentation/devicetree/bindings/timer/nuvoton,npcm7xx-timer.txt
> @@ -6,8 +6,7 @@ timer counters.
> Required properties:
> - compatible : "nuvoton,npcm750-timer" for Poleg NPCM750.
> - reg : Offset and length of the register set for the device.
> -- interrupts : Contain the timer interrupt with flags for
> - falling edge.
> +- interrupts : Contain the timer interrupt of timer 0.
> - clocks : phandle of timer reference clock (usually a 25 MHz clock).
>
> Example:
> --
> 2.29.2
>
--
Regards,
Avi
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] dt-bindings: timer: nuvoton: Clarify that interrupt of timer 0 should be specified
@ 2021-01-10 10:19 ` Avi Fishman
0 siblings, 0 replies; 7+ messages in thread
From: Avi Fishman @ 2021-01-10 10:19 UTC (permalink / raw)
To: Jonathan Neuschäfer
Cc: devicetree, Benjamin Fair, Patrick Venture, OpenBMC Maillist,
Daniel Lezcano, Linux Kernel Mailing List, Tali Perry,
Rob Herring, Thomas Gleixner, Tomer Maimon
On Fri, Jan 8, 2021 at 6:30 PM Jonathan Neuschäfer
<j.neuschaefer@gmx.net> wrote:
>
> The NPCM750 Timer/Watchdog Controller has multiple interrupt lines,
> connected to multiple timers. The driver uses timer 0 for timer
> interrupts, so the interrupt line corresponding to timer 0 should be
> specified in DT.
>
> I removed the mention of "flags for falling edge", because the timer
> controller uses high-level interrupts rather than falling-edge
> interrupts, and whether flags should be specified is up the interrupt
> controller's DT binding.
>
> Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
Reviewed-by Avi Fishman <avifishman70@gmail.com>
> ---
>
> v2:
> - Fix a typo in the word "watchdog"
> ---
> .../devicetree/bindings/timer/nuvoton,npcm7xx-timer.txt | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/timer/nuvoton,npcm7xx-timer.txt b/Documentation/devicetree/bindings/timer/nuvoton,npcm7xx-timer.txt
> index ea22dfe485bee..97258f1a1505b 100644
> --- a/Documentation/devicetree/bindings/timer/nuvoton,npcm7xx-timer.txt
> +++ b/Documentation/devicetree/bindings/timer/nuvoton,npcm7xx-timer.txt
> @@ -6,8 +6,7 @@ timer counters.
> Required properties:
> - compatible : "nuvoton,npcm750-timer" for Poleg NPCM750.
> - reg : Offset and length of the register set for the device.
> -- interrupts : Contain the timer interrupt with flags for
> - falling edge.
> +- interrupts : Contain the timer interrupt of timer 0.
> - clocks : phandle of timer reference clock (usually a 25 MHz clock).
>
> Example:
> --
> 2.29.2
>
--
Regards,
Avi
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] dt-bindings: timer: nuvoton: Clarify that interrupt of timer 0 should be specified
2021-01-08 16:30 ` Jonathan Neuschäfer
@ 2021-01-13 15:23 ` Rob Herring
-1 siblings, 0 replies; 7+ messages in thread
From: Rob Herring @ 2021-01-13 15:23 UTC (permalink / raw)
To: Jonathan Neuschäfer
Cc: Rob Herring, Patrick Venture, Tali Perry, Avi Fishman,
linux-kernel, Daniel Lezcano, devicetree, Tomer Maimon,
Benjamin Fair, Nancy Yuen, openbmc, Thomas Gleixner
On Fri, 08 Jan 2021 17:30:04 +0100, Jonathan Neuschäfer wrote:
> The NPCM750 Timer/Watchdog Controller has multiple interrupt lines,
> connected to multiple timers. The driver uses timer 0 for timer
> interrupts, so the interrupt line corresponding to timer 0 should be
> specified in DT.
>
> I removed the mention of "flags for falling edge", because the timer
> controller uses high-level interrupts rather than falling-edge
> interrupts, and whether flags should be specified is up the interrupt
> controller's DT binding.
>
> Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
> ---
>
> v2:
> - Fix a typo in the word "watchdog"
> ---
> .../devicetree/bindings/timer/nuvoton,npcm7xx-timer.txt | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] dt-bindings: timer: nuvoton: Clarify that interrupt of timer 0 should be specified
@ 2021-01-13 15:23 ` Rob Herring
0 siblings, 0 replies; 7+ messages in thread
From: Rob Herring @ 2021-01-13 15:23 UTC (permalink / raw)
To: Jonathan Neuschäfer
Cc: devicetree, Tomer Maimon, Avi Fishman, Patrick Venture, openbmc,
Daniel Lezcano, linux-kernel, Tali Perry, Rob Herring,
Thomas Gleixner, Benjamin Fair
On Fri, 08 Jan 2021 17:30:04 +0100, Jonathan Neuschäfer wrote:
> The NPCM750 Timer/Watchdog Controller has multiple interrupt lines,
> connected to multiple timers. The driver uses timer 0 for timer
> interrupts, so the interrupt line corresponding to timer 0 should be
> specified in DT.
>
> I removed the mention of "flags for falling edge", because the timer
> controller uses high-level interrupts rather than falling-edge
> interrupts, and whether flags should be specified is up the interrupt
> controller's DT binding.
>
> Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
> ---
>
> v2:
> - Fix a typo in the word "watchdog"
> ---
> .../devicetree/bindings/timer/nuvoton,npcm7xx-timer.txt | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [tip: timers/core] dt-bindings: timer: nuvoton: Clarify that interrupt of timer 0 should be specified
2021-01-08 16:30 ` Jonathan Neuschäfer
` (2 preceding siblings ...)
(?)
@ 2021-02-10 10:06 ` tip-bot2 for Jonathan Neuschäfer
-1 siblings, 0 replies; 7+ messages in thread
From: tip-bot2 for Jonathan Neuschäfer @ 2021-02-10 10:06 UTC (permalink / raw)
To: linux-tip-commits
Cc: j.neuschaefer, Rob Herring, Daniel Lezcano, x86, linux-kernel
The following commit has been merged into the timers/core branch of tip:
Commit-ID: e1922b5da0e6869f1850c4447bed0b9cb1cf5034
Gitweb: https://git.kernel.org/tip/e1922b5da0e6869f1850c4447bed0b9cb1cf5034
Author: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
AuthorDate: Fri, 08 Jan 2021 17:30:04 +01:00
Committer: Daniel Lezcano <daniel.lezcano@linaro.org>
CommitterDate: Mon, 18 Jan 2021 16:33:51 +01:00
dt-bindings: timer: nuvoton: Clarify that interrupt of timer 0 should be specified
The NPCM750 Timer/Watchdog Controller has multiple interrupt lines,
connected to multiple timers. The driver uses timer 0 for timer
interrupts, so the interrupt line corresponding to timer 0 should be
specified in DT.
I removed the mention of "flags for falling edge", because the timer
controller uses high-level interrupts rather than falling-edge
interrupts, and whether flags should be specified is up the interrupt
controller's DT binding.
Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
Acked-by: Rob Herring <robh@kernel.org>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Link: https://lore.kernel.org/r/20210108163004.492649-1-j.neuschaefer@gmx.net
---
Documentation/devicetree/bindings/timer/nuvoton,npcm7xx-timer.txt | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/timer/nuvoton,npcm7xx-timer.txt b/Documentation/devicetree/bindings/timer/nuvoton,npcm7xx-timer.txt
index ea22dfe..97258f1 100644
--- a/Documentation/devicetree/bindings/timer/nuvoton,npcm7xx-timer.txt
+++ b/Documentation/devicetree/bindings/timer/nuvoton,npcm7xx-timer.txt
@@ -6,8 +6,7 @@ timer counters.
Required properties:
- compatible : "nuvoton,npcm750-timer" for Poleg NPCM750.
- reg : Offset and length of the register set for the device.
-- interrupts : Contain the timer interrupt with flags for
- falling edge.
+- interrupts : Contain the timer interrupt of timer 0.
- clocks : phandle of timer reference clock (usually a 25 MHz clock).
Example:
^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-02-10 10:20 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-08 16:30 [PATCH v2] dt-bindings: timer: nuvoton: Clarify that interrupt of timer 0 should be specified Jonathan Neuschäfer
2021-01-08 16:30 ` Jonathan Neuschäfer
2021-01-10 10:19 ` Avi Fishman
2021-01-10 10:19 ` Avi Fishman
2021-01-13 15:23 ` Rob Herring
2021-01-13 15:23 ` Rob Herring
2021-02-10 10:06 ` [tip: timers/core] " tip-bot2 for Jonathan Neuschäfer
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.