All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel.vetter@ffwll.ch>
To: Michal Simek <michal.simek@xilinx.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"monstr@monstr.eu" <monstr@monstr.eu>,
	Benjamin Gaignard <benjamin.gaignard@linaro.org>,
	Tomi Valkeinen <tomi.valkeinen@ti.com>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	Arnd Bergmann <arnd@arndb.de>,
	"linux-fbdev@vger.kernel.org" <linux-fbdev@vger.kernel.org>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Paul Burton <paul.burton@imgtec.com>
Subject: Re: [PATCH 2/2] video: fbdev: Enable Xilinx FB for ZynqMP
Date: Mon, 14 Aug 2017 15:49:02 +0200	[thread overview]
Message-ID: <CAKMK7uEKQMRFGdGqrPo-i0Z9ht6-zC6G8hsVW7FKr9cxbpwuPQ@mail.gmail.com> (raw)
In-Reply-To: <757d86d1-cca5-3a99-a371-a4c7e1c76f9b@xilinx.com>

On Mon, Aug 14, 2017 at 3:46 PM, Michal Simek <michal.simek@xilinx.com> wrote:
> On 14.8.2017 15:42, Linus Walleij wrote:
>> On Tue, Aug 8, 2017 at 10:10 AM, Michal Simek <michal.simek@xilinx.com> wrote:
>>
>>> Enable this driver for Xilinx ZynqMP.
>>>
>>> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
>>
>> Not a comment on the patch per se, but I would advice you to look into
>> migrating the Xilinx frame buffer to DRI/DRM/KMS.
>>
>> The recent CMA helpers has made it very simple and focused to write
>> DRM drivers. See for example drivers/gpu/drm/pl111
>
> There is a lot of work done by xilinx in this area gpu/drm/kms. I am
> trying to upstream what xilinx has in soc tree and this change is there.
> Maybe in this case it is useless and none is using it but it is there
> and I don't want to break user. There shouldn't be any technical problem
> to run this old fb driver in pl on arm64.

A proper drm kms driver gives you backwards compat for fbdev for free.
And we're taking in patches to fill feature gaps in our fbdev
emulation as people hit them. There no reason nowadays at all to merge
new fbdev native drivers, your users will be taken care of by a drm
kms driver fully.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

WARNING: multiple messages have this Message-ID (diff)
From: Daniel Vetter <daniel.vetter@ffwll.ch>
To: Michal Simek <michal.simek@xilinx.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"monstr@monstr.eu" <monstr@monstr.eu>,
	Benjamin Gaignard <benjamin.gaignard@linaro.org>,
	Tomi Valkeinen <tomi.valkeinen@ti.com>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	Arnd Bergmann <arnd@arndb.de>,
	"linux-fbdev@vger.kernel.org" <linux-fbdev@vger.kernel.org>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Paul Burton <paul.burton@imgtec.com>
Subject: Re: [PATCH 2/2] video: fbdev: Enable Xilinx FB for ZynqMP
Date: Mon, 14 Aug 2017 13:49:02 +0000	[thread overview]
Message-ID: <CAKMK7uEKQMRFGdGqrPo-i0Z9ht6-zC6G8hsVW7FKr9cxbpwuPQ@mail.gmail.com> (raw)
In-Reply-To: <757d86d1-cca5-3a99-a371-a4c7e1c76f9b@xilinx.com>

On Mon, Aug 14, 2017 at 3:46 PM, Michal Simek <michal.simek@xilinx.com> wrote:
> On 14.8.2017 15:42, Linus Walleij wrote:
>> On Tue, Aug 8, 2017 at 10:10 AM, Michal Simek <michal.simek@xilinx.com> wrote:
>>
>>> Enable this driver for Xilinx ZynqMP.
>>>
>>> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
>>
>> Not a comment on the patch per se, but I would advice you to look into
>> migrating the Xilinx frame buffer to DRI/DRM/KMS.
>>
>> The recent CMA helpers has made it very simple and focused to write
>> DRM drivers. See for example drivers/gpu/drm/pl111
>
> There is a lot of work done by xilinx in this area gpu/drm/kms. I am
> trying to upstream what xilinx has in soc tree and this change is there.
> Maybe in this case it is useless and none is using it but it is there
> and I don't want to break user. There shouldn't be any technical problem
> to run this old fb driver in pl on arm64.

A proper drm kms driver gives you backwards compat for fbdev for free.
And we're taking in patches to fill feature gaps in our fbdev
emulation as people hit them. There no reason nowadays at all to merge
new fbdev native drivers, your users will be taken care of by a drm
kms driver fully.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

  reply	other threads:[~2017-08-14 13:49 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20170808081042epcas4p3b6787c3895bec41cb37aa4ae868adb45@epcas4p3.samsung.com>
2017-08-08  8:10 ` [PATCH 1/2] video: fbdev: Fix multiple style issues in xilinxfb Michal Simek
2017-08-08  8:10   ` Michal Simek
2017-08-08  8:10   ` Michal Simek
2017-08-08  8:10   ` [PATCH 2/2] video: fbdev: Enable Xilinx FB for ZynqMP Michal Simek
2017-08-08  8:10     ` Michal Simek
2017-08-14 13:42     ` Linus Walleij
2017-08-14 13:42       ` Linus Walleij
2017-08-14 13:46       ` Michal Simek
2017-08-14 13:46         ` Michal Simek
2017-08-14 13:49         ` Daniel Vetter [this message]
2017-08-14 13:49           ` Daniel Vetter
2017-08-14 13:50           ` Michal Simek
2017-08-14 13:50             ` Michal Simek
2017-08-21 14:07     ` Bartlomiej Zolnierkiewicz
2017-08-21 14:07       ` Bartlomiej Zolnierkiewicz
2017-08-21 14:04   ` [PATCH 1/2] video: fbdev: Fix multiple style issues in xilinxfb Bartlomiej Zolnierkiewicz
2017-08-21 14:04     ` Bartlomiej Zolnierkiewicz
2017-08-21 14:04     ` Bartlomiej Zolnierkiewicz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKMK7uEKQMRFGdGqrPo-i0Z9ht6-zC6G8hsVW7FKr9cxbpwuPQ@mail.gmail.com \
    --to=daniel.vetter@ffwll.ch \
    --cc=arnd@arndb.de \
    --cc=b.zolnierkie@samsung.com \
    --cc=benjamin.gaignard@linaro.org \
    --cc=krzk@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michal.simek@xilinx.com \
    --cc=monstr@monstr.eu \
    --cc=paul.burton@imgtec.com \
    --cc=tomi.valkeinen@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.