Re: [PATCH v2 1/1] drm/i915: Fix VGA handling using stop_machine() or mmio

[Daniel Vetter <daniel@ffwll.ch>]

On Mon, Oct 7, 2013 at 2:23 AM, Dave Airlie <airlied@gmail.com> wrote:
> I'm think I'm going to make an executive decision to merge Ville's
> latest patch to avoid the regression, the other option being just to
> revert everything back to the status quo by reverting all the patches
> from the past few months, if people are happier with that then maybe
> we should just do that for now and try and design our way out of it
> properly by reengineering userspace and plan to avoid the regression
> next time.

Ack on merging Ville's hack. Longer-term we could beautify the pig a
bit by moving it into vgaarb.c and avoiding the stop_machine if no one
else has a vga lock. And I think in next we could try to limit the vga
redisable hack in the lid notifier a bit on more modern platforms to
avoid the dreaded stop_machine at runtime and relegate it to just
resume/driver load.

Really long term (once broken X servers have died) we can try to rip
this hack out again. Or maybe intel hw engineers get their act
together beforehand ;-)

So can you directly pick it up since I've just flushed out my -fixes queue?

Thanks, Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch