* [PATCH] char/agp: Disable frontend without CONFIG_DRM_LEGACY @ 2020-11-17 21:40 Daniel Vetter 2020-11-18 8:02 ` Thomas Zimmermann 2020-11-18 15:55 ` Adam Jackson 0 siblings, 2 replies; 8+ messages in thread From: Daniel Vetter @ 2020-11-17 21:40 UTC (permalink / raw) To: DRI Development; +Cc: David Airlie, Daniel Vetter, Daniel Vetter It's probably full of bugs ready for exploiting by userspace. And there's not going to be any userspace for this without any of the drm legacy drivers enabled too. So just couple it together. Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> Cc: David Airlie <airlied@linux.ie> Cc: Adam Jackson <ajax@redhat.com> --- drivers/char/agp/Makefile | 6 +++++- drivers/char/agp/agp.h | 5 +++++ 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/char/agp/Makefile b/drivers/char/agp/Makefile index cb2497d157f6..90ed8c789e48 100644 --- a/drivers/char/agp/Makefile +++ b/drivers/char/agp/Makefile @@ -1,7 +1,11 @@ # SPDX-License-Identifier: GPL-2.0 -agpgart-y := backend.o frontend.o generic.o isoch.o +agpgart-y := backend.o generic.o isoch.o +ifeq ($(CONFIG_DRM_LEGACY),y) agpgart-$(CONFIG_COMPAT) += compat_ioctl.o +agpgart-y += frontend.o +endif + obj-$(CONFIG_AGP) += agpgart.o obj-$(CONFIG_AGP_ALI) += ali-agp.o diff --git a/drivers/char/agp/agp.h b/drivers/char/agp/agp.h index 4eb1c772ded7..bb09d64cd51e 100644 --- a/drivers/char/agp/agp.h +++ b/drivers/char/agp/agp.h @@ -186,8 +186,13 @@ int agp_add_bridge(struct agp_bridge_data *bridge); void agp_remove_bridge(struct agp_bridge_data *bridge); /* Frontend routines. */ +#if IS_ENABLED(CONFIG_DRM_LEGACY) int agp_frontend_initialize(void); void agp_frontend_cleanup(void); +#else +static inline int agp_frontend_initialize(void) { return 0; } +static inline void agp_frontend_cleanup(void) {} +#endif /* Generic routines. */ void agp_generic_enable(struct agp_bridge_data *bridge, u32 mode); -- 2.29.2 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] char/agp: Disable frontend without CONFIG_DRM_LEGACY 2020-11-17 21:40 [PATCH] char/agp: Disable frontend without CONFIG_DRM_LEGACY Daniel Vetter @ 2020-11-18 8:02 ` Thomas Zimmermann 2020-11-18 8:23 ` Christian König 2020-11-18 15:55 ` Adam Jackson 1 sibling, 1 reply; 8+ messages in thread From: Thomas Zimmermann @ 2020-11-18 8:02 UTC (permalink / raw) To: Daniel Vetter, DRI Development Cc: David Airlie, Daniel Vetter, Alexander Deucher, Christian König Hi Am 17.11.20 um 22:40 schrieb Daniel Vetter: > It's probably full of bugs ready for exploiting by userspace. And > there's not going to be any userspace for this without any of the drm > legacy drivers enabled too. So just couple it together. > > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> > Cc: David Airlie <airlied@linux.ie> > Cc: Adam Jackson <ajax@redhat.com> > --- > drivers/char/agp/Makefile | 6 +++++- > drivers/char/agp/agp.h | 5 +++++ > 2 files changed, 10 insertions(+), 1 deletion(-) > > diff --git a/drivers/char/agp/Makefile b/drivers/char/agp/Makefile > index cb2497d157f6..90ed8c789e48 100644 > --- a/drivers/char/agp/Makefile > +++ b/drivers/char/agp/Makefile > @@ -1,7 +1,11 @@ > # SPDX-License-Identifier: GPL-2.0 > -agpgart-y := backend.o frontend.o generic.o isoch.o > +agpgart-y := backend.o generic.o isoch.o > > +ifeq ($(CONFIG_DRM_LEGACY),y) > agpgart-$(CONFIG_COMPAT) += compat_ioctl.o > +agpgart-y += frontend.o > +endif > + > > obj-$(CONFIG_AGP) += agpgart.o > obj-$(CONFIG_AGP_ALI) += ali-agp.o > diff --git a/drivers/char/agp/agp.h b/drivers/char/agp/agp.h > index 4eb1c772ded7..bb09d64cd51e 100644 > --- a/drivers/char/agp/agp.h > +++ b/drivers/char/agp/agp.h > @@ -186,8 +186,13 @@ int agp_add_bridge(struct agp_bridge_data *bridge); > void agp_remove_bridge(struct agp_bridge_data *bridge); > > /* Frontend routines. */ > +#if IS_ENABLED(CONFIG_DRM_LEGACY) > int agp_frontend_initialize(void); > void agp_frontend_cleanup(void); > +#else > +static inline int agp_frontend_initialize(void) { return 0; } > +static inline void agp_frontend_cleanup(void) {} > +#endif There's one non-legacy driver that uses these agp structures, which is radeon. Does this change affect radeon? Best regards Thomas > > /* Generic routines. */ > void agp_generic_enable(struct agp_bridge_data *bridge, u32 mode); > -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Felix Imendörffer _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] char/agp: Disable frontend without CONFIG_DRM_LEGACY 2020-11-18 8:02 ` Thomas Zimmermann @ 2020-11-18 8:23 ` Christian König 2020-11-18 8:53 ` Daniel Vetter 0 siblings, 1 reply; 8+ messages in thread From: Christian König @ 2020-11-18 8:23 UTC (permalink / raw) To: Thomas Zimmermann, Daniel Vetter, DRI Development Cc: David Airlie, Daniel Vetter, Alexander Deucher Am 18.11.20 um 09:02 schrieb Thomas Zimmermann: > Hi > > Am 17.11.20 um 22:40 schrieb Daniel Vetter: >> It's probably full of bugs ready for exploiting by userspace. And >> there's not going to be any userspace for this without any of the drm >> legacy drivers enabled too. So just couple it together. >> >> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> >> Cc: David Airlie <airlied@linux.ie> >> Cc: Adam Jackson <ajax@redhat.com> >> --- >> drivers/char/agp/Makefile | 6 +++++- >> drivers/char/agp/agp.h | 5 +++++ >> 2 files changed, 10 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/char/agp/Makefile b/drivers/char/agp/Makefile >> index cb2497d157f6..90ed8c789e48 100644 >> --- a/drivers/char/agp/Makefile >> +++ b/drivers/char/agp/Makefile >> @@ -1,7 +1,11 @@ >> # SPDX-License-Identifier: GPL-2.0 >> -agpgart-y := backend.o frontend.o generic.o isoch.o >> +agpgart-y := backend.o generic.o isoch.o >> >> +ifeq ($(CONFIG_DRM_LEGACY),y) >> agpgart-$(CONFIG_COMPAT) += compat_ioctl.o >> +agpgart-y += frontend.o >> +endif >> + >> >> obj-$(CONFIG_AGP) += agpgart.o >> obj-$(CONFIG_AGP_ALI) += ali-agp.o >> diff --git a/drivers/char/agp/agp.h b/drivers/char/agp/agp.h >> index 4eb1c772ded7..bb09d64cd51e 100644 >> --- a/drivers/char/agp/agp.h >> +++ b/drivers/char/agp/agp.h >> @@ -186,8 +186,13 @@ int agp_add_bridge(struct agp_bridge_data *bridge); >> void agp_remove_bridge(struct agp_bridge_data *bridge); >> >> /* Frontend routines. */ >> +#if IS_ENABLED(CONFIG_DRM_LEGACY) >> int agp_frontend_initialize(void); >> void agp_frontend_cleanup(void); >> +#else >> +static inline int agp_frontend_initialize(void) { return 0; } >> +static inline void agp_frontend_cleanup(void) {} >> +#endif > There's one non-legacy driver that uses these agp structures, which is > radeon. Does this change affect radeon? Nouveau uses AGP as well, but I'm not sure if both drivers use any of this stuff. Regards, Christian. > > Best regards > Thomas > >> >> /* Generic routines. */ >> void agp_generic_enable(struct agp_bridge_data *bridge, u32 mode); >> _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] char/agp: Disable frontend without CONFIG_DRM_LEGACY 2020-11-18 8:23 ` Christian König @ 2020-11-18 8:53 ` Daniel Vetter 2020-11-18 9:02 ` Thomas Zimmermann 0 siblings, 1 reply; 8+ messages in thread From: Daniel Vetter @ 2020-11-18 8:53 UTC (permalink / raw) To: Christian König Cc: David Airlie, Daniel Vetter, Alexander Deucher, DRI Development, Thomas Zimmermann On Wed, Nov 18, 2020 at 9:24 AM Christian König <christian.koenig@amd.com> wrote: > > Am 18.11.20 um 09:02 schrieb Thomas Zimmermann: > > Hi > > > > Am 17.11.20 um 22:40 schrieb Daniel Vetter: > >> It's probably full of bugs ready for exploiting by userspace. And > >> there's not going to be any userspace for this without any of the drm > >> legacy drivers enabled too. So just couple it together. > >> > >> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> > >> Cc: David Airlie <airlied@linux.ie> > >> Cc: Adam Jackson <ajax@redhat.com> > >> --- > >> drivers/char/agp/Makefile | 6 +++++- > >> drivers/char/agp/agp.h | 5 +++++ > >> 2 files changed, 10 insertions(+), 1 deletion(-) > >> > >> diff --git a/drivers/char/agp/Makefile b/drivers/char/agp/Makefile > >> index cb2497d157f6..90ed8c789e48 100644 > >> --- a/drivers/char/agp/Makefile > >> +++ b/drivers/char/agp/Makefile > >> @@ -1,7 +1,11 @@ > >> # SPDX-License-Identifier: GPL-2.0 > >> -agpgart-y := backend.o frontend.o generic.o isoch.o > >> +agpgart-y := backend.o generic.o isoch.o > >> > >> +ifeq ($(CONFIG_DRM_LEGACY),y) > >> agpgart-$(CONFIG_COMPAT) += compat_ioctl.o > >> +agpgart-y += frontend.o > >> +endif > >> + > >> > >> obj-$(CONFIG_AGP) += agpgart.o > >> obj-$(CONFIG_AGP_ALI) += ali-agp.o > >> diff --git a/drivers/char/agp/agp.h b/drivers/char/agp/agp.h > >> index 4eb1c772ded7..bb09d64cd51e 100644 > >> --- a/drivers/char/agp/agp.h > >> +++ b/drivers/char/agp/agp.h > >> @@ -186,8 +186,13 @@ int agp_add_bridge(struct agp_bridge_data *bridge); > >> void agp_remove_bridge(struct agp_bridge_data *bridge); > >> > >> /* Frontend routines. */ > >> +#if IS_ENABLED(CONFIG_DRM_LEGACY) > >> int agp_frontend_initialize(void); > >> void agp_frontend_cleanup(void); > >> +#else > >> +static inline int agp_frontend_initialize(void) { return 0; } > >> +static inline void agp_frontend_cleanup(void) {} > >> +#endif > > There's one non-legacy driver that uses these agp structures, which is > > radeon. Does this change affect radeon? > > Nouveau uses AGP as well, but I'm not sure if both drivers use any of > this stuff. frontend = /dev/agp chardev interface for userspace drivers. If you're looking at kernel drivers, you're looking at the wrong thing, the kernel-internal interface is in char/agp/backend.c and still enabled. So no impact at all on any kernel code. Now the impact this does have on kms drivers using agp is that there's no longer a userspace ioctl interface to change the agp setup and mappings and fight the kms driver (which assumes it's fully in control of agp configuration). -Daniel > > Regards, > Christian. > > > > > Best regards > > Thomas > > > >> > >> /* Generic routines. */ > >> void agp_generic_enable(struct agp_bridge_data *bridge, u32 mode); > >> > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] char/agp: Disable frontend without CONFIG_DRM_LEGACY 2020-11-18 8:53 ` Daniel Vetter @ 2020-11-18 9:02 ` Thomas Zimmermann 2020-11-18 10:51 ` Christian König 0 siblings, 1 reply; 8+ messages in thread From: Thomas Zimmermann @ 2020-11-18 9:02 UTC (permalink / raw) To: Daniel Vetter, Christian König Cc: David Airlie, Daniel Vetter, Alexander Deucher, DRI Development [-- Attachment #1.1.1.1: Type: text/plain, Size: 3368 bytes --] Hi Am 18.11.20 um 09:53 schrieb Daniel Vetter: > On Wed, Nov 18, 2020 at 9:24 AM Christian König > <christian.koenig@amd.com> wrote: >> >> Am 18.11.20 um 09:02 schrieb Thomas Zimmermann: >>> Hi >>> >>> Am 17.11.20 um 22:40 schrieb Daniel Vetter: >>>> It's probably full of bugs ready for exploiting by userspace. And >>>> there's not going to be any userspace for this without any of the drm >>>> legacy drivers enabled too. So just couple it together. >>>> >>>> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> >>>> Cc: David Airlie <airlied@linux.ie> >>>> Cc: Adam Jackson <ajax@redhat.com> >>>> --- >>>> drivers/char/agp/Makefile | 6 +++++- >>>> drivers/char/agp/agp.h | 5 +++++ >>>> 2 files changed, 10 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/drivers/char/agp/Makefile b/drivers/char/agp/Makefile >>>> index cb2497d157f6..90ed8c789e48 100644 >>>> --- a/drivers/char/agp/Makefile >>>> +++ b/drivers/char/agp/Makefile >>>> @@ -1,7 +1,11 @@ >>>> # SPDX-License-Identifier: GPL-2.0 >>>> -agpgart-y := backend.o frontend.o generic.o isoch.o >>>> +agpgart-y := backend.o generic.o isoch.o >>>> >>>> +ifeq ($(CONFIG_DRM_LEGACY),y) >>>> agpgart-$(CONFIG_COMPAT) += compat_ioctl.o >>>> +agpgart-y += frontend.o >>>> +endif >>>> + >>>> >>>> obj-$(CONFIG_AGP) += agpgart.o >>>> obj-$(CONFIG_AGP_ALI) += ali-agp.o >>>> diff --git a/drivers/char/agp/agp.h b/drivers/char/agp/agp.h >>>> index 4eb1c772ded7..bb09d64cd51e 100644 >>>> --- a/drivers/char/agp/agp.h >>>> +++ b/drivers/char/agp/agp.h >>>> @@ -186,8 +186,13 @@ int agp_add_bridge(struct agp_bridge_data *bridge); >>>> void agp_remove_bridge(struct agp_bridge_data *bridge); >>>> >>>> /* Frontend routines. */ >>>> +#if IS_ENABLED(CONFIG_DRM_LEGACY) >>>> int agp_frontend_initialize(void); >>>> void agp_frontend_cleanup(void); >>>> +#else >>>> +static inline int agp_frontend_initialize(void) { return 0; } >>>> +static inline void agp_frontend_cleanup(void) {} >>>> +#endif >>> There's one non-legacy driver that uses these agp structures, which is >>> radeon. Does this change affect radeon? >> >> Nouveau uses AGP as well, but I'm not sure if both drivers use any of >> this stuff. > > frontend = /dev/agp chardev interface for userspace drivers. If you're > looking at kernel drivers, you're looking at the wrong thing, the > kernel-internal interface is in char/agp/backend.c and still enabled. > So no impact at all on any kernel code. > > Now the impact this does have on kms drivers using agp is that there's > no longer a userspace ioctl interface to change the agp setup and > mappings and fight the kms driver (which assumes it's fully in control > of agp configuration). Thanks for clarifying. I'm certainly not qualified, but still Acked-by: Thomas Zimmermann <tzimmermann@suse.de> Best regards Thomas > -Daniel > >> >> Regards, >> Christian. >> >>> >>> Best regards >>> Thomas >>> >>>> >>>> /* Generic routines. */ >>>> void agp_generic_enable(struct agp_bridge_data *bridge, u32 mode); >>>> >> > > -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Felix Imendörffer [-- Attachment #1.1.1.2: OpenPGP_0x680DC11D530B7A23.asc --] [-- Type: application/pgp-keys, Size: 7535 bytes --] [-- Attachment #1.2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 840 bytes --] [-- Attachment #2: Type: text/plain, Size: 160 bytes --] _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] char/agp: Disable frontend without CONFIG_DRM_LEGACY 2020-11-18 9:02 ` Thomas Zimmermann @ 2020-11-18 10:51 ` Christian König 0 siblings, 0 replies; 8+ messages in thread From: Christian König @ 2020-11-18 10:51 UTC (permalink / raw) To: Thomas Zimmermann, Daniel Vetter Cc: David Airlie, Daniel Vetter, Alexander Deucher, DRI Development Am 18.11.20 um 10:02 schrieb Thomas Zimmermann: > Hi > > Am 18.11.20 um 09:53 schrieb Daniel Vetter: >> On Wed, Nov 18, 2020 at 9:24 AM Christian König >> <christian.koenig@amd.com> wrote: >>> >>> Am 18.11.20 um 09:02 schrieb Thomas Zimmermann: >>>> Hi >>>> >>>> Am 17.11.20 um 22:40 schrieb Daniel Vetter: >>>>> It's probably full of bugs ready for exploiting by userspace. And >>>>> there's not going to be any userspace for this without any of the drm >>>>> legacy drivers enabled too. So just couple it together. >>>>> >>>>> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> >>>>> Cc: David Airlie <airlied@linux.ie> >>>>> Cc: Adam Jackson <ajax@redhat.com> >>>>> --- >>>>> drivers/char/agp/Makefile | 6 +++++- >>>>> drivers/char/agp/agp.h | 5 +++++ >>>>> 2 files changed, 10 insertions(+), 1 deletion(-) >>>>> >>>>> diff --git a/drivers/char/agp/Makefile b/drivers/char/agp/Makefile >>>>> index cb2497d157f6..90ed8c789e48 100644 >>>>> --- a/drivers/char/agp/Makefile >>>>> +++ b/drivers/char/agp/Makefile >>>>> @@ -1,7 +1,11 @@ >>>>> # SPDX-License-Identifier: GPL-2.0 >>>>> -agpgart-y := backend.o frontend.o generic.o isoch.o >>>>> +agpgart-y := backend.o generic.o isoch.o >>>>> >>>>> +ifeq ($(CONFIG_DRM_LEGACY),y) >>>>> agpgart-$(CONFIG_COMPAT) += compat_ioctl.o >>>>> +agpgart-y += frontend.o >>>>> +endif >>>>> + >>>>> >>>>> obj-$(CONFIG_AGP) += agpgart.o >>>>> obj-$(CONFIG_AGP_ALI) += ali-agp.o >>>>> diff --git a/drivers/char/agp/agp.h b/drivers/char/agp/agp.h >>>>> index 4eb1c772ded7..bb09d64cd51e 100644 >>>>> --- a/drivers/char/agp/agp.h >>>>> +++ b/drivers/char/agp/agp.h >>>>> @@ -186,8 +186,13 @@ int agp_add_bridge(struct agp_bridge_data >>>>> *bridge); >>>>> void agp_remove_bridge(struct agp_bridge_data *bridge); >>>>> >>>>> /* Frontend routines. */ >>>>> +#if IS_ENABLED(CONFIG_DRM_LEGACY) >>>>> int agp_frontend_initialize(void); >>>>> void agp_frontend_cleanup(void); >>>>> +#else >>>>> +static inline int agp_frontend_initialize(void) { return 0; } >>>>> +static inline void agp_frontend_cleanup(void) {} >>>>> +#endif >>>> There's one non-legacy driver that uses these agp structures, which is >>>> radeon. Does this change affect radeon? >>> >>> Nouveau uses AGP as well, but I'm not sure if both drivers use any of >>> this stuff. >> >> frontend = /dev/agp chardev interface for userspace drivers. If you're >> looking at kernel drivers, you're looking at the wrong thing, the >> kernel-internal interface is in char/agp/backend.c and still enabled. >> So no impact at all on any kernel code. >> >> Now the impact this does have on kms drivers using agp is that there's >> no longer a userspace ioctl interface to change the agp setup and >> mappings and fight the kms driver (which assumes it's fully in control >> of agp configuration). I was strongly assuming something like this, thanks for clarifying. > > Thanks for clarifying. I'm certainly not qualified, but still > > Acked-by: Thomas Zimmermann <tzimmermann@suse.de> Acked-by: Christian König <christian.koenig@amd.com> as well. Regards, Christian. > > Best regards > Thomas > >> -Daniel >> >>> >>> Regards, >>> Christian. >>> >>>> >>>> Best regards >>>> Thomas >>>> >>>>> >>>>> /* Generic routines. */ >>>>> void agp_generic_enable(struct agp_bridge_data *bridge, u32 mode); >>>>> >>> >> >> > _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] char/agp: Disable frontend without CONFIG_DRM_LEGACY 2020-11-17 21:40 [PATCH] char/agp: Disable frontend without CONFIG_DRM_LEGACY Daniel Vetter 2020-11-18 8:02 ` Thomas Zimmermann @ 2020-11-18 15:55 ` Adam Jackson 2020-11-18 21:46 ` Daniel Vetter 1 sibling, 1 reply; 8+ messages in thread From: Adam Jackson @ 2020-11-18 15:55 UTC (permalink / raw) To: Daniel Vetter; +Cc: David Airlie, Daniel Vetter, DRI Development On Tue, Nov 17, 2020 at 4:40 PM Daniel Vetter <daniel.vetter@ffwll.ch> wrote: > > It's probably full of bugs ready for exploiting by userspace. And > there's not going to be any userspace for this without any of the drm > legacy drivers enabled too. So just couple it together. Not quite true. The only UMS driver using this is i810, which needs it even with DRI disabled. I have difficulty caring though. In related news, since i810 is only ever attached to 32-bit x86 we could disable the frontend unconditionally on amd64 (and everything else tbh). Acked-by: Adam Jackson <ajax@redhat.com> - ajax _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] char/agp: Disable frontend without CONFIG_DRM_LEGACY 2020-11-18 15:55 ` Adam Jackson @ 2020-11-18 21:46 ` Daniel Vetter 0 siblings, 0 replies; 8+ messages in thread From: Daniel Vetter @ 2020-11-18 21:46 UTC (permalink / raw) To: Adam Jackson; +Cc: David Airlie, Daniel Vetter, DRI Development, Daniel Vetter On Wed, Nov 18, 2020 at 10:55:27AM -0500, Adam Jackson wrote: > On Tue, Nov 17, 2020 at 4:40 PM Daniel Vetter <daniel.vetter@ffwll.ch> wrote: > > > > It's probably full of bugs ready for exploiting by userspace. And > > there's not going to be any userspace for this without any of the drm > > legacy drivers enabled too. So just couple it together. > > Not quite true. The only UMS driver using this is i810, which needs it > even with DRI disabled. I have difficulty caring though. TIL. > In related news, since i810 is only ever attached to 32-bit x86 we > could disable the frontend unconditionally on amd64 (and everything > else tbh). > > Acked-by: Adam Jackson <ajax@redhat.com> Pushed to drm-misc-next, thanks for taking a look. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2020-11-18 21:46 UTC | newest] Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-11-17 21:40 [PATCH] char/agp: Disable frontend without CONFIG_DRM_LEGACY Daniel Vetter 2020-11-18 8:02 ` Thomas Zimmermann 2020-11-18 8:23 ` Christian König 2020-11-18 8:53 ` Daniel Vetter 2020-11-18 9:02 ` Thomas Zimmermann 2020-11-18 10:51 ` Christian König 2020-11-18 15:55 ` Adam Jackson 2020-11-18 21:46 ` Daniel Vetter
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.