Fwd: [linux] drm/i915: Eliminate usage of plane_wm_parameters from ILK-style WM code (v2) (43d59ed)

Fwd: [linux] drm/i915: Eliminate usage of plane_wm_parameters from ILK-style WM code (v2) (43d59ed)

[Daniel Vetter]

[-- Attachment #1.1: Type: text/plain, Size: 967 bytes --]

It's a github comment so pretty hopeless to follow up with the reporter,
but it sounds like we have a culprit for the ilk wm issues/fifo underruns.
-Daniel

---------- Forwarded message ----------
From: Manfred G Kitzbichler <notifications@github.com>
Date: Sat, Jan 30, 2016 at 5:42 AM
Subject: Re: [linux] drm/i915: Eliminate usage of plane_wm_parameters from
ILK-style WM code (v2) (43d59ed)
To: torvalds/linux <linux@noreply.github.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>


As stated above, this commit introduced a screen flicker regression. Please
fix asap!

(cf.
http://cgit.freedesktop.org/drm-intel/commit/?id=54da691deb123c045259ebf4f5c67381244f58f1
)

—
Reply to this email directly or view it on GitHub
<https://github.com/torvalds/linux/commit/43d59eda1f69631c267e06ab6b94ed3c14f1f6d1#commitcomment-15780006>
.



-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

[-- Attachment #1.2: Type: text/html, Size: 1831 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: Fwd: [linux] drm/i915: Eliminate usage of plane_wm_parameters from ILK-style WM code (v2) (43d59ed)

[Jani Nikula]

On Sun, 31 Jan 2016, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> It's a github comment so pretty hopeless to follow up with the reporter,
> but it sounds like we have a culprit for the ilk wm issues/fifo
> underruns.

https://bugs.freedesktop.org/show_bug.cgi?id=93892

BR,
Jani.

> -Daniel
>
> ---------- Forwarded message ----------
> From: Manfred G Kitzbichler <notifications@github.com>
> Date: Sat, Jan 30, 2016 at 5:42 AM
> Subject: Re: [linux] drm/i915: Eliminate usage of plane_wm_parameters from
> ILK-style WM code (v2) (43d59ed)
> To: torvalds/linux <linux@noreply.github.com>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
>
>
> As stated above, this commit introduced a screen flicker regression. Please
> fix asap!
>
> (cf.
> http://cgit.freedesktop.org/drm-intel/commit/?id=54da691deb123c045259ebf4f5c67381244f58f1
> )
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/torvalds/linux/commit/43d59eda1f69631c267e06ab6b94ed3c14f1f6d1#commitcomment-15780006>
> .

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: Fwd: [linux] drm/i915: Eliminate usage of plane_wm_parameters from ILK-style WM code (v2) (43d59ed)

[Matt Roper]

On Sat, Jan 30, 2016 at 07:50:03PM -0800, Daniel Vetter wrote:
> It's a github comment so pretty hopeless to follow up with the reporter,
> but it sounds like we have a culprit for the ilk wm issues/fifo underruns.
> -Daniel

I think this is the flickering regression that we expected to come back
when we reverted the two-step watermarks.  Resurrecting a much earlier
workaround that we lost should help prevent the user-visible problems in
the short term; I just sent a patch for that.

I'm traveling, so I haven't seen any IRC discussion that may have
happened recently, but I believe the CI regression we saw on that final
two-step watermark patch are still unsolved.  But since we've already
reverted that patch, they shouldn't be blocking anything, right?


Matt


> 
> ---------- Forwarded message ----------
> From: Manfred G Kitzbichler <notifications@github.com>
> Date: Sat, Jan 30, 2016 at 5:42 AM
> Subject: Re: [linux] drm/i915: Eliminate usage of plane_wm_parameters from
> ILK-style WM code (v2) (43d59ed)
> To: torvalds/linux <linux@noreply.github.com>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> 
> 
> As stated above, this commit introduced a screen flicker regression. Please
> fix asap!
> 
> (cf.
> http://cgit.freedesktop.org/drm-intel/commit/?id=54da691deb123c045259ebf4f5c67381244f58f1
> )
> 
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/torvalds/linux/commit/43d59eda1f69631c267e06ab6b94ed3c14f1f6d1#commitcomment-15780006>
> .
> 
> 
> 
> -- 
> Daniel Vetter
> Software Engineer, Intel Corporation
> +41 (0) 79 365 57 48 - http://blog.ffwll.ch

-- 
Matt Roper
Graphics Software Engineer
IoTG Platform Enabling & Development
Intel Corporation
(916) 356-2795
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx