From: Daniel Vetter <daniel@ffwll.ch>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: intel-gfx <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 2/6] drm/i915: get mode clock when reading the pipe config v5
Date: Thu, 23 May 2013 20:53:20 +0200 [thread overview]
Message-ID: <CAKMK7uHQMfYZaRVd_4PYZZvtuPaDgoLBddo4aGpXby7ZiivCTw@mail.gmail.com> (raw)
In-Reply-To: <20130523091036.27e75ade@jbarnes-desktop>
On Thu, May 23, 2013 at 6:10 PM, Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
>> - For the clock readout code I think we should be able to have pipe config
>> compare support (with adjusted_mode->clock), with a bit of fuzz at
>> least. Not on current dinq, but with my cleanup to give
>> adjusted_mode->clock saner semantics:
>>
>> http://permalink.gmane.org/gmane.comp.freedesktop.xorg.drivers.intel/21750
>
> So far I haven't needed the fuzz, but I'm not opposed to adding it as
> needed.
I mean for the pipe_config comparison/checking in general, which seems
to still be lacking.
>> - There's no reason imo for the new ->get_clock vfunc, it splits exactly
>> the same as the existing ->get_pipe_config. So could simply be included
>> there.
>
> Except that it depends on the results of the encoder->get_config
> callback... that's the only reason I split it. If you have ideas about
> how to merge it back that's ok with me.
Yeah, I always forget about that. I still think we should shovel
everything into the platform get_config (including the encoder loop)
like we do for the crtc enable/disable functions. But the current
approach still works, so meh ;-)
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2013-05-23 18:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-15 0:08 Fastboot in 6 patches Jesse Barnes
2013-05-15 0:08 ` [PATCH 1/6] drm/i915: add encoder get_config function v5 Jesse Barnes
2013-05-15 21:45 ` Paulo Zanoni
2013-05-21 7:51 ` Daniel Vetter
2013-05-21 7:55 ` Daniel Vetter
2013-05-15 0:08 ` [PATCH 2/6] drm/i915: get mode clock when reading the pipe config v5 Jesse Barnes
2013-05-23 15:30 ` Daniel Vetter
2013-05-23 16:10 ` Jesse Barnes
2013-05-23 18:53 ` Daniel Vetter [this message]
2013-05-15 0:08 ` [PATCH 3/6] drm/i915: copy fetched mode state into crtc at setup_hw time v2 Jesse Barnes
2013-05-15 0:08 ` [PATCH 4/6] drm/i915: fetch PCH PLL state at init time v3 Jesse Barnes
2013-05-15 0:08 ` [PATCH 5/6] HACK: drm/i915: turn off panel fitting at flip time if needed Jesse Barnes
2013-05-15 0:08 ` [PATCH 6/6] drm/i915: flip on a no fb -> fb transition if crtc is active v2 Jesse Barnes
2013-05-23 21:23 ` [PATCH] drm/i915: flip on a no fb -> fb transition if crtc is active v3 Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKMK7uHQMfYZaRVd_4PYZZvtuPaDgoLBddo4aGpXby7ZiivCTw@mail.gmail.com \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jbarnes@virtuousgeek.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.