All of lore.kernel.org
 help / color / mirror / Atom feed
* [REGRESSION BISECTED] backlight control stops workin with 3.14 and later
@ 2014-07-22  6:42 Hans de Goede
  2014-07-22  6:52 ` Daniel Vetter
  0 siblings, 1 reply; 17+ messages in thread
From: Hans de Goede @ 2014-07-22  6:42 UTC (permalink / raw)
  To: jani.nikula; +Cc: intel-gfx, Bertrik Sikken

Hi Jani et al,

A friend of mine Bertrik Sikken (in the Cc) his backlight control
stopped working for him on his Samsung N150Plus netbook.

I took a quick look, and the raw intel_backlight backlight interface
works under 3.14, but the firmware samsung_laptop backlight interface,
which is what most userspace apps will use by default, stops working
in 3.14 .

I've asked him to bisect this and the bisect points out this
commit as the culprit:

b35684b8fa94e04f55fd38bf672b737741d2f9e2 is the first bad commit
commit b35684b8fa94e04f55fd38bf672b737741d2f9e2
Author: Jani Nikula <jani.nikula@intel.com>
Date:   Thu Nov 14 12:13:41 2013 +0200

    drm/i915: do full backlight setup at enable time

    We should now have all the information we need to do a full
    initialization of the backlight registers.

    v2: Keep QUIRK_NO_PCH_PWM_ENABLE for now (Imre).

    Signed-off-by: Jani Nikula <jani.nikula@intel.com>
    Reviewed-by: Imre Deak <imre.deak@intel.com>
    Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>

Note that this laptop has an acpi_video backlight interface too,
but that has been broken from the start and gets disabled by
samsung-laptop based on dmi matching.

Regards,

Hans

^ permalink raw reply	[flat|nested] 17+ messages in thread

end of thread, other threads:[~2014-08-25  7:29 UTC | newest]

Thread overview: 17+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-07-22  6:42 [REGRESSION BISECTED] backlight control stops workin with 3.14 and later Hans de Goede
2014-07-22  6:52 ` Daniel Vetter
2014-07-22  6:59   ` Chris Wilson
2014-07-23  8:46   ` Hans de Goede
2014-07-23 13:15     ` Bertrik Sikken
2014-08-13 13:43     ` Jani Nikula
2014-08-14 19:45       ` Bertrik Sikken
2014-08-15 13:43         ` Jani Nikula
2014-08-17  8:44           ` Bertrik Sikken
2014-08-18  7:37             ` Jani Nikula
2014-08-19  9:52               ` Bertrik Sikken
2014-08-19 13:29                 ` Jani Nikula
2014-08-21 21:44                   ` Bertrik Sikken
2014-08-22  6:48                     ` Jani Nikula
2014-08-22 10:52                       ` Bertrik Sikken
2014-08-23 13:11                       ` Hans de Goede
2014-08-25  7:29                         ` Jani Nikula

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.