* [PATCH v2] tpm: Allow tpm_tis drivers to set hwrng quality.
@ 2018-06-29 8:12 Louis Collard
2018-06-29 8:18 ` Louis Collard
0 siblings, 1 reply; 4+ messages in thread
From: Louis Collard @ 2018-06-29 8:12 UTC (permalink / raw)
To: linux-integrity
Cc: Peter Huewe, Jarkko Sakkinen, Jason Gunthorpe, Arnd Bergmann,
Greg Kroah-Hartman, linux-kernel, apronin
Adds plumbing required for drivers based on tpm_tis to set hwrng quality.
Signed-off-by: Louis Collard <louiscollard@chromium.org>
---
Changes since v1:
- based on (hopefully!) correct git tree
drivers/char/tpm/tpm_tis_core.c | 2 ++
drivers/char/tpm/tpm_tis_core.h | 1 +
2 files changed, 3 insertions(+)
diff --git a/drivers/char/tpm/tpm_tis_core.c b/drivers/char/tpm/tpm_tis_core.c
index 8b46aaa9e049..d2345d9fd7b5 100644
--- a/drivers/char/tpm/tpm_tis_core.c
+++ b/drivers/char/tpm/tpm_tis_core.c
@@ -875,6 +875,8 @@ int tpm_tis_core_init(struct device *dev, struct tpm_tis_data *priv, int irq,
chip->acpi_dev_handle = acpi_dev_handle;
#endif
+ chip->hwrng.quality = priv->rng_quality;
+
/* Maximum timeouts */
chip->timeout_a = msecs_to_jiffies(TIS_TIMEOUT_A_MAX);
chip->timeout_b = msecs_to_jiffies(TIS_TIMEOUT_B_MAX);
diff --git a/drivers/char/tpm/tpm_tis_core.h b/drivers/char/tpm/tpm_tis_core.h
index f6e1dbe212a7..f48125f1e6e0 100644
--- a/drivers/char/tpm/tpm_tis_core.h
+++ b/drivers/char/tpm/tpm_tis_core.h
@@ -99,6 +99,7 @@ struct tpm_tis_data {
wait_queue_head_t int_queue;
wait_queue_head_t read_queue;
const struct tpm_tis_phy_ops *phy_ops;
+ unsigned short rng_quality;
};
struct tpm_tis_phy_ops {
--
2.13.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] tpm: Allow tpm_tis drivers to set hwrng quality.
2018-06-29 8:12 [PATCH v2] tpm: Allow tpm_tis drivers to set hwrng quality Louis Collard
@ 2018-06-29 8:18 ` Louis Collard
0 siblings, 0 replies; 4+ messages in thread
From: Louis Collard @ 2018-06-29 8:18 UTC (permalink / raw)
To: linux-integrity
On Fri, Jun 29, 2018 at 4:12 PM, Louis Collard
<louiscollard@chromium.org> wrote:
> Adds plumbing required for drivers based on tpm_tis to set hwrng quality.
>
> Signed-off-by: Louis Collard <louiscollard@chromium.org>
> ---
> Changes since v1:
> - based on (hopefully!) correct git tree
>
> drivers/char/tpm/tpm_tis_core.c | 2 ++
> drivers/char/tpm/tpm_tis_core.h | 1 +
> 2 files changed, 3 insertions(+)
>
> diff --git a/drivers/char/tpm/tpm_tis_core.c b/drivers/char/tpm/tpm_tis_core.c
> index 8b46aaa9e049..d2345d9fd7b5 100644
> --- a/drivers/char/tpm/tpm_tis_core.c
> +++ b/drivers/char/tpm/tpm_tis_core.c
> @@ -875,6 +875,8 @@ int tpm_tis_core_init(struct device *dev, struct tpm_tis_data *priv, int irq,
> chip->acpi_dev_handle = acpi_dev_handle;
> #endif
>
> + chip->hwrng.quality = priv->rng_quality;
> +
> /* Maximum timeouts */
> chip->timeout_a = msecs_to_jiffies(TIS_TIMEOUT_A_MAX);
> chip->timeout_b = msecs_to_jiffies(TIS_TIMEOUT_B_MAX);
> diff --git a/drivers/char/tpm/tpm_tis_core.h b/drivers/char/tpm/tpm_tis_core.h
> index f6e1dbe212a7..f48125f1e6e0 100644
> --- a/drivers/char/tpm/tpm_tis_core.h
> +++ b/drivers/char/tpm/tpm_tis_core.h
> @@ -99,6 +99,7 @@ struct tpm_tis_data {
> wait_queue_head_t int_queue;
> wait_queue_head_t read_queue;
> const struct tpm_tis_phy_ops *phy_ops;
> + unsigned short rng_quality;
> };
>
> struct tpm_tis_phy_ops {
> --
> 2.13.5
>
So sorry for the double-send (and hope I am not making it worse by
sending this!)
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] tpm: Allow tpm_tis drivers to set hwrng quality.
2018-06-29 8:13 Louis Collard
@ 2018-06-29 11:32 ` Jarkko Sakkinen
0 siblings, 0 replies; 4+ messages in thread
From: Jarkko Sakkinen @ 2018-06-29 11:32 UTC (permalink / raw)
To: Louis Collard
Cc: linux-integrity, Peter Huewe, Jason Gunthorpe, Arnd Bergmann,
Greg Kroah-Hartman, linux-kernel, apronin
On Fri, Jun 29, 2018 at 04:13:55PM +0800, Louis Collard wrote:
> Adds plumbing required for drivers based on tpm_tis to set hwrng quality.
>
> Signed-off-by: Louis Collard <louiscollard@chromium.org>
Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
/Jarkko
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2] tpm: Allow tpm_tis drivers to set hwrng quality.
@ 2018-06-29 8:13 Louis Collard
2018-06-29 11:32 ` Jarkko Sakkinen
0 siblings, 1 reply; 4+ messages in thread
From: Louis Collard @ 2018-06-29 8:13 UTC (permalink / raw)
To: linux-integrity
Cc: Peter Huewe, Jarkko Sakkinen, Jason Gunthorpe, Arnd Bergmann,
Greg Kroah-Hartman, linux-kernel, apronin
Adds plumbing required for drivers based on tpm_tis to set hwrng quality.
Signed-off-by: Louis Collard <louiscollard@chromium.org>
---
Changes since v1:
- based on (hopefully!) correct git tree
drivers/char/tpm/tpm_tis_core.c | 2 ++
drivers/char/tpm/tpm_tis_core.h | 1 +
2 files changed, 3 insertions(+)
diff --git a/drivers/char/tpm/tpm_tis_core.c b/drivers/char/tpm/tpm_tis_core.c
index 8b46aaa9e049..d2345d9fd7b5 100644
--- a/drivers/char/tpm/tpm_tis_core.c
+++ b/drivers/char/tpm/tpm_tis_core.c
@@ -875,6 +875,8 @@ int tpm_tis_core_init(struct device *dev, struct tpm_tis_data *priv, int irq,
chip->acpi_dev_handle = acpi_dev_handle;
#endif
+ chip->hwrng.quality = priv->rng_quality;
+
/* Maximum timeouts */
chip->timeout_a = msecs_to_jiffies(TIS_TIMEOUT_A_MAX);
chip->timeout_b = msecs_to_jiffies(TIS_TIMEOUT_B_MAX);
diff --git a/drivers/char/tpm/tpm_tis_core.h b/drivers/char/tpm/tpm_tis_core.h
index f6e1dbe212a7..f48125f1e6e0 100644
--- a/drivers/char/tpm/tpm_tis_core.h
+++ b/drivers/char/tpm/tpm_tis_core.h
@@ -99,6 +99,7 @@ struct tpm_tis_data {
wait_queue_head_t int_queue;
wait_queue_head_t read_queue;
const struct tpm_tis_phy_ops *phy_ops;
+ unsigned short rng_quality;
};
struct tpm_tis_phy_ops {
--
2.13.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-06-29 11:33 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-29 8:12 [PATCH v2] tpm: Allow tpm_tis drivers to set hwrng quality Louis Collard
2018-06-29 8:18 ` Louis Collard
2018-06-29 8:13 Louis Collard
2018-06-29 11:32 ` Jarkko Sakkinen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.