Re: [PATCH 5/7] xen/arm: Remove __initdata and __init to enable CPU hotplug

[Mirela Simonovic <mirela.simonovic@aggios.com>]

Hi,

On Thu, Apr 12, 2018 at 11:03 AM, Julien Grall <julien.grall@arm.com> wrote:
> Hi,
>
> On 12/04/18 01:07, Stefano Stabellini wrote:
>>
>> On Wed, 11 Apr 2018, Mirela Simonovic wrote:
>>>
>>> diff --git a/xen/arch/arm/smpboot.c b/xen/arch/arm/smpboot.c
>>> index 5666efcd3a..d15ea8df5e 100644
>>> --- a/xen/arch/arm/smpboot.c
>>> +++ b/xen/arch/arm/smpboot.c
>>> @@ -52,8 +52,8 @@ nodemask_t __read_mostly node_online_map = { { [0] =
>>> 1UL } };
>>>   static unsigned char __initdata cpu0_boot_stack[STACK_SIZE]
>>>          __attribute__((__aligned__(STACK_SIZE)));
>>>   -/* Initial boot cpu data */
>>> -struct init_info __initdata init_data =
>>> +/* Boot cpu data */
>>> +struct init_info init_data =
>>>   {
>>>       .stack = cpu0_boot_stack,
>>>   };
>>
>>
>> Don't you also want to remove __initdata from cpu0_boot_stack?
>

Somehow I didn't observe this as a problem... After taking a deeper
look now I understand that secondary CPUs reuse this stack to boot. So
I agree, __initdata from cpu0_boot_stack should be removed.

>
> I am not sure about this. When you go idle, you could re-use the
> idle_vcpu[0]->arch.stack. So you save 12K in resident memory.
>

I'm not sure I follow this, maybe Stefano can comment.

Thanks,
Mirela

> Cheers,
>
> --
> Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel