From: Stefano Stabellini <sstabellini@kernel.org>
To: Mirela Simonovic <mirela.simonovic@aggios.com>
Cc: edgar.iglesias@xilinx.com, sstabellini@kernel.org,
julien.grall@arm.org, dm@aggios.com, xen-devel@lists.xen.org
Subject: Re: [PATCH 5/7] xen/arm: Remove __initdata and __init to enable CPU hotplug
Date: Wed, 11 Apr 2018 17:07:28 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.10.1804111648180.3304@sstabellini-ThinkPad-X260> (raw)
In-Reply-To: <20180411131927.27083-6-mirela.simonovic@aggios.com>
On Wed, 11 Apr 2018, Mirela Simonovic wrote:
> CPU up flow is currently used during the initial boot to start secondary
> CPUs. However, the same flow should be used for CPU hotplug, e.g. when
> hotplugging secondary CPUs within the resume procedure (resume from the
> suspend to RAM). Therefore, prefixes __initdata and __init had to be removed
> from few data structures and functions that are used within the cpu up flow.
>
> Signed-off-by: Mirela Simonovic <mirela.simonovic@aggios.com>
> ---
> xen/arch/arm/arm64/smpboot.c | 2 +-
> xen/arch/arm/irq.c | 2 +-
> xen/arch/arm/processor.c | 2 +-
> xen/arch/arm/smpboot.c | 4 ++--
> xen/include/asm-arm/procinfo.h | 4 ++--
> 5 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/xen/arch/arm/arm64/smpboot.c b/xen/arch/arm/arm64/smpboot.c
> index 4fd0ac68b7..694fbf67e6 100644
> --- a/xen/arch/arm/arm64/smpboot.c
> +++ b/xen/arch/arm/arm64/smpboot.c
> @@ -104,7 +104,7 @@ int __init arch_cpu_init(int cpu, struct dt_device_node *dn)
> return smp_psci_init(cpu);
> }
>
> -int __init arch_cpu_up(int cpu)
> +int arch_cpu_up(int cpu)
> {
> if ( !smp_enable_ops[cpu].prepare_cpu )
> return -ENODEV;
> diff --git a/xen/arch/arm/irq.c b/xen/arch/arm/irq.c
> index aa4e832cae..098281f8ab 100644
> --- a/xen/arch/arm/irq.c
> +++ b/xen/arch/arm/irq.c
> @@ -65,7 +65,7 @@ irq_desc_t *__irq_to_desc(int irq)
> return &irq_desc[irq-NR_LOCAL_IRQS];
> }
>
> -int __init arch_init_one_irq_desc(struct irq_desc *desc)
> +int arch_init_one_irq_desc(struct irq_desc *desc)
> {
> desc->arch.type = IRQ_TYPE_INVALID;
> return 0;
> diff --git a/xen/arch/arm/processor.c b/xen/arch/arm/processor.c
> index ce4385064a..acad8b31d6 100644
> --- a/xen/arch/arm/processor.c
> +++ b/xen/arch/arm/processor.c
> @@ -20,7 +20,7 @@
>
> static DEFINE_PER_CPU(struct processor *, processor);
>
> -void __init processor_setup(void)
> +void processor_setup(void)
> {
> const struct proc_info_list *procinfo;
>
> diff --git a/xen/arch/arm/smpboot.c b/xen/arch/arm/smpboot.c
> index 5666efcd3a..d15ea8df5e 100644
> --- a/xen/arch/arm/smpboot.c
> +++ b/xen/arch/arm/smpboot.c
> @@ -52,8 +52,8 @@ nodemask_t __read_mostly node_online_map = { { [0] = 1UL } };
> static unsigned char __initdata cpu0_boot_stack[STACK_SIZE]
> __attribute__((__aligned__(STACK_SIZE)));
>
> -/* Initial boot cpu data */
> -struct init_info __initdata init_data =
> +/* Boot cpu data */
> +struct init_info init_data =
> {
> .stack = cpu0_boot_stack,
> };
Don't you also want to remove __initdata from cpu0_boot_stack?
> diff --git a/xen/include/asm-arm/procinfo.h b/xen/include/asm-arm/procinfo.h
> index 26306b35f8..02be56e348 100644
> --- a/xen/include/asm-arm/procinfo.h
> +++ b/xen/include/asm-arm/procinfo.h
> @@ -35,9 +35,9 @@ struct proc_info_list {
> struct processor *processor;
> };
>
> -const __init struct proc_info_list *lookup_processor_type(void);
> +const struct proc_info_list *lookup_processor_type(void);
>
> -void __init processor_setup(void);
> +void processor_setup(void);
> void processor_vcpu_initialise(struct vcpu *v);
>
> #endif
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-04-12 0:07 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-11 13:19 [PATCH 0/7] xen/arm: CPU hotplug fixes Mirela Simonovic
2018-04-11 13:19 ` [PATCH 1/7] xen/arm: Added handling of the trapped access to OSLSR register Mirela Simonovic
2018-04-11 14:39 ` Julien Grall
2018-04-11 23:28 ` Stefano Stabellini
2018-04-11 13:19 ` [PATCH 2/7] xen/arm/vgic-v2: Ignore write to GICD_ISACTIVERn registers Mirela Simonovic
2018-04-11 14:43 ` Julien Grall
2018-04-11 23:31 ` Stefano Stabellini
2018-04-12 11:15 ` Mirela Simonovic
2018-04-11 13:19 ` [PATCH 3/7] xen/arm/psci: Implement CPU_OFF PSCI call (physical interface) Mirela Simonovic
2018-04-11 14:46 ` Julien Grall
2018-04-12 11:33 ` Mirela Simonovic
2018-04-12 13:31 ` Julien Grall
2018-04-16 10:02 ` Mirela Simonovic
2018-04-16 14:26 ` Julien Grall
2018-04-16 16:52 ` Mirela Simonovic
2018-04-16 17:02 ` Julien Grall
2018-04-11 13:19 ` [PATCH 4/7] xen/arm: When CPU dies, free percpu area immediatelly Mirela Simonovic
2018-04-11 14:53 ` Julien Grall
2018-04-11 23:46 ` Stefano Stabellini
2018-04-12 8:53 ` Julien Grall
2018-04-12 21:31 ` Stefano Stabellini
2018-04-16 13:14 ` Julien Grall
2018-04-16 13:41 ` Mirela Simonovic
2018-04-16 15:21 ` Julien Grall
2018-04-17 10:52 ` Mirela Simonovic
2018-04-17 11:02 ` Julien Grall
2018-04-18 22:52 ` Stefano Stabellini
2018-04-19 9:32 ` Julien Grall
2018-04-11 13:19 ` [PATCH 5/7] xen/arm: Remove __initdata and __init to enable CPU hotplug Mirela Simonovic
2018-04-12 0:07 ` Stefano Stabellini [this message]
2018-04-12 9:03 ` Julien Grall
2018-04-12 12:50 ` Mirela Simonovic
2018-04-12 12:56 ` Julien Grall
2018-04-12 13:55 ` Mirela Simonovic
2018-04-11 13:19 ` [PATCH 6/7] xen/arm: Setup virtual paging for secondary CPUs in non-boot scenario Mirela Simonovic
2018-04-11 15:11 ` Julien Grall
2018-04-17 12:54 ` Mirela Simonovic
2018-04-17 14:11 ` Julien Grall
2018-04-17 15:22 ` Mirela Simonovic
2018-04-18 9:48 ` Julien Grall
2018-04-18 10:34 ` Mirela Simonovic
2018-04-18 10:45 ` Mirela Simonovic
2018-04-18 10:58 ` Julien Grall
2018-04-18 22:56 ` Stefano Stabellini
2018-04-11 13:19 ` [PATCH 7/7] xen/arm: Restore IRQ affinity after hotplugging a CPU Mirela Simonovic
2018-04-11 14:55 ` Julien Grall
2018-04-12 0:20 ` Stefano Stabellini
2018-04-12 7:38 ` Mirela Simonovic
2018-04-12 16:49 ` Dario Faggioli
2018-04-13 10:11 ` Mirela Simonovic
2018-04-16 12:38 ` Dario Faggioli
2018-04-11 15:07 ` [PATCH 0/7] xen/arm: CPU hotplug fixes Julien Grall
2018-04-11 15:58 ` Mirela Simonovic
2018-04-11 16:02 ` Julien Grall
2018-04-11 16:37 ` Mirela Simonovic
2018-04-12 8:43 ` Julien Grall
2018-04-13 10:19 ` Mirela Simonovic
2018-04-16 11:33 ` Julien Grall
2018-04-16 14:06 ` Mirela Simonovic
2018-04-16 15:05 ` Julien Grall
2018-04-11 15:13 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.10.1804111648180.3304@sstabellini-ThinkPad-X260 \
--to=sstabellini@kernel.org \
--cc=dm@aggios.com \
--cc=edgar.iglesias@xilinx.com \
--cc=julien.grall@arm.org \
--cc=mirela.simonovic@aggios.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.