[PATCH] atmodem/sms: added Gemalto vendor for CNMI command

[PATCH] atmodem/sms: added Gemalto vendor for CNMI command

[Giacinto Cifelli]

[-- Attachment #1: Type: text/plain, Size: 821 bytes --]

---
 drivers/atmodem/sms.c | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/drivers/atmodem/sms.c b/drivers/atmodem/sms.c
index 7638885e..380cd763 100644
--- a/drivers/atmodem/sms.c
+++ b/drivers/atmodem/sms.c
@@ -858,8 +858,18 @@ static gboolean build_cnmi_string(char *buf, int *cnmi_opts,
 					data->cnma_enabled ? "21" : "1", FALSE))
 		return FALSE;
 
+	switch (data->vendor) {
+	case OFONO_VENDOR_GEMALTO:
+		mode = "0";
+		break;
+	default:
+		/* Sounds like 2 is the sanest mode */
+		mode = "20";
+		break;
+	}
+
 	/* Always deliver CB via +CBM, otherwise don't deliver at all */
-	if (!append_cnmi_element(buf, &len, cnmi_opts[2], "20", FALSE))
+	if (!append_cnmi_element(buf, &len, cnmi_opts[2], mode, FALSE))
 		return FALSE;
 
 	/*
-- 
2.17.1

Re: [PATCH] atmodem/sms: added Gemalto vendor for CNMI command

[Jonas Bonn]

[-- Attachment #1: Type: text/plain, Size: 1012 bytes --]

Hi,

On 23/10/18 10:21, Giacinto Cifelli wrote:
> ---
>   drivers/atmodem/sms.c | 12 +++++++++++-
>   1 file changed, 11 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/atmodem/sms.c b/drivers/atmodem/sms.c
> index 7638885e..380cd763 100644
> --- a/drivers/atmodem/sms.c
> +++ b/drivers/atmodem/sms.c
> @@ -858,8 +858,18 @@ static gboolean build_cnmi_string(char *buf, int *cnmi_opts,
>   					data->cnma_enabled ? "21" : "1", FALSE))
>   		return FALSE;
>   
> +	switch (data->vendor) {
> +	case OFONO_VENDOR_GEMALTO:
> +		mode = "0";
> +		break;
> +	default:
> +		/* Sounds like 2 is the sanest mode */

This particular comment doesn't add anything useful so just drop it.

/Jonas


> +		mode = "20";
> +		break;
> +	}
> +
>   	/* Always deliver CB via +CBM, otherwise don't deliver at all */
> -	if (!append_cnmi_element(buf, &len, cnmi_opts[2], "20", FALSE))
> +	if (!append_cnmi_element(buf, &len, cnmi_opts[2], mode, FALSE))
>   		return FALSE;
>   
>   	/*
> 

Re: [PATCH] atmodem/sms: added Gemalto vendor for CNMI command

[Giacinto Cifelli]

[-- Attachment #1: Type: text/plain, Size: 1173 bytes --]

Hi,

On Tue, Oct 23, 2018 at 10:29 AM Jonas Bonn <jonas@norrbonn.se> wrote:
>
> Hi,
>
> On 23/10/18 10:21, Giacinto Cifelli wrote:
> > ---
> >   drivers/atmodem/sms.c | 12 +++++++++++-
> >   1 file changed, 11 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/atmodem/sms.c b/drivers/atmodem/sms.c
> > index 7638885e..380cd763 100644
> > --- a/drivers/atmodem/sms.c
> > +++ b/drivers/atmodem/sms.c
> > @@ -858,8 +858,18 @@ static gboolean build_cnmi_string(char *buf, int *cnmi_opts,
> >                                       data->cnma_enabled ? "21" : "1", FALSE))
> >               return FALSE;
> >
> > +     switch (data->vendor) {
> > +     case OFONO_VENDOR_GEMALTO:
> > +             mode = "0";
> > +             break;
> > +     default:
> > +             /* Sounds like 2 is the sanest mode */
>
> This particular comment doesn't add anything useful so just drop it.

Not mine... I didn't want my patch rejected because I changed 2 things
at the same time (add vendor and remove comment).
From the choice of word (sane), I think this comment is from Denis.
without even checking with git blame.

>
> /Jonas

Giacinto

Re: [PATCH] atmodem/sms: added Gemalto vendor for CNMI command

[Jonas Bonn]

[-- Attachment #1: Type: text/plain, Size: 572 bytes --]



On 23/10/18 10:32, Giacinto Cifelli wrote:
> Hi,
> 
> On Tue, Oct 23, 2018 at 10:29 AM Jonas Bonn <jonas@norrbonn.se> wrote:
> +             break;
>>> +     default:
>>> +             /* Sounds like 2 is the sanest mode */
>>
>> This particular comment doesn't add anything useful so just drop it.
> 
> Not mine... I didn't want my patch rejected because I changed 2 things
> at the same time (add vendor and remove comment).
>  From the choice of word (sane), I think this comment is from Denis.
> without even checking with git blame.

:)

/Jonas

Re: [PATCH] atmodem/sms: added Gemalto vendor for CNMI command

[Denis Kenzior]

[-- Attachment #1: Type: text/plain, Size: 216 bytes --]

Hi Giacinto,

On 10/23/2018 03:21 AM, Giacinto Cifelli wrote:
> ---
>   drivers/atmodem/sms.c | 12 +++++++++++-
>   1 file changed, 11 insertions(+), 1 deletion(-)
> 

Applied, thanks.

Regards,
-denis