Re: [PATCH] src/modem: connection timeout to 60 seconds

[Giacinto Cifelli <gciofono@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1750 bytes --]

Hi,

On Tue, Oct 23, 2018 at 10:34 AM Jonas Bonn <jonas@norrbonn.se> wrote:
>
> Hi,
>
> Do the USB interfaces show up long before the modem is ready to accept
> AT commands?  Or do the AT commands take a long time to complete?

The USB shows up long before the modem is ready to accept AT commands,
and - if supported - the MBIM OPEN takes a long time to complete.

>
> /Jonas

Giacinto

>
> On 23/10/18 09:50, Giacinto Cifelli wrote:
> > Changed the connection timeout to 60 seconds (from 20 seconds),
> > to accomodate for chipset that take time to boot-up.
> > ---
> >   src/modem.c | 4 ++--
> >   1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/src/modem.c b/src/modem.c
> > index 124a5192..e7978bb0 100644
> > --- a/src/modem.c
> > +++ b/src/modem.c
> > @@ -1060,7 +1060,7 @@ static DBusMessage *set_property_lockdown(struct ofono_modem *modem,
> >               }
> >
> >               modem->pending = dbus_message_ref(msg);
> > -             modem->timeout = g_timeout_add_seconds(20,
> > +             modem->timeout = g_timeout_add_seconds(60,
> >                                               set_powered_timeout, modem);
> >               return NULL;
> >       }
> > @@ -1138,7 +1138,7 @@ static DBusMessage *modem_set_property(DBusConnection *conn,
> >                               return __ofono_error_failed(msg);
> >
> >                       modem->pending = dbus_message_ref(msg);
> > -                     modem->timeout = g_timeout_add_seconds(20,
> > +                     modem->timeout = g_timeout_add_seconds(60,
> >                                               set_powered_timeout, modem);
> >                       return NULL;
> >               }
> >