All of lore.kernel.org
 help / color / mirror / Atom feed
From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH] src/modem.c/call_watches null pointer check
Date: Tue, 23 Oct 2018 11:50:35 -0500	[thread overview]
Message-ID: <cc405107-2207-928a-2e48-1e472b7be45b@gmail.com> (raw)
In-Reply-To: <CAKSBH7FY_BApefBvEUPJmAkt_baigp8QdiKXuJE8iaZa_vgJSw@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 2018 bytes --]

Hi Giacinto,
>     0  0x0000563b1842b735 in call_watches
> (atom=atom(a)entry=0x563b1a3f07d0,
> cond=cond(a)entry=OFONO_ATOM_WATCH_CONDITION_UNREGISTERED) at
> src/modem.c:265
>     1  0x0000563b1842c32e in __ofono_atom_unregister
> (atom=atom(a)entry=0x563b1a3f07d0) at src/modem.c:299
>     2  0x0000563b1842c3ff in __ofono_atom_unregister
> (atom=0x563b1a3f07d0) at src/modem.c:296
>     3  flush_atoms (modem=0x563b1a3f1f50,
> new_state=MODEM_STATE_POWER_OFF) at src/modem.c:448
>     4  modem_change_state (modem=0x563b1a3f1f50,
> new_state=MODEM_STATE_POWER_OFF) at src/modem.c:529
>     5  0x0000563b1842c577 in set_powered
> (modem=modem(a)entry=0x563b1a3f1f50, powered=powered(a)entry=0) at
> src/modem.c:915
>     6  0x0000563b1842c863 in modem_unregister
> (modem=modem(a)entry=0x563b1a3f1f50) at src/modem.c:2111
>     7  0x0000563b1842e6a4 in ofono_modem_remove (modem=0x563b1a3f1f50)
> at src/modem.c:2177
>     8  0x0000563b183b05d3 in destroy_modem (data=0x563b1a3e50a0) at
> plugins/udevng.c:1408
>     9  0x00007f42b4bdd091 in ?? () from
> /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0
>     10 0x0000563b183b561a in remove_device (device=0x563b1a401630) at
> plugins/udevng.c:1468
>     11 udev_event (channel=<optimized out>, cond=<optimized out>,
> user_data=<optimized out>) at plugins/udevng.c:1991
>     12 0x00007f42b4bef0f5 in g_main_context_dispatch () from
> /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0
>     13 0x00007f42b4bef4c0 in ?? () from
> /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0
>     14 0x00007f42b4bef7d2 in g_main_loop_run () from
> /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0
>     15 0x0000563b183b0397 in main (argc=<optimized out>,
> argv=<optimized out>) at src/main.c:294
> 
> ?

Yes, much better.  So now you can explain to me how you're triggering this.

The only way modem->atom_watches is NULL is if ofono_modem_register 
failed.  So are you trying to use a modem object without registering it 
properly?

Regards,
-Denis


  reply	other threads:[~2018-10-23 16:50 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-23  7:50 [PATCH] src/modem.c/call_watches null pointer check Giacinto Cifelli
2018-10-23  7:50 ` [PATCH] src/modem: connection timeout to 60 seconds Giacinto Cifelli
2018-10-23  8:34   ` Jonas Bonn
2018-10-23  8:40     ` Giacinto Cifelli
2018-10-23  8:53       ` Jonas Bonn
2018-10-23  9:26         ` Giacinto Cifelli
2018-10-23 10:45           ` Jonas Bonn
2018-10-23 15:08       ` Denis Kenzior
2018-10-23 18:34         ` Giacinto Cifelli
2018-10-23 10:35   ` Slava Monich
2018-10-23 14:30 ` [PATCH] src/modem.c/call_watches null pointer check Denis Kenzior
2018-10-23 14:44   ` Giacinto Cifelli
2018-10-23 14:47     ` Denis Kenzior
2018-10-23 16:39       ` Giacinto Cifelli
2018-10-23 16:50         ` Denis Kenzior [this message]
2018-10-23 17:30           ` Giacinto Cifelli
2018-10-23 17:40             ` Denis Kenzior
2018-10-23 17:51               ` Giacinto Cifelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cc405107-2207-928a-2e48-1e472b7be45b@gmail.com \
    --to=denkenz@gmail.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.