Re: [linux-next:master 5640/13335] arch/riscv/net/bpf_jit_comp64.c:1094:47: error: 'BPF_JIT_REGION_START' undeclared

Re: [linux-next:master 5640/13335] arch/riscv/net/bpf_jit_comp64.c:1094:47: error: 'BPF_JIT_REGION_START' undeclared

[Xi Wang]

[-- Attachment #1: Type: text/plain, Size: 419 bytes --]

On Tue, Mar 31, 2020 at 2:49 AM Björn Töpel <bjorn.topel@gmail.com> wrote:
> I'm taking a look right now! Thanks for the ping!

It's likely caused by commit 2191b4f298fa36 ("RISC-V: Move all address
space definition macros to one place").  BPF_JIT_REGION_START etc. are
moved under CONFIG_MMU, which is not set in the attached .config.

Maybe avoid using bpf_jit_alloc_exec and bpf_jit_free_exec in nommu mode?

Re: [linux-next:master 5640/13335] arch/riscv/net/bpf_jit_comp64.c:1094:47: error: 'BPF_JIT_REGION_START' undeclared

[Xi Wang]

[-- Attachment #1: Type: text/plain, Size: 593 bytes --]

On Tue, Mar 31, 2020 at 8:49 AM Xi Wang <xi.wang@gmail.com> wrote:
>
> On Tue, Mar 31, 2020 at 2:49 AM Björn Töpel <bjorn.topel@gmail.com> wrote:
> > I'm taking a look right now! Thanks for the ping!
>
> It's likely caused by commit 2191b4f298fa36 ("RISC-V: Move all address
> space definition macros to one place").  BPF_JIT_REGION_START etc. are
> moved under CONFIG_MMU, which is not set in the attached .config.
>
> Maybe avoid using bpf_jit_alloc_exec and bpf_jit_free_exec in nommu mode?

Never mind.  Missed your patch in the other thread.  Thanks for taking
care of this!

Re: [linux-next:master 5640/13335] arch/riscv/net/bpf_jit_comp64.c:1094:47: error: 'BPF_JIT_REGION_START' undeclared

[Daniel Borkmann]

[-- Attachment #1: Type: text/plain, Size: 3305 bytes --]

On 3/31/20 11:35 AM, kbuild test robot wrote:
> Hi Luke,
> 
> First bad commit (maybe != root cause):
> 
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head:   3eb7cccdb3ae41ebb6a2f5f1ccd2821550c61fe1
> commit: ca6cb5447ceca6a87d6b62c9e5d41042c34f7ffa [5640/13335] riscv, bpf: Factor common RISC-V JIT code
> config: riscv-randconfig-a001-20200331 (attached as .config)
> compiler: riscv64-linux-gcc (GCC) 9.3.0
> reproduce:
>          wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>          chmod +x ~/bin/make.cross
>          git checkout ca6cb5447ceca6a87d6b62c9e5d41042c34f7ffa
>          # save the attached .config to linux build tree
>          GCC_VERSION=9.3.0 make.cross ARCH=riscv

Luke or Bjorn, please take a look for fixing, thanks.

> If you fix the issue, kindly add following tag
> Reported-by: kbuild test robot <lkp@intel.com>
> 
> All errors (new ones prefixed by >>):
> 
>     arch/riscv/net/bpf_jit_comp64.c: In function 'bpf_jit_alloc_exec':
>>> arch/riscv/net/bpf_jit_comp64.c:1094:47: error: 'BPF_JIT_REGION_START' undeclared (first use in this function)
>      1094 |  return __vmalloc_node_range(size, PAGE_SIZE, BPF_JIT_REGION_START,
>           |                                               ^~~~~~~~~~~~~~~~~~~~
>     arch/riscv/net/bpf_jit_comp64.c:1094:47: note: each undeclared identifier is reported only once for each function it appears in
>>> arch/riscv/net/bpf_jit_comp64.c:1095:9: error: 'BPF_JIT_REGION_END' undeclared (first use in this function)
>      1095 |         BPF_JIT_REGION_END, GFP_KERNEL,
>           |         ^~~~~~~~~~~~~~~~~~
>     arch/riscv/net/bpf_jit_comp64.c:1098:1: warning: control reaches end of non-void function [-Wreturn-type]
>      1098 | }
>           | ^
> 
> vim +/BPF_JIT_REGION_START +1094 arch/riscv/net/bpf_jit_comp64.c
> 
> 2353ecc6f91fd1 arch/riscv/net/bpf_jit_comp.c Björn Töpel 2019-02-05  1091
> 7f3631e88ee6fb arch/riscv/net/bpf_jit_comp.c Björn Töpel 2019-12-16  1092  void *bpf_jit_alloc_exec(unsigned long size)
> 7f3631e88ee6fb arch/riscv/net/bpf_jit_comp.c Björn Töpel 2019-12-16  1093  {
> 7f3631e88ee6fb arch/riscv/net/bpf_jit_comp.c Björn Töpel 2019-12-16 @1094  	return __vmalloc_node_range(size, PAGE_SIZE, BPF_JIT_REGION_START,
> 7f3631e88ee6fb arch/riscv/net/bpf_jit_comp.c Björn Töpel 2019-12-16 @1095  				    BPF_JIT_REGION_END, GFP_KERNEL,
> 7f3631e88ee6fb arch/riscv/net/bpf_jit_comp.c Björn Töpel 2019-12-16  1096  				    PAGE_KERNEL_EXEC, 0, NUMA_NO_NODE,
> 7f3631e88ee6fb arch/riscv/net/bpf_jit_comp.c Björn Töpel 2019-12-16  1097  				    __builtin_return_address(0));
> 7f3631e88ee6fb arch/riscv/net/bpf_jit_comp.c Björn Töpel 2019-12-16  1098  }
> 7f3631e88ee6fb arch/riscv/net/bpf_jit_comp.c Björn Töpel 2019-12-16  1099
> 
> :::::: The code at line 1094 was first introduced by commit
> :::::: 7f3631e88ee6fb13beac333a0e9e605d2414d17f riscv, bpf: Provide RISC-V specific JIT image alloc/free
> 
> :::::: TO: Björn Töpel <bjorn.topel@gmail.com>
> :::::: CC: Daniel Borkmann <daniel@iogearbox.net>
> 
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
> 

[linux-next:master 5640/13335] arch/riscv/net/bpf_jit_comp64.c:1094:47: error: 'BPF_JIT_REGION_START' undeclared

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 3084 bytes --]

Hi Luke,

First bad commit (maybe != root cause):

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   3eb7cccdb3ae41ebb6a2f5f1ccd2821550c61fe1
commit: ca6cb5447ceca6a87d6b62c9e5d41042c34f7ffa [5640/13335] riscv, bpf: Factor common RISC-V JIT code
config: riscv-randconfig-a001-20200331 (attached as .config)
compiler: riscv64-linux-gcc (GCC) 9.3.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git checkout ca6cb5447ceca6a87d6b62c9e5d41042c34f7ffa
        # save the attached .config to linux build tree
        GCC_VERSION=9.3.0 make.cross ARCH=riscv 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   arch/riscv/net/bpf_jit_comp64.c: In function 'bpf_jit_alloc_exec':
>> arch/riscv/net/bpf_jit_comp64.c:1094:47: error: 'BPF_JIT_REGION_START' undeclared (first use in this function)
    1094 |  return __vmalloc_node_range(size, PAGE_SIZE, BPF_JIT_REGION_START,
         |                                               ^~~~~~~~~~~~~~~~~~~~
   arch/riscv/net/bpf_jit_comp64.c:1094:47: note: each undeclared identifier is reported only once for each function it appears in
>> arch/riscv/net/bpf_jit_comp64.c:1095:9: error: 'BPF_JIT_REGION_END' undeclared (first use in this function)
    1095 |         BPF_JIT_REGION_END, GFP_KERNEL,
         |         ^~~~~~~~~~~~~~~~~~
   arch/riscv/net/bpf_jit_comp64.c:1098:1: warning: control reaches end of non-void function [-Wreturn-type]
    1098 | }
         | ^

vim +/BPF_JIT_REGION_START +1094 arch/riscv/net/bpf_jit_comp64.c

2353ecc6f91fd1 arch/riscv/net/bpf_jit_comp.c Björn Töpel 2019-02-05  1091  
7f3631e88ee6fb arch/riscv/net/bpf_jit_comp.c Björn Töpel 2019-12-16  1092  void *bpf_jit_alloc_exec(unsigned long size)
7f3631e88ee6fb arch/riscv/net/bpf_jit_comp.c Björn Töpel 2019-12-16  1093  {
7f3631e88ee6fb arch/riscv/net/bpf_jit_comp.c Björn Töpel 2019-12-16 @1094  	return __vmalloc_node_range(size, PAGE_SIZE, BPF_JIT_REGION_START,
7f3631e88ee6fb arch/riscv/net/bpf_jit_comp.c Björn Töpel 2019-12-16 @1095  				    BPF_JIT_REGION_END, GFP_KERNEL,
7f3631e88ee6fb arch/riscv/net/bpf_jit_comp.c Björn Töpel 2019-12-16  1096  				    PAGE_KERNEL_EXEC, 0, NUMA_NO_NODE,
7f3631e88ee6fb arch/riscv/net/bpf_jit_comp.c Björn Töpel 2019-12-16  1097  				    __builtin_return_address(0));
7f3631e88ee6fb arch/riscv/net/bpf_jit_comp.c Björn Töpel 2019-12-16  1098  }
7f3631e88ee6fb arch/riscv/net/bpf_jit_comp.c Björn Töpel 2019-12-16  1099  

:::::: The code at line 1094 was first introduced by commit
:::::: 7f3631e88ee6fb13beac333a0e9e605d2414d17f riscv, bpf: Provide RISC-V specific JIT image alloc/free

:::::: TO: Björn Töpel <bjorn.topel@gmail.com>
:::::: CC: Daniel Borkmann <daniel@iogearbox.net>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 29464 bytes --]