* [PATCH] rockchip: ram: sdram_rk3x88: replace comma by semicolon
@ 2022-01-12 16:32 Johan Jonker
2022-01-12 20:03 ` Simon Glass
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Johan Jonker @ 2022-01-12 16:32 UTC (permalink / raw)
To: kever.yang; +Cc: sjg, philipp.tomsich, u-boot
A comma at the end of a line gives sometimes strange
effects in combination with some code formatters,
so replace a comma by a semicolon in the sdram_rk3188.c
and sdram_rk3288.c files.
Signed-off-by: Johan Jonker <jbx6244@gmail.com>
---
drivers/ram/rockchip/sdram_rk3188.c | 2 +-
drivers/ram/rockchip/sdram_rk3288.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/ram/rockchip/sdram_rk3188.c b/drivers/ram/rockchip/sdram_rk3188.c
index d9ed8adf..be8ba446 100644
--- a/drivers/ram/rockchip/sdram_rk3188.c
+++ b/drivers/ram/rockchip/sdram_rk3188.c
@@ -762,7 +762,7 @@ static int sdram_init(struct dram_info *dram,
* CS1, n=2
* CS0 & CS1, n = 3
*/
- sdram_params->ch[channel].rank = 2,
+ sdram_params->ch[channel].rank = 2;
clrsetbits_le32(&publ->pgcr, 0xF << 18,
(sdram_params->ch[channel].rank | 1) << 18);
diff --git a/drivers/ram/rockchip/sdram_rk3288.c b/drivers/ram/rockchip/sdram_rk3288.c
index f3e4a280..227a3cc6 100644
--- a/drivers/ram/rockchip/sdram_rk3288.c
+++ b/drivers/ram/rockchip/sdram_rk3288.c
@@ -862,7 +862,7 @@ static int sdram_init(struct dram_info *dram,
* CS1, n=2
* CS0 & CS1, n = 3
*/
- sdram_params->ch[channel].rank = 2,
+ sdram_params->ch[channel].rank = 2;
clrsetbits_le32(&publ->pgcr, 0xF << 18,
(sdram_params->ch[channel].rank | 1) << 18);
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] rockchip: ram: sdram_rk3x88: replace comma by semicolon
2022-01-12 16:32 [PATCH] rockchip: ram: sdram_rk3x88: replace comma by semicolon Johan Jonker
@ 2022-01-12 20:03 ` Simon Glass
2022-03-12 9:05 ` Jagan Teki
2022-03-14 7:45 ` Kever Yang
2 siblings, 0 replies; 4+ messages in thread
From: Simon Glass @ 2022-01-12 20:03 UTC (permalink / raw)
To: Johan Jonker; +Cc: Kever Yang, Philipp Tomsich, U-Boot Mailing List
On Wed, 12 Jan 2022 at 09:32, Johan Jonker <jbx6244@gmail.com> wrote:
>
> A comma at the end of a line gives sometimes strange
> effects in combination with some code formatters,
> so replace a comma by a semicolon in the sdram_rk3188.c
> and sdram_rk3288.c files.
>
> Signed-off-by: Johan Jonker <jbx6244@gmail.com>
> ---
> drivers/ram/rockchip/sdram_rk3188.c | 2 +-
> drivers/ram/rockchip/sdram_rk3288.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
Reviewed-by: Simon Glass <sjg@chromium.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] rockchip: ram: sdram_rk3x88: replace comma by semicolon
2022-01-12 16:32 [PATCH] rockchip: ram: sdram_rk3x88: replace comma by semicolon Johan Jonker
2022-01-12 20:03 ` Simon Glass
@ 2022-03-12 9:05 ` Jagan Teki
2022-03-14 7:45 ` Kever Yang
2 siblings, 0 replies; 4+ messages in thread
From: Jagan Teki @ 2022-03-12 9:05 UTC (permalink / raw)
To: Johan Jonker; +Cc: kever.yang, sjg, philipp.tomsich, u-boot
On Wed, Jan 12, 2022 at 10:02 PM Johan Jonker <jbx6244@gmail.com> wrote:
>
> A comma at the end of a line gives sometimes strange
> effects in combination with some code formatters,
> so replace a comma by a semicolon in the sdram_rk3188.c
> and sdram_rk3288.c files.
>
> Signed-off-by: Johan Jonker <jbx6244@gmail.com>
> ---
Reviewed-by: Jagan Teki <jagan@amarulasolutions.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] rockchip: ram: sdram_rk3x88: replace comma by semicolon
2022-01-12 16:32 [PATCH] rockchip: ram: sdram_rk3x88: replace comma by semicolon Johan Jonker
2022-01-12 20:03 ` Simon Glass
2022-03-12 9:05 ` Jagan Teki
@ 2022-03-14 7:45 ` Kever Yang
2 siblings, 0 replies; 4+ messages in thread
From: Kever Yang @ 2022-03-14 7:45 UTC (permalink / raw)
To: Johan Jonker; +Cc: Kever Yang, Simon Glass, Philipp Tomsich, U-Boot-Denx
Hi Johan,
Johan Jonker <jbx6244@gmail.com> 于2022年1月13日周四 00:32写道：
>
> A comma at the end of a line gives sometimes strange
> effects in combination with some code formatters,
> so replace a comma by a semicolon in the sdram_rk3188.c
> and sdram_rk3288.c files.
>
> Signed-off-by: Johan Jonker <jbx6244@gmail.com>
Reviewed-by: Kever Yang <kever.yang@rock-chips.com>
Thanks,
- Kever
> ---
> drivers/ram/rockchip/sdram_rk3188.c | 2 +-
> drivers/ram/rockchip/sdram_rk3288.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/ram/rockchip/sdram_rk3188.c b/drivers/ram/rockchip/sdram_rk3188.c
> index d9ed8adf..be8ba446 100644
> --- a/drivers/ram/rockchip/sdram_rk3188.c
> +++ b/drivers/ram/rockchip/sdram_rk3188.c
> @@ -762,7 +762,7 @@ static int sdram_init(struct dram_info *dram,
> * CS1, n=2
> * CS0 & CS1, n = 3
> */
> - sdram_params->ch[channel].rank = 2,
> + sdram_params->ch[channel].rank = 2;
> clrsetbits_le32(&publ->pgcr, 0xF << 18,
> (sdram_params->ch[channel].rank | 1) << 18);
>
> diff --git a/drivers/ram/rockchip/sdram_rk3288.c b/drivers/ram/rockchip/sdram_rk3288.c
> index f3e4a280..227a3cc6 100644
> --- a/drivers/ram/rockchip/sdram_rk3288.c
> +++ b/drivers/ram/rockchip/sdram_rk3288.c
> @@ -862,7 +862,7 @@ static int sdram_init(struct dram_info *dram,
> * CS1, n=2
> * CS0 & CS1, n = 3
> */
> - sdram_params->ch[channel].rank = 2,
> + sdram_params->ch[channel].rank = 2;
> clrsetbits_le32(&publ->pgcr, 0xF << 18,
> (sdram_params->ch[channel].rank | 1) << 18);
>
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-03-14 7:46 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-12 16:32 [PATCH] rockchip: ram: sdram_rk3x88: replace comma by semicolon Johan Jonker
2022-01-12 20:03 ` Simon Glass
2022-03-12 9:05 ` Jagan Teki
2022-03-14 7:45 ` Kever Yang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.