[PATCH] drivers/adc/rockchip-saradc: remove double semi-colon

[PATCH] drivers/adc/rockchip-saradc: remove double semi-colon

[Giulio Benetti]

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
 drivers/adc/rockchip-saradc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/adc/rockchip-saradc.c b/drivers/adc/rockchip-saradc.c
index e464d33f22..e0cbab6aa0 100644
--- a/drivers/adc/rockchip-saradc.c
+++ b/drivers/adc/rockchip-saradc.c
@@ -131,7 +131,7 @@ int rockchip_saradc_of_to_plat(struct udevice *dev)
 	}
 
 	priv->data = data;
-	uc_pdata->data_mask = (1 << priv->data->num_bits) - 1;;
+	uc_pdata->data_mask = (1 << priv->data->num_bits) - 1;
 	uc_pdata->data_format = ADC_DATA_FORMAT_BIN;
 	uc_pdata->data_timeout_us = SARADC_TIMEOUT / 5;
 	uc_pdata->channel_mask = (1 << priv->data->num_channels) - 1;
-- 
2.25.1

Re: [PATCH] drivers/adc/rockchip-saradc: remove double semi-colon

[Kever Yang]

Hi Giulio,

    Thanks for your patch, it's a good catching.
    Could you please update the subject with "rockchip: adc: ", and
add a simple description in the commit message? Empy commit message is
not allowed according to U-Boot patch commit rules :(

Thanks,
- Kever

Giulio Benetti <giulio.benetti@benettiengineering.com> 于2022年2月4日周五 09:19写道：
>
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
>  drivers/adc/rockchip-saradc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/adc/rockchip-saradc.c b/drivers/adc/rockchip-saradc.c
> index e464d33f22..e0cbab6aa0 100644
> --- a/drivers/adc/rockchip-saradc.c
> +++ b/drivers/adc/rockchip-saradc.c
> @@ -131,7 +131,7 @@ int rockchip_saradc_of_to_plat(struct udevice *dev)
>         }
>
>         priv->data = data;
> -       uc_pdata->data_mask = (1 << priv->data->num_bits) - 1;;
> +       uc_pdata->data_mask = (1 << priv->data->num_bits) - 1;
>         uc_pdata->data_format = ADC_DATA_FORMAT_BIN;
>         uc_pdata->data_timeout_us = SARADC_TIMEOUT / 5;
>         uc_pdata->channel_mask = (1 << priv->data->num_channels) - 1;
> --
> 2.25.1
>

[PATCH v2] rockchip: saradc: remove double semi-colon

[Giulio Benetti]

Remove double semi-colon that has been forgotten while adding the
driver. This is only a style fix since it doesn't change the
functionality of the driver.

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
V1->V2:
* Improved commit log as suggested by Kever Yang
---
 drivers/adc/rockchip-saradc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/adc/rockchip-saradc.c b/drivers/adc/rockchip-saradc.c
index e464d33f22..e0cbab6aa0 100644
--- a/drivers/adc/rockchip-saradc.c
+++ b/drivers/adc/rockchip-saradc.c
@@ -131,7 +131,7 @@ int rockchip_saradc_of_to_plat(struct udevice *dev)
 	}
 
 	priv->data = data;
-	uc_pdata->data_mask = (1 << priv->data->num_bits) - 1;;
+	uc_pdata->data_mask = (1 << priv->data->num_bits) - 1;
 	uc_pdata->data_format = ADC_DATA_FORMAT_BIN;
 	uc_pdata->data_timeout_us = SARADC_TIMEOUT / 5;
 	uc_pdata->channel_mask = (1 << priv->data->num_channels) - 1;
-- 
2.25.1

Re: [PATCH] drivers/adc/rockchip-saradc: remove double semi-colon

[Giulio Benetti]

On 14/03/22 09:04, Kever Yang wrote:
> Hi Giulio,
> 
>      Thanks for your patch, it's a good catching.
>      Could you please update the subject with "rockchip: adc: ", and
> add a simple description in the commit message? Empy commit message is
> not allowed according to U-Boot patch commit rules :(

Oh, I've forgotten about this in u-boot. Just sent V2:
https://patchwork.ozlabs.org/project/uboot/patch/20220314090943.821630-1-giulio.benetti@benettiengineering.com/

and tagged V1 as superseded in patchwork.

Best regards
-- 
Giulio Benetti
Benetti Engineering sas

> Thanks,
> - Kever
> 
> Giulio Benetti <giulio.benetti@benettiengineering.com> 于2022年2月4日周五 09:19写道：
>>
>> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
>> ---
>>   drivers/adc/rockchip-saradc.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/adc/rockchip-saradc.c b/drivers/adc/rockchip-saradc.c
>> index e464d33f22..e0cbab6aa0 100644
>> --- a/drivers/adc/rockchip-saradc.c
>> +++ b/drivers/adc/rockchip-saradc.c
>> @@ -131,7 +131,7 @@ int rockchip_saradc_of_to_plat(struct udevice *dev)
>>          }
>>
>>          priv->data = data;
>> -       uc_pdata->data_mask = (1 << priv->data->num_bits) - 1;;
>> +       uc_pdata->data_mask = (1 << priv->data->num_bits) - 1;
>>          uc_pdata->data_format = ADC_DATA_FORMAT_BIN;
>>          uc_pdata->data_timeout_us = SARADC_TIMEOUT / 5;
>>          uc_pdata->channel_mask = (1 << priv->data->num_channels) - 1;
>> --
>> 2.25.1
>>

Re: [PATCH v2] rockchip: saradc: remove double semi-colon

[Kever Yang]

On 2022/3/14 17:09, Giulio Benetti wrote:
> Remove double semi-colon that has been forgotten while adding the
> driver. This is only a style fix since it doesn't change the
> functionality of the driver.
>
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>


Reviewed-by: Kever Yang <kever.yang@rock-chips.com>


Thanks,
- Kever
> ---
> V1->V2:
> * Improved commit log as suggested by Kever Yang
> ---
>   drivers/adc/rockchip-saradc.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/adc/rockchip-saradc.c b/drivers/adc/rockchip-saradc.c
> index e464d33f22..e0cbab6aa0 100644
> --- a/drivers/adc/rockchip-saradc.c
> +++ b/drivers/adc/rockchip-saradc.c
> @@ -131,7 +131,7 @@ int rockchip_saradc_of_to_plat(struct udevice *dev)
>   	}
>   
>   	priv->data = data;
> -	uc_pdata->data_mask = (1 << priv->data->num_bits) - 1;;
> +	uc_pdata->data_mask = (1 << priv->data->num_bits) - 1;
>   	uc_pdata->data_format = ADC_DATA_FORMAT_BIN;
>   	uc_pdata->data_timeout_us = SARADC_TIMEOUT / 5;
>   	uc_pdata->channel_mask = (1 << priv->data->num_channels) - 1;