All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kever Yang <kever.yang@rock-chips.com>
To: u-boot@lists.denx.de
Subject: [patch v3 7/9] rockchip: video: vop: Fix format of fbbase in debug string
Date: Thu, 21 Jan 2021 20:52:54 +0800	[thread overview]
Message-ID: <CAKUh=RyXxrM4KGOLqkpPxuy978C-k422WFVOsystuwiAvvco7A@mail.gmail.com> (raw)
In-Reply-To: <20201120132823.962072859@rtp-net.org>

Hi Arnaud,

Arnaud Patard <arnaud.patard@rtp-net.org> ?2020?11?20??? ??9:32???

> The debug string printing the device name, framebuffer address and of node
> is using %lu as format for the framebuffer address, which is not so nice.
> Change it to %lx.
>
> Signed-off-by: Arnaud Patard <arnaud.patard@rtp-net.org>
> Index: u-boot/drivers/video/rockchip/rk_vop.c
> ===================================================================
> --- u-boot.orig/drivers/video/rockchip/rk_vop.c
> +++ u-boot/drivers/video/rockchip/rk_vop.c
> @@ -239,7 +239,7 @@ static int rk_display_init(struct udevic
>         ofnode remote;
>         const char *compat;
>
> -       debug("%s(%s, %lu, %s)\n", __func__,
> +       debug("%s(%s, %lx, %s)\n", __func__,
>

Please use 0x%lx instead.

Thanks,
- Kever

>               dev_read_name(dev), fbbase, ofnode_get_name(ep_node));
>
>         ret = ofnode_read_u32(ep_node, "remote-endpoint", &remote_phandle);
>
>
>

  reply	other threads:[~2021-01-21 12:52 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-20 13:24 [patch v3 0/9] rk3399 (Pinebook pro) EDP support Arnaud Patard
2020-11-20 13:24 ` [patch v3 1/9] rockchip: video: vop: Use endpoint compatible string to find VOP mode Arnaud Patard
2020-11-20 13:24 ` [patch v3 2/9] rockchip: video: edp: Add rk3399 support Arnaud Patard
2020-11-20 13:24 ` [patch v3 3/9] ockchip: video: edp: Change interrupt polarity configuration Arnaud Patard
2021-01-21 13:08   ` Kever Yang
2020-11-20 13:24 ` [patch v3 4/9] ockchip: video: vop: Reserve efi fb memory Arnaud Patard
2021-01-21 13:06   ` Kever Yang
2020-11-20 13:24 ` [patch v3 5/9] rockchip: Pinebook Pro: Enable edp Arnaud Patard
2020-11-20 13:24 ` [patch v3 6/9] rockchip: pwm: Fix default polarity Arnaud Patard
2020-11-20 13:24 ` [patch v3 7/9] rockchip: video: vop: Fix format of fbbase in debug string Arnaud Patard
2021-01-21 12:52   ` Kever Yang [this message]
2020-11-20 13:24 ` [patch v3 8/9] rockchip: video: edp: Add missing reset support Arnaud Patard
2020-11-20 13:24 ` [patch v3 9/9] rockchip: videp: vop: Add " Arnaud Patard
2021-01-21 12:50   ` Kever Yang
2021-01-25 15:04 ` [patch v3 0/9] rk3399 (Pinebook pro) EDP support Peter Robinson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKUh=RyXxrM4KGOLqkpPxuy978C-k422WFVOsystuwiAvvco7A@mail.gmail.com' \
    --to=kever.yang@rock-chips.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.