Re: [PATCH v4 00/26] toaster: 8279: Provide a single way of starting Toaster

[Brian Avery <avery.brian@gmail.com>]

Hi,

I *finally* had a chance to play with your branch and had a couple of
comments.  sorry for the delay :(.

I had 2 biggish issues, and a couple of  middling issues. I'll put
them in the bugzilla comments for 8279
(https://bugzilla.yoctoproject.org/show_bug.cgi?id=8279) so we don't
lose track.

Ty for all the hard work!!!
-b

On Thu, Nov 12, 2015 at 4:04 AM, Ed Bartosh <ed.bartosh@linux.intel.com> wrote:
> Hi,
>
> This patchset merges two Toaster modes in one:
>
> To run toaster you should source it in already prepared build environment:
>   cd poky
>   . oe-init-build-env
>   . ../bitbake/bin/toaster
>
> After that you should be able to trigger builds both ways:
> from command line and from toaster UI.
>
> Please review and test.
>
> Changes in v4: Removed buildinfohelper code which was trying to guess layer
>                version of the recipe. As a result of this bug Toaster
>                UI was not showing any information about recipes.
>
> The following changes since commit aa7690e182c9c307785e6e9679f3490583176421:
>
>   toaster: builds pages Fix the download cooker log link (2015-11-10 17:04:19 +0000)
>
> are available in the git repository at:
>
>   git://git.yoctoproject.org/poky-contrib ed/toaster/8279-v4
>   http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=ed/toaster/8279-v4
>
> Ed Bartosh (25):
>   toaster: don't allow to run toaster as a script
>   toaster: implement get-dburl command
>   toaster: set DATABASE_URL in toaster script
>   toaster: run bitbake the same way
>   toaster: remove unused variable
>   toaster: check for toaster configuration later
>   toaster: use parent of the build dir
>   toaster: make runbuilds to loop
>   toaster: start 'manage.py runbuilds' in the script
>   toaster: update brbe and project attributes
>   toaster: implement stop_bitbake function
>   toaster: implement start_bitbake function
>   toaster: implement 'toaster restart-bitbake'
>   toaster: remove _setupBE function
>   toaster: reimplemented startBBServer method
>   toaster: remove stopBBServer API
>   toaster: do not terminate bb server
>   toaster: remove usage of BUILD_MODE variable
>   toaster: do not create duplicate HelpText objects
>   toaster: implement BitbakeController.getVariable
>   toaster: set varibales on bitbake server
>   toaster: remove writeConfFile API
>   toaster: stop using toaster-pre.conf
>   toaster: remove SDKMACHINE from project variables
>   toaster: get rid of complicated heuristics
>
> Michael Wood (1):
>   toaster: buildinfohelper Broaden the toaster created recipe data case
>
>  bitbake/bin/toaster                                | 186 +++++++--------------
>  bitbake/lib/bb/ui/buildinfohelper.py               |  68 +++-----
>  bitbake/lib/bb/ui/toasterui.py                     |  14 +-
>  bitbake/lib/toaster/bldcontrol/bbcontroller.py     |  15 +-
>  .../toaster/bldcontrol/localhostbecontroller.py    | 132 ++++-----------
>  .../bldcontrol/management/commands/runbuilds.py    |  13 +-
>  bitbake/lib/toaster/bldcontrol/sshbecontroller.py  |  10 --
>  bitbake/lib/toaster/bldcontrol/tests.py            |   4 -
>  bitbake/lib/toaster/toastergui/templates/base.html |  13 +-
>  .../lib/toaster/toastergui/templates/landing.html  |  10 --
>  .../toaster/toastergui/templates/projectconf.html  |  70 +-------
>  bitbake/lib/toaster/toastergui/tests.py            |   4 -
>  bitbake/lib/toaster/toastergui/views.py            |  29 ----
>  .../toastermain/management/commands/get-dburl.py   |   9 +
>  bitbake/lib/toaster/toastermain/settings.py        |   3 -
>  bitbake/lib/toaster/toastermain/urls.py            |   9 +-
>  16 files changed, 150 insertions(+), 439 deletions(-)
>  create mode 100644 bitbake/lib/toaster/toastermain/management/commands/get-dburl.py
>
> --
> Regards,
> Ed
>
> --
> _______________________________________________
> toaster mailing list
> toaster@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/toaster