From: Lukas Bulwahn <lukas.bulwahn@gmail.com> To: Nghia Le <nghialm78@gmail.com> Cc: linux-safety@lists.elisa.tech Subject: Re: [PATCH] mm/hugetlb.c: remove deadstore in demote_size_show() Date: Sat, 2 Oct 2021 07:13:54 +0200 [thread overview] Message-ID: <CAKXUXMwT+dH_OZc_eJBMtSfbcL5hvhBoFXXbd1b_AcM2sBvW0A@mail.gmail.com> (raw) In-Reply-To: <20211001175732.75170-1-nghialm78@gmail.com> Just some minor improvements for the language: On Fri, Oct 1, 2021 at 7:57 PM Nghia Le <nghialm78@gmail.com> wrote: > > Deadstore was detected by CodeCheck tool (ELISA group) Hints: - Use active instead of passive tense - It is detected by "make clang-analyzer". The CodeChecker tool is just the webUI frontend. - Dead store is written as two words (with a space between dead and store). So, make it: The command "make clang-analyzer" detected a dead store. > > Removed demote_size and relevant assignment in function demote_size_show() > to fix deadstore issue of which stored value to demote_size is never read > Hints: - Use imperative form. - ... and just some better English grammar. So make it: Remove demote_size and corresponding assignment in function demote_size_show() to fix dead store, as demote_size is never read. Also change deadstore to dead store in subject. Other than that, it looks good to me. Send a PATCH v2 here. Then, we check again and you can send the patch out to the maintainers. Lukas > Signed-off-by: Nghia Le <nghialm78@gmail.com> > --- > mm/hugetlb.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > index 993efa70bce4..ef00e6ad0f6a 100644 > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -3706,11 +3706,9 @@ static ssize_t demote_size_show(struct kobject *kobj, > struct kobj_attribute *attr, char *buf) > { > struct hstate *h; > - unsigned long demote_size; > int nid; > > h = kobj_to_hstate(kobj, &nid); > - demote_size = h->demote_order; > > return sysfs_emit(buf, "%lukB\n", > (unsigned long)(PAGE_SIZE << h->demote_order) / SZ_1K); > -- > 2.25.1 >
WARNING: multiple messages have this Message-ID (diff)
From: "Lukas Bulwahn" <lukas.bulwahn@gmail.com> To: Nghia Le <nghialm78@gmail.com> Cc: linux-safety@lists.elisa.tech Subject: Re: [linux-safety] [PATCH] mm/hugetlb.c: remove deadstore in demote_size_show() Date: Sat, 2 Oct 2021 07:13:54 +0200 [thread overview] Message-ID: <CAKXUXMwT+dH_OZc_eJBMtSfbcL5hvhBoFXXbd1b_AcM2sBvW0A@mail.gmail.com> (raw) Message-ID: <20211002051354.qdjess0X7tnBh3ITiRD3ypzjM7tEDUl97uXO8b7ilNU@z> (raw) In-Reply-To: <20211001175732.75170-1-nghialm78@gmail.com> Just some minor improvements for the language: On Fri, Oct 1, 2021 at 7:57 PM Nghia Le <nghialm78@gmail.com> wrote: > > Deadstore was detected by CodeCheck tool (ELISA group) Hints: - Use active instead of passive tense - It is detected by "make clang-analyzer". The CodeChecker tool is just the webUI frontend. - Dead store is written as two words (with a space between dead and store). So, make it: The command "make clang-analyzer" detected a dead store. > > Removed demote_size and relevant assignment in function demote_size_show() > to fix deadstore issue of which stored value to demote_size is never read > Hints: - Use imperative form. - ... and just some better English grammar. So make it: Remove demote_size and corresponding assignment in function demote_size_show() to fix dead store, as demote_size is never read. Also change deadstore to dead store in subject. Other than that, it looks good to me. Send a PATCH v2 here. Then, we check again and you can send the patch out to the maintainers. Lukas > Signed-off-by: Nghia Le <nghialm78@gmail.com> > --- > mm/hugetlb.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > index 993efa70bce4..ef00e6ad0f6a 100644 > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -3706,11 +3706,9 @@ static ssize_t demote_size_show(struct kobject *kobj, > struct kobj_attribute *attr, char *buf) > { > struct hstate *h; > - unsigned long demote_size; > int nid; > > h = kobj_to_hstate(kobj, &nid); > - demote_size = h->demote_order; > > return sysfs_emit(buf, "%lukB\n", > (unsigned long)(PAGE_SIZE << h->demote_order) / SZ_1K); > -- > 2.25.1 > -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#248): https://lists.elisa.tech/g/linux-safety/message/248 Mute This Topic: https://lists.elisa.tech/mt/86006510/5278000 Group Owner: linux-safety+owner@lists.elisa.tech Unsubscribe: https://lists.elisa.tech/g/linux-safety/unsub [linux-safety@archiver.kernel.org] -=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2021-10-02 5:14 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-10-01 17:57 [PATCH] mm/hugetlb.c: remove deadstore in demote_size_show() Nghia Le 2021-10-01 17:57 ` [linux-safety] " Nghia Le 2021-10-02 5:13 ` Lukas Bulwahn [this message] 2021-10-02 5:13 ` Lukas Bulwahn 2021-10-02 11:56 ` Nghia Le 2021-10-02 11:56 ` [linux-safety] " Nghia Le
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAKXUXMwT+dH_OZc_eJBMtSfbcL5hvhBoFXXbd1b_AcM2sBvW0A@mail.gmail.com \ --to=lukas.bulwahn@gmail.com \ --cc=linux-safety@lists.elisa.tech \ --cc=nghialm78@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.