* Reference to non-existing DYNAMIC_FTRACE_WITH_ARGS
@ 2021-08-06 10:18 Lukas Bulwahn
2021-08-06 13:22 ` Steven Rostedt
0 siblings, 1 reply; 2+ messages in thread
From: Lukas Bulwahn @ 2021-08-06 10:18 UTC (permalink / raw)
To: Steven Rostedt (VMware)
Cc: live-patching, Linux Kernel Mailing List, Ingo Molnar,
Josh Poimboeuf, Petr Mladek, Joe Lawrence, Jiri Kosina,
Miroslav Benes, kernel-janitors
Hi Steven,
Commit 2860cd8a2353 ("livepatch: Use the default ftrace_ops instead of
REGS when ARGS is available") adds a dependency on a non-existing
config DYNAMIC_FTRACE_WITH_ARGS, see diff:
diff --git a/kernel/livepatch/Kconfig b/kernel/livepatch/Kconfig
index 54102deb50ba..53d51ed619a3 100644
--- a/kernel/livepatch/Kconfig
+++ b/kernel/livepatch/Kconfig
@@ -6,7 +6,7 @@ config HAVE_LIVEPATCH
config LIVEPATCH
bool "Kernel Live Patching"
- depends on DYNAMIC_FTRACE_WITH_REGS
+ depends on DYNAMIC_FTRACE_WITH_REGS || DYNAMIC_FTRACE_WITH_ARGS
depends on MODULES
depends on SYSFS
depends on KALLSYMS_ALL
Did you intend to depend on the existing "HAVE_DYNAMIC_FTRACE_WITH_ARGS" here?
Or did you intend to add a new config DYNAMIC_FTRACE_WITH_ARGS
analogously to DYNAMIC_FTRACE_WITH_REGS as defined in
./kernel/trace/Kconfig (see below)?
config DYNAMIC_FTRACE_WITH_REGS
def_bool y
depends on DYNAMIC_FTRACE
depends on HAVE_DYNAMIC_FTRACE_WITH_REGS
I am happy to provide a patch, once I understand what was intended here.
Lukas
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: Reference to non-existing DYNAMIC_FTRACE_WITH_ARGS
2021-08-06 10:18 Reference to non-existing DYNAMIC_FTRACE_WITH_ARGS Lukas Bulwahn
@ 2021-08-06 13:22 ` Steven Rostedt
0 siblings, 0 replies; 2+ messages in thread
From: Steven Rostedt @ 2021-08-06 13:22 UTC (permalink / raw)
To: Lukas Bulwahn
Cc: live-patching, Linux Kernel Mailing List, Ingo Molnar,
Josh Poimboeuf, Petr Mladek, Joe Lawrence, Jiri Kosina,
Miroslav Benes, kernel-janitors
On Fri, 6 Aug 2021 12:18:36 +0200
Lukas Bulwahn <lukas.bulwahn@gmail.com> wrote:
> Hi Steven,
Hi Lukas, thanks for the report.
> Did you intend to depend on the existing "HAVE_DYNAMIC_FTRACE_WITH_ARGS" here?
>
> Or did you intend to add a new config DYNAMIC_FTRACE_WITH_ARGS
> analogously to DYNAMIC_FTRACE_WITH_REGS as defined in
> ./kernel/trace/Kconfig (see below)?
>
> config DYNAMIC_FTRACE_WITH_REGS
> def_bool y
> depends on DYNAMIC_FTRACE
> depends on HAVE_DYNAMIC_FTRACE_WITH_REGS
>
> I am happy to provide a patch, once I understand what was intended here.
>
Yeah, that looks to be the missing part. The
HAVE_DYNAMIC_FTRACE_WITH_ARGS is just showing support, but knowing it
is enabled would require DYNAMIC_FTRACE being set (which is user
enabled).
Feel free to send a patch, and mark it for stable.
-- Steve
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-08-06 13:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-06 10:18 Reference to non-existing DYNAMIC_FTRACE_WITH_ARGS Lukas Bulwahn
2021-08-06 13:22 ` Steven Rostedt
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.