* Dependency of USB_DWC3_XILINX on ARCH_VERSAL
@ 2021-08-18 6:47 Lukas Bulwahn
2021-08-18 10:02 ` Felipe Balbi
0 siblings, 1 reply; 2+ messages in thread
From: Lukas Bulwahn @ 2021-08-18 6:47 UTC (permalink / raw)
To: Manish Narani; +Cc: Greg Kroah-Hartman, linux-usb, Linux Kernel Mailing List
Dear Manish,
Commit 84770f028fab ("usb: dwc3: Add driver for Xilinx platforms")
adds the config USB_DWC3_XILINX, which depends on the config
ARCH_VERSAL. However, the config ARCH_VERSAL is not defined in the
current mainline kernel repository.
Will a definition of ARCH_VERSAL follow eventually (soon?) for
mainline, is there just a further out-of-tree development for which
the dependency is useful or is this just a mistake and can be
corrected?
Best regards,
Lukas
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Dependency of USB_DWC3_XILINX on ARCH_VERSAL
2021-08-18 6:47 Dependency of USB_DWC3_XILINX on ARCH_VERSAL Lukas Bulwahn
@ 2021-08-18 10:02 ` Felipe Balbi
0 siblings, 0 replies; 2+ messages in thread
From: Felipe Balbi @ 2021-08-18 10:02 UTC (permalink / raw)
To: Lukas Bulwahn
Cc: Manish Narani, Greg Kroah-Hartman, linux-usb, Linux Kernel Mailing List
Hi Lukas,
Lukas Bulwahn <lukas.bulwahn@gmail.com> writes:
> Commit 84770f028fab ("usb: dwc3: Add driver for Xilinx platforms")
> adds the config USB_DWC3_XILINX, which depends on the config
> ARCH_VERSAL. However, the config ARCH_VERSAL is not defined in the
> current mainline kernel repository.
>
> Will a definition of ARCH_VERSAL follow eventually (soon?) for
> mainline, is there just a further out-of-tree development for which
> the dependency is useful or is this just a mistake and can be
> corrected?
IMHO, we should have COMPILE_TEST added. Something like this:
modified drivers/usb/dwc3/Kconfig
@@ -151,7 +151,7 @@ config USB_DWC3_IMX8MP
config USB_DWC3_XILINX
tristate "Xilinx Platforms"
- depends on (ARCH_ZYNQMP || ARCH_VERSAL) && OF
+ depends on (ARCH_ZYNQMP || ARCH_VERSAL || COMPILE_TEST) && OF
default USB_DWC3
help
Support Xilinx SoCs with DesignWare Core USB3 IP.
Care to test, please
--
balbi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-08-18 10:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-18 6:47 Dependency of USB_DWC3_XILINX on ARCH_VERSAL Lukas Bulwahn
2021-08-18 10:02 ` Felipe Balbi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.