[PATCH] drivers: mtd: ubi: fixed a semicolon style issue in block.c

[PATCH] drivers: mtd: ubi: fixed a semicolon style issue in block.c

[Rahul Balaji]

fixed a small coding style issue in using semicolon.

signed-off-by: Rahul Balaji <rahulbalaji78@gmail.com>
---
 drivers/mtd/ubi/block.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mtd/ubi/block.c b/drivers/mtd/ubi/block.c
index e003b4b44ffa..e0402c2f8959 100644
--- a/drivers/mtd/ubi/block.c
+++ b/drivers/mtd/ubi/block.c
@@ -405,7 +405,7 @@ int ubiblock_create(struct ubi_volume_info *vi)
 	ret = blk_mq_alloc_tag_set(&dev->tag_set);
 	if (ret) {
 		dev_err(disk_to_dev(dev->gd), "blk_mq_alloc_tag_set failed");
-		goto out_free_dev;;
+		goto out_free_dev;
 	}
 
 
-- 
2.25.1

_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

Re: [PATCH] drivers: mtd: ubi: fixed a semicolon style issue in block.c

[Rahul Balaji]

[-- Attachment #1.1: Type: text/plain, Size: 981 bytes --]

respected mentor,

I have sent the first patch only as per the task. please do give me your
confirmation so that i can proceed further with the other patches too

Thank you,
sincerely,
rahul.

On Mon, Aug 2, 2021 at 2:06 AM Rahul Balaji <rahulbalaji78@gmail.com> wrote:

> fixed a small coding style issue in using semicolon.
>
> signed-off-by: Rahul Balaji <rahulbalaji78@gmail.com>
> ---
>  drivers/mtd/ubi/block.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/ubi/block.c b/drivers/mtd/ubi/block.c
> index e003b4b44ffa..e0402c2f8959 100644
> --- a/drivers/mtd/ubi/block.c
> +++ b/drivers/mtd/ubi/block.c
> @@ -405,7 +405,7 @@ int ubiblock_create(struct ubi_volume_info *vi)
>         ret = blk_mq_alloc_tag_set(&dev->tag_set);
>         if (ret) {
>                 dev_err(disk_to_dev(dev->gd), "blk_mq_alloc_tag_set
> failed");
> -               goto out_free_dev;;
> +               goto out_free_dev;
>         }
>
>
> --
> 2.25.1
>
>

[-- Attachment #1.2: Type: text/html, Size: 1528 bytes --]

[-- Attachment #2: Type: text/plain, Size: 201 bytes --]

_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

Re: [PATCH] drivers: mtd: ubi: fixed a semicolon style issue in block.c

[Rahul Balaji]

[-- Attachment #1.1: Type: text/plain, Size: 1326 bytes --]

sorry for that slight misunderstanding. i thought the first patch meant
only a small test patch for the first file. I will send the other changes
shortly too.

Thank you for your understanding.

yours sincerely,
Rahul.



On Mon, Aug 2, 2021 at 2:10 AM Rahul Balaji <rahulbalaji78@gmail.com> wrote:

> respected mentor,
>
> I have sent the first patch only as per the task. please do give me your
> confirmation so that i can proceed further with the other patches too
>
> Thank you,
> sincerely,
> rahul.
>
> On Mon, Aug 2, 2021 at 2:06 AM Rahul Balaji <rahulbalaji78@gmail.com>
> wrote:
>
>> fixed a small coding style issue in using semicolon.
>>
>> signed-off-by: Rahul Balaji <rahulbalaji78@gmail.com>
>> ---
>>  drivers/mtd/ubi/block.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/mtd/ubi/block.c b/drivers/mtd/ubi/block.c
>> index e003b4b44ffa..e0402c2f8959 100644
>> --- a/drivers/mtd/ubi/block.c
>> +++ b/drivers/mtd/ubi/block.c
>> @@ -405,7 +405,7 @@ int ubiblock_create(struct ubi_volume_info *vi)
>>         ret = blk_mq_alloc_tag_set(&dev->tag_set);
>>         if (ret) {
>>                 dev_err(disk_to_dev(dev->gd), "blk_mq_alloc_tag_set
>> failed");
>> -               goto out_free_dev;;
>> +               goto out_free_dev;
>>         }
>>
>>
>> --
>> 2.25.1
>>
>>

[-- Attachment #1.2: Type: text/html, Size: 2226 bytes --]

[-- Attachment #2: Type: text/plain, Size: 201 bytes --]

_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

Re: [PATCH] drivers: mtd: ubi: fixed a semicolon style issue in block.c

[Lukas Bulwahn]

Use imperative: Subject line shall be in imperative form.

On Mon, Aug 2, 2021 at 12:06 AM Rahul Balaji <rahulbalaji78@gmail.com> wrote:
>
> fixed a small coding style issue in using semicolon.
>

Mention your motivation, i.e., the investigation of the ONE_SEMICOLON rule.

Mention if this change modifies the code's behaviour.

If not, add to the comment message:

"No functional change."

> signed-off-by: Rahul Balaji <rahulbalaji78@gmail.com>

signed-off-by is written as "Signed-off-by:".

Did you run checkpatch on your patch? What is the checkpatch output
running your patch? Please share that with us.

Give it another try and create a PATCH v2.

Lukas

> ---
>  drivers/mtd/ubi/block.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/ubi/block.c b/drivers/mtd/ubi/block.c
> index e003b4b44ffa..e0402c2f8959 100644
> --- a/drivers/mtd/ubi/block.c
> +++ b/drivers/mtd/ubi/block.c
> @@ -405,7 +405,7 @@ int ubiblock_create(struct ubi_volume_info *vi)
>         ret = blk_mq_alloc_tag_set(&dev->tag_set);
>         if (ret) {
>                 dev_err(disk_to_dev(dev->gd), "blk_mq_alloc_tag_set failed");
> -               goto out_free_dev;;
> +               goto out_free_dev;
>         }
>
>
> --
> 2.25.1
>
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees