* Non-existing config symbols DEBUG_OMAP{3,4,5}UART{1,2}
@ 2021-10-11 5:28 ` Lukas Bulwahn
0 siblings, 0 replies; 4+ messages in thread
From: Lukas Bulwahn @ 2021-10-11 5:28 UTC (permalink / raw)
To: Tony Lindgren; +Cc: linux-arm-kernel, Russell King, Linux Kernel Mailing List
Dear Tony,
With commit d2b310b0234c ("ARM: debug: Use generic 8250 debug_ll for
omap2 and omap3/4/5 common uarts"), you added address definitions of
DEBUG_UART_PHYS for OMAP2, OMAP3, OMAP4 and OMAP5 in
./arch/arm/Kconfig.debug.
These definitions depend on:
- DEBUG_OMAP2UART1 || DEBUG_OMAP3UART1 || DEBUG_OMAP4UART1 ||
DEBUG_OMAP5UART1, and
- DEBUG_OMAP2UART2 || DEBUG_OMAP3UART2 || DEBUG_OMAP4UART2 ||
DEBUG_OMAP5UART2.
As of now, only DEBUG_OMAP2UART{1,2} are defined in
./arch/arm/Kconfig.debug, but DEBUG_OMAP{3,4,5}UART{1,2} are not
defined. Hence, ./scripts/checkkconfigsymbols.py warns here on
non-existing symbols.
I am unsure about the best way to resolve this issue.
- Would you like to simply reuse the config DEBUG_OMAP2UART{1,2} also
for OMAP3, OMAP4 and OMAP5? Then, we probably just need to delete the
dead references
to DEBUG_OMAP{3,4,5}UART{1,2}. If you consider this further change
helpful, we could even rename the configs to DEBUG_OMAP2PLUSUART{1,2}
to make the architecture more specific.
- Do you see the need for separate config definitions for UART{1,2} on
OMAP3, OMAP4 and OMAP5? Then, we would need to add further definitions
DEBUG_OMAP{3,4,5}UART{1,2}
in this file and link those to the specific architecture.
Once the direction is clear, I am happy to provide a patch to address
this issue or you can quickly take care of this yourself.
Best regards,
Lukas
^ permalink raw reply [flat|nested] 4+ messages in thread
* Non-existing config symbols DEBUG_OMAP{3,4,5}UART{1,2}
@ 2021-10-11 5:28 ` Lukas Bulwahn
0 siblings, 0 replies; 4+ messages in thread
From: Lukas Bulwahn @ 2021-10-11 5:28 UTC (permalink / raw)
To: Tony Lindgren; +Cc: linux-arm-kernel, Russell King, Linux Kernel Mailing List
Dear Tony,
With commit d2b310b0234c ("ARM: debug: Use generic 8250 debug_ll for
omap2 and omap3/4/5 common uarts"), you added address definitions of
DEBUG_UART_PHYS for OMAP2, OMAP3, OMAP4 and OMAP5 in
./arch/arm/Kconfig.debug.
These definitions depend on:
- DEBUG_OMAP2UART1 || DEBUG_OMAP3UART1 || DEBUG_OMAP4UART1 ||
DEBUG_OMAP5UART1, and
- DEBUG_OMAP2UART2 || DEBUG_OMAP3UART2 || DEBUG_OMAP4UART2 ||
DEBUG_OMAP5UART2.
As of now, only DEBUG_OMAP2UART{1,2} are defined in
./arch/arm/Kconfig.debug, but DEBUG_OMAP{3,4,5}UART{1,2} are not
defined. Hence, ./scripts/checkkconfigsymbols.py warns here on
non-existing symbols.
I am unsure about the best way to resolve this issue.
- Would you like to simply reuse the config DEBUG_OMAP2UART{1,2} also
for OMAP3, OMAP4 and OMAP5? Then, we probably just need to delete the
dead references
to DEBUG_OMAP{3,4,5}UART{1,2}. If you consider this further change
helpful, we could even rename the configs to DEBUG_OMAP2PLUSUART{1,2}
to make the architecture more specific.
- Do you see the need for separate config definitions for UART{1,2} on
OMAP3, OMAP4 and OMAP5? Then, we would need to add further definitions
DEBUG_OMAP{3,4,5}UART{1,2}
in this file and link those to the specific architecture.
Once the direction is clear, I am happy to provide a patch to address
this issue or you can quickly take care of this yourself.
Best regards,
Lukas
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Non-existing config symbols DEBUG_OMAP{3,4,5}UART{1,2}
2021-10-11 5:28 ` Lukas Bulwahn
@ 2021-10-21 12:58 ` Tony Lindgren
-1 siblings, 0 replies; 4+ messages in thread
From: Tony Lindgren @ 2021-10-21 12:58 UTC (permalink / raw)
To: Lukas Bulwahn
Cc: linux-arm-kernel, Russell King, Linux Kernel Mailing List, linux-omap
Hi,
* Lukas Bulwahn <lukas.bulwahn@gmail.com> [211011 05:39]:
> Dear Tony,
>
> With commit d2b310b0234c ("ARM: debug: Use generic 8250 debug_ll for
> omap2 and omap3/4/5 common uarts"), you added address definitions of
> DEBUG_UART_PHYS for OMAP2, OMAP3, OMAP4 and OMAP5 in
> ./arch/arm/Kconfig.debug.
>
> These definitions depend on:
> - DEBUG_OMAP2UART1 || DEBUG_OMAP3UART1 || DEBUG_OMAP4UART1 ||
> DEBUG_OMAP5UART1, and
> - DEBUG_OMAP2UART2 || DEBUG_OMAP3UART2 || DEBUG_OMAP4UART2 ||
> DEBUG_OMAP5UART2.
>
> As of now, only DEBUG_OMAP2UART{1,2} are defined in
> ./arch/arm/Kconfig.debug, but DEBUG_OMAP{3,4,5}UART{1,2} are not
> defined. Hence, ./scripts/checkkconfigsymbols.py warns here on
> non-existing symbols.
>
> I am unsure about the best way to resolve this issue.
>
> - Would you like to simply reuse the config DEBUG_OMAP2UART{1,2} also
> for OMAP3, OMAP4 and OMAP5? Then, we probably just need to delete the
> dead references
> to DEBUG_OMAP{3,4,5}UART{1,2}. If you consider this further change
> helpful, we could even rename the configs to DEBUG_OMAP2PLUSUART{1,2}
> to make the architecture more specific.
>
> - Do you see the need for separate config definitions for UART{1,2} on
> OMAP3, OMAP4 and OMAP5? Then, we would need to add further definitions
> DEBUG_OMAP{3,4,5}UART{1,2}
> in this file and link those to the specific architecture.
>
> Once the direction is clear, I am happy to provide a patch to address
> this issue or you can quickly take care of this yourself.
The missing ones should be the same as the DEBUG_OMAP2 I think. We still
have these defined in arch/arm/mach-omap2/include/mach/serial.h, so that
can be used to confirm it.
Seems like we can just reuse the DEBUG_OMAP2UART variants, not sure if
we need to rename these to DEBUG_OMAP2PLUSUART variants.
Regards,
Tony
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Non-existing config symbols DEBUG_OMAP{3,4,5}UART{1,2}
@ 2021-10-21 12:58 ` Tony Lindgren
0 siblings, 0 replies; 4+ messages in thread
From: Tony Lindgren @ 2021-10-21 12:58 UTC (permalink / raw)
To: Lukas Bulwahn
Cc: linux-arm-kernel, Russell King, Linux Kernel Mailing List, linux-omap
Hi,
* Lukas Bulwahn <lukas.bulwahn@gmail.com> [211011 05:39]:
> Dear Tony,
>
> With commit d2b310b0234c ("ARM: debug: Use generic 8250 debug_ll for
> omap2 and omap3/4/5 common uarts"), you added address definitions of
> DEBUG_UART_PHYS for OMAP2, OMAP3, OMAP4 and OMAP5 in
> ./arch/arm/Kconfig.debug.
>
> These definitions depend on:
> - DEBUG_OMAP2UART1 || DEBUG_OMAP3UART1 || DEBUG_OMAP4UART1 ||
> DEBUG_OMAP5UART1, and
> - DEBUG_OMAP2UART2 || DEBUG_OMAP3UART2 || DEBUG_OMAP4UART2 ||
> DEBUG_OMAP5UART2.
>
> As of now, only DEBUG_OMAP2UART{1,2} are defined in
> ./arch/arm/Kconfig.debug, but DEBUG_OMAP{3,4,5}UART{1,2} are not
> defined. Hence, ./scripts/checkkconfigsymbols.py warns here on
> non-existing symbols.
>
> I am unsure about the best way to resolve this issue.
>
> - Would you like to simply reuse the config DEBUG_OMAP2UART{1,2} also
> for OMAP3, OMAP4 and OMAP5? Then, we probably just need to delete the
> dead references
> to DEBUG_OMAP{3,4,5}UART{1,2}. If you consider this further change
> helpful, we could even rename the configs to DEBUG_OMAP2PLUSUART{1,2}
> to make the architecture more specific.
>
> - Do you see the need for separate config definitions for UART{1,2} on
> OMAP3, OMAP4 and OMAP5? Then, we would need to add further definitions
> DEBUG_OMAP{3,4,5}UART{1,2}
> in this file and link those to the specific architecture.
>
> Once the direction is clear, I am happy to provide a patch to address
> this issue or you can quickly take care of this yourself.
The missing ones should be the same as the DEBUG_OMAP2 I think. We still
have these defined in arch/arm/mach-omap2/include/mach/serial.h, so that
can be used to confirm it.
Seems like we can just reuse the DEBUG_OMAP2UART variants, not sure if
we need to rename these to DEBUG_OMAP2PLUSUART variants.
Regards,
Tony
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-10-21 13:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-11 5:28 Non-existing config symbols DEBUG_OMAP{3,4,5}UART{1,2} Lukas Bulwahn
2021-10-11 5:28 ` Lukas Bulwahn
2021-10-21 12:58 ` Tony Lindgren
2021-10-21 12:58 ` Tony Lindgren
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.