From: Lukas Bulwahn <lukas.bulwahn@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: Dwaipayan Ray <dwaipayanray1@gmail.com>,
linux-kernel-mentees@lists.linuxfoundation.org,
Aditya Srivastava <yashsri421@gmail.com>
Subject: Re: [Linux-kernel-mentees] comment on checkpatch
Date: Tue, 12 Jan 2021 07:08:14 +0100 [thread overview]
Message-ID: <CAKXUXMzuu7BwKB0SGnT-kqbh-abKeoWpaqWHiPyRMYq7i=43gA@mail.gmail.com> (raw)
In-Reply-To: <81fda9fc9abde72cde4965d84effc358bee565cf.camel@perches.com>
On Tue, Jan 12, 2021 at 7:02 AM Joe Perches <joe@perches.com> wrote:
>
> On Tue, 2021-01-12 at 11:05 +0530, Dwaipayan Ray wrote:
> > On Tue, Jan 12, 2021 at 10:38 AM Lukas Bulwahn <lukas.bulwahn@gmail.com> wrote:
> > >
> > > https://lore.kernel.org/linux-next/20210111230029.GM4728@sirena.org.uk/T/#m355576186555c4b6e85dbb9a1b3fe3d5e80f6e9f
> > >
> > > Aditya, Dwaipayan, Have a look. checkpatch already handles this, right?
> > >
> > Hi
> > The following Fixes line in commit log emits no warning:
> > Fixes: Use packed mode for 32 bits per word transfers to increase
> >
> > Neither does a fixes with mismatched commit description:
> > Fixes: e4da63cda51f ("networking: packet_mmap: fix old config reference")
> >
> > which should have been infact:
> > Fixes: e4da63cda51f ("docs: networking: packet_mmap: fix old config
> > reference")
> >
> > I could work on this if Lukas and Joe are okay with it.
>
> It's not really a solvable problem as the SHA1 probably exists in an
> individual local tree.
>
>
Joe, so did you deactivate checking Fixes: at some point?
We can always check if it makes locally sense; that still does not
avoid the situation when a Fixes to an individual local tree and later
during integration hashes change, but it does sanity-checking on Fixes
tags for the hashes and descriptions that are stable.
Lukas
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next prev parent reply other threads:[~2021-01-12 6:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-12 5:08 [Linux-kernel-mentees] comment on checkpatch Lukas Bulwahn
2021-01-12 5:35 ` Dwaipayan Ray
2021-01-12 6:02 ` Joe Perches
2021-01-12 6:08 ` Lukas Bulwahn [this message]
2021-01-12 6:15 ` Joe Perches
2021-01-12 6:16 ` Joe Perches
2021-01-12 6:03 ` Lukas Bulwahn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKXUXMzuu7BwKB0SGnT-kqbh-abKeoWpaqWHiPyRMYq7i=43gA@mail.gmail.com' \
--to=lukas.bulwahn@gmail.com \
--cc=dwaipayanray1@gmail.com \
--cc=joe@perches.com \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=yashsri421@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.