* ksmbd,transport_rdma.c: Don't include rwlock.h directly
@ 2021-09-12 2:19 Mike Galbraith
2021-09-12 2:23 ` Mike Galbraith
0 siblings, 1 reply; 3+ messages in thread
From: Mike Galbraith @ 2021-09-12 2:19 UTC (permalink / raw)
To: lkml; +Cc: Hyunchul Lee, Namjae Jeon
rwlock.h specifically asks to not be included directly.
In fact, the proper spinlock.h include isn't needed either,
it comes with the huge pile that kthread.h ends up pulling
in, so just drop it entirely.
Signed-off-by: Mike Galbraith <efault@gmx.de>
---
fs/ksmbd/transport_rdma.c | 1 -
1 file changed, 1 deletion(-)
--- a/fs/ksmbd/transport_rdma.c
+++ b/fs/ksmbd/transport_rdma.c
@@ -20,7 +20,6 @@
#define SUBMOD_NAME "smb_direct"
#include <linux/kthread.h>
-#include <linux/rwlock.h>
#include <linux/list.h>
#include <linux/mempool.h>
#include <linux/highmem.h>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: ksmbd,transport_rdma.c: Don't include rwlock.h directly
2021-09-12 2:19 ksmbd,transport_rdma.c: Don't include rwlock.h directly Mike Galbraith
@ 2021-09-12 2:23 ` Mike Galbraith
2021-09-12 3:00 ` Namjae Jeon
0 siblings, 1 reply; 3+ messages in thread
From: Mike Galbraith @ 2021-09-12 2:23 UTC (permalink / raw)
To: lkml; +Cc: Hyunchul Lee, Namjae Jeon
typing hard.. Thag forget type [patch]
On Sun, 2021-09-12 at 04:19 +0200, Mike Galbraith wrote:
>
> rwlock.h specifically asks to not be included directly.
>
> In fact, the proper spinlock.h include isn't needed either,
> it comes with the huge pile that kthread.h ends up pulling
> in, so just drop it entirely.
>
> Signed-off-by: Mike Galbraith <efault@gmx.de>
> ---
> fs/ksmbd/transport_rdma.c | 1 -
> 1 file changed, 1 deletion(-)
>
> --- a/fs/ksmbd/transport_rdma.c
> +++ b/fs/ksmbd/transport_rdma.c
> @@ -20,7 +20,6 @@
> #define SUBMOD_NAME "smb_direct"
>
> #include <linux/kthread.h>
> -#include <linux/rwlock.h>
> #include <linux/list.h>
> #include <linux/mempool.h>
> #include <linux/highmem.h>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: ksmbd,transport_rdma.c: Don't include rwlock.h directly
2021-09-12 2:23 ` Mike Galbraith
@ 2021-09-12 3:00 ` Namjae Jeon
0 siblings, 0 replies; 3+ messages in thread
From: Namjae Jeon @ 2021-09-12 3:00 UTC (permalink / raw)
To: Mike Galbraith; +Cc: lkml, Hyunchul Lee, CIFS
2021-09-12 11:23 GMT+09:00, Mike Galbraith <efault@gmx.de>:
> typing hard.. Thag forget type [patch]
I will apply this patch, Thanks for your patch!
>
> On Sun, 2021-09-12 at 04:19 +0200, Mike Galbraith wrote:
>>
>> rwlock.h specifically asks to not be included directly.
>>
>> In fact, the proper spinlock.h include isn't needed either,
>> it comes with the huge pile that kthread.h ends up pulling
>> in, so just drop it entirely.
>>
>> Signed-off-by: Mike Galbraith <efault@gmx.de>
>> ---
>> fs/ksmbd/transport_rdma.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> --- a/fs/ksmbd/transport_rdma.c
>> +++ b/fs/ksmbd/transport_rdma.c
>> @@ -20,7 +20,6 @@
>> #define SUBMOD_NAME "smb_direct"
>>
>> #include <linux/kthread.h>
>> -#include <linux/rwlock.h>
>> #include <linux/list.h>
>> #include <linux/mempool.h>
>> #include <linux/highmem.h>
>>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-09-12 3:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-12 2:19 ksmbd,transport_rdma.c: Don't include rwlock.h directly Mike Galbraith
2021-09-12 2:23 ` Mike Galbraith
2021-09-12 3:00 ` Namjae Jeon
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.