All of lore.kernel.org
 help / color / mirror / Atom feed
From: NamJae Jeon <linkinjeon@gmail.com>
To: "Ted Ts'o" <tytso@mit.edu>, Shaohua Li <shaohua.li@intel.com>,
	Christoph Hellwig <hch@infradead.org>,
	Jens Axboe <axboe@kernel.dk>,
	Andrew Morton <akpm@linux-foundation.org>,
	lkml <linux-kernel@vger.kernel.org>,
	linux-ext4@vger.kernel.org
Subject: Re: [patch]ext4: add block plug for .writepages
Date: Tue, 11 Oct 2011 09:07:56 +0900	[thread overview]
Message-ID: <CAKYAXd_Akk_9yNM-ZN=8hYM=0JEKSzzqXLjbQY9auPK0Qe6NoQ@mail.gmail.com> (raw)
In-Reply-To: <20111010165116.GX7948@thunk.org>

2011/10/11 Ted Ts'o <tytso@mit.edu>:
> On Wed, Sep 28, 2011 at 11:09:40AM +0800, Shaohua Li wrote:
>> I searched a little bit, looks only ext4 need it. here is the patch.
>>
>>
>> Add block plug for ext4 .writepages. Though ext4 .writepages
>> already handles request merge very well, block plug is still
>> helpful to reduce block lock contention.
>>
>> Signed-off-by: Shaohua Li <shaohua.li@intel.com>
You found good point.
If there are other filesystem that didn't use generic_writepages,
these are needed as this patch.

Reviewed-by: NamJae Jeon <linkinjeon@gmail.com>
>
> Thanks, applied.
>
>                                        - Ted
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>

WARNING: multiple messages have this Message-ID (diff)
From: NamJae Jeon <linkinjeon@gmail.com>
To: "Ted Ts'o" <tytso@mit.edu>, Shaohua Li <shaohua.li@intel.com>,
	Christoph Hellwig <hch@infradead.org>,
	Jens Axboe <axboe@kernel.dk>,
	Andrew Morton <akpm@linux-foundation.org>,
	lkml <l
Subject: Re: [patch]ext4: add block plug for .writepages
Date: Tue, 11 Oct 2011 09:07:56 +0900	[thread overview]
Message-ID: <CAKYAXd_Akk_9yNM-ZN=8hYM=0JEKSzzqXLjbQY9auPK0Qe6NoQ@mail.gmail.com> (raw)
In-Reply-To: <20111010165116.GX7948@thunk.org>

2011/10/11 Ted Ts'o <tytso@mit.edu>:
> On Wed, Sep 28, 2011 at 11:09:40AM +0800, Shaohua Li wrote:
>> I searched a little bit, looks only ext4 need it. here is the patch.
>>
>>
>> Add block plug for ext4 .writepages. Though ext4 .writepages
>> already handles request merge very well, block plug is still
>> helpful to reduce block lock contention.
>>
>> Signed-off-by: Shaohua Li <shaohua.li@intel.com>
You found good point.
If there are other filesystem that didn't use generic_writepages,
these are needed as this patch.

Reviewed-by: NamJae Jeon <linkinjeon@gmail.com>
>
> Thanks, applied.
>
>                                        - Ted
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2011-10-11  0:07 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-26  2:30 [patch]mm: add more blk plug Shaohua Li
2011-09-26  7:30 ` Christoph Hellwig
2011-09-26  7:38   ` Shaohua Li
2011-09-26  9:45     ` Christoph Hellwig
2011-09-28  3:09       ` [patch]ext4: add block plug for .writepages Shaohua Li
2011-10-09  6:09         ` Shaohua Li
2011-10-10 16:51         ` Ted Ts'o
2011-10-11  0:07           ` NamJae Jeon [this message]
2011-10-11  0:07             ` NamJae Jeon
2011-10-11 10:40           ` Kyungmin Park
2011-10-11 10:40             ` Kyungmin Park
2011-10-12  0:53             ` Shaohua Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKYAXd_Akk_9yNM-ZN=8hYM=0JEKSzzqXLjbQY9auPK0Qe6NoQ@mail.gmail.com' \
    --to=linkinjeon@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=axboe@kernel.dk \
    --cc=hch@infradead.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shaohua.li@intel.com \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.