Name string of SMB2_CREATE_ALLOCATION_SIZE is AlSi or AISi ?

Name string of SMB2_CREATE_ALLOCATION_SIZE is AlSi or AISi ?

[Namjae Jeon]

I found that name strings of SMB2_CREATE_ALLOCATION_SIZE are different
between samba and cifs/ksmbd like the following. In the MS-SMB2
specification, the name of SMB2_CREATE_ALLOCATION_SIZE is defined as
AISi.
Is it a typo in the specification or is samba defining it incorrectly?

samba-4.19.2/libcli/smb/smb2_constants.h :
#define SMB2_CREATE_TAG_ALSI "AlSi"

/fs/smb/common/smb2pdu.h :
#define SMB2_CREATE_ALLOCATION_SIZE             "AISi"

Thanks.

Re: Name string of SMB2_CREATE_ALLOCATION_SIZE is AlSi or AISi ?

[Ralph Boehme]

[-- Attachment #1.1: Type: text/plain, Size: 743 bytes --]

On 12/5/23 08:48, Namjae Jeon via samba-technical wrote:
> I found that name strings of SMB2_CREATE_ALLOCATION_SIZE are different
> between samba and cifs/ksmbd like the following. In the MS-SMB2
> specification, the name of SMB2_CREATE_ALLOCATION_SIZE is defined as
> AISi.
> Is it a typo in the specification or is samba defining it incorrectly?
> 
> samba-4.19.2/libcli/smb/smb2_constants.h :
> #define SMB2_CREATE_TAG_ALSI "AlSi"
> 
> /fs/smb/common/smb2pdu.h :
> #define SMB2_CREATE_ALLOCATION_SIZE             "AISi"

looks like a bug in MS-SMB2: they have the value as 0x416c5369, which is 
"AlSi", with an "l" like in "l"ake.

Adding dochelp to cc.

@dochelp: looks like you have a small bug in MS-SMB2. :)

-slow

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]

RE: [EXTERNAL] Re: Name string of SMB2_CREATE_ALLOCATION_SIZE is AlSi or AISi ? - TrackingID#2312050040009715

[Michael Bowen]

[DocHelp to bcc]
Hi Ralph,

Thanks for your question about smb2. We’ve created case 2312050040009715 to track this issue. One of our engineers will contact you soon. 

Best regards,
Mike Bowen
Escalation Engineer - Microsoft Open Specifications

-----Original Message-----
From: Ralph Boehme <slow@samba.org> 
Sent: Tuesday, December 5, 2023 2:01 AM
To: Namjae Jeon <linkinjeon@kernel.org>; CIFS <linux-cifs@vger.kernel.org>; samba-technical <samba-technical@lists.samba.org>; Interoperability Documentation Help <dochelp@microsoft.com>
Subject: [EXTERNAL] Re: Name string of SMB2_CREATE_ALLOCATION_SIZE is AlSi or AISi ?

On 12/5/23 08:48, Namjae Jeon via samba-technical wrote:
> I found that name strings of SMB2_CREATE_ALLOCATION_SIZE are different 
> between samba and cifs/ksmbd like the following. In the MS-SMB2 
> specification, the name of SMB2_CREATE_ALLOCATION_SIZE is defined as 
> AISi.
> Is it a typo in the specification or is samba defining it incorrectly?
> 
> samba-4.19.2/libcli/smb/smb2_constants.h :
> #define SMB2_CREATE_TAG_ALSI "AlSi"
> 
> /fs/smb/common/smb2pdu.h :
> #define SMB2_CREATE_ALLOCATION_SIZE             "AISi"

looks like a bug in MS-SMB2: they have the value as 0x416c5369, which is "AlSi", with an "l" like in "l"ake.

Adding dochelp to cc.

@dochelp: looks like you have a small bug in MS-SMB2. :)

-slow

Re: Name string of SMB2_CREATE_ALLOCATION_SIZE is AlSi or AISi ?

[Namjae Jeon]

2023-12-05 19:01 GMT+09:00, Ralph Boehme <slow@samba.org>:
> On 12/5/23 08:48, Namjae Jeon via samba-technical wrote:
>> I found that name strings of SMB2_CREATE_ALLOCATION_SIZE are different
>> between samba and cifs/ksmbd like the following. In the MS-SMB2
>> specification, the name of SMB2_CREATE_ALLOCATION_SIZE is defined as
>> AISi.
>> Is it a typo in the specification or is samba defining it incorrectly?
>>
>> samba-4.19.2/libcli/smb/smb2_constants.h :
>> #define SMB2_CREATE_TAG_ALSI "AlSi"
>>
>> /fs/smb/common/smb2pdu.h :
>> #define SMB2_CREATE_ALLOCATION_SIZE             "AISi"
>
> looks like a bug in MS-SMB2: they have the value as 0x416c5369, which is
> "AlSi", with an "l" like in "l"ake.
I will fix it in common header of cifs/ksmbd.
Thanks for your check!

>
> Adding dochelp to cc.
>
> @dochelp: looks like you have a small bug in MS-SMB2. :)
>
> -slow
>