* [PATCH] XEN/xen-kbdfront: Enable auto repeat for xen keyboard front driver
@ 2017-08-21 15:41 Liang Yan
2017-08-21 19:30 ` Boris Ostrovsky
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Liang Yan @ 2017-08-21 15:41 UTC (permalink / raw)
To: xen-devel, boris.ostrovsky, Juergen Gross, linux-kernel
[-- Attachment #1.1: Type: text/plain, Size: 955 bytes --]
Long pressed key could not show right in XEN vncviewer after tigervnc client changed the way how to send repeat keys, from "Down Up Down Up ..." to "Down Down Dow." By enable EV_REP bit here, XEN keyboard device will trigger default auto repeat process from input subsystem, and make auto repeat keys work correctly.
Signed-off-by: Liang Yan <lyan@suse.com>
---
drivers/input/misc/xen-kbdfront.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/input/misc/xen-kbdfront.c b/drivers/input/misc/xen-kbdfront.c
index fa130e7b734c..0dce9830e2f4 100644
--- a/drivers/input/misc/xen-kbdfront.c
+++ b/drivers/input/misc/xen-kbdfront.c
@@ -248,6 +248,7 @@ static int xenkbd_probe(struct xenbus_device *dev,
kbd->id.product = 0xffff;
__set_bit(EV_KEY, kbd->evbit);
+ __set_bit(EV_REP, kbd->evbit);
for (i = KEY_ESC; i < KEY_UNKNOWN; i++)
__set_bit(i, kbd->keybit);
for (i = KEY_OK; i < KEY_MAX; i++)
--
2.14.0
[-- Attachment #1.2: HTML --]
[-- Type: text/html, Size: 1722 bytes --]
[-- Attachment #2: Type: text/plain, Size: 127 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] XEN/xen-kbdfront: Enable auto repeat for xen keyboard front driver
2017-08-21 15:41 [PATCH] XEN/xen-kbdfront: Enable auto repeat for xen keyboard front driver Liang Yan
2017-08-21 19:30 ` Boris Ostrovsky
@ 2017-08-21 19:30 ` Boris Ostrovsky
2017-08-21 20:28 ` Dmitry Torokhov
2017-08-21 20:28 ` Dmitry Torokhov
2017-08-22 1:54 ` Liang Yan
2 siblings, 2 replies; 6+ messages in thread
From: Boris Ostrovsky @ 2017-08-21 19:30 UTC (permalink / raw)
To: Liang Yan, xen-devel, Juergen Gross, linux-kernel, Dmitry Torokhov
Adding maintainer (Dmitry).
-boris
On 08/21/2017 11:41 AM, Liang Yan wrote:
> Long pressed key could not show right in XEN vncviewer after tigervnc
> client changed the way how to send repeat keys, from "Down Up Down Up
> ..." to "Down Down Dow." By enable EV_REP bit here, XEN keyboard
> device will trigger default auto repeat process from input subsystem,
> and make auto repeat keys work correctly.
>
> Signed-off-by: Liang Yan <lyan@suse.com>
> ---
> drivers/input/misc/xen-kbdfront.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/input/misc/xen-kbdfront.c
> b/drivers/input/misc/xen-kbdfront.c
> index fa130e7b734c..0dce9830e2f4 100644
> --- a/drivers/input/misc/xen-kbdfront.c
> +++ b/drivers/input/misc/xen-kbdfront.c
> @@ -248,6 +248,7 @@ static int xenkbd_probe(struct xenbus_device *dev,
> kbd->id.product = 0xffff;
>
> __set_bit(EV_KEY, kbd->evbit);
> +__set_bit(EV_REP, kbd->evbit);
> for (i = KEY_ESC; i < KEY_UNKNOWN; i++)
> __set_bit(i, kbd->keybit);
> for (i = KEY_OK; i < KEY_MAX; i++)
> --
> 2.14.0
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] XEN/xen-kbdfront: Enable auto repeat for xen keyboard front driver
2017-08-21 15:41 [PATCH] XEN/xen-kbdfront: Enable auto repeat for xen keyboard front driver Liang Yan
@ 2017-08-21 19:30 ` Boris Ostrovsky
2017-08-21 19:30 ` Boris Ostrovsky
2017-08-22 1:54 ` Liang Yan
2 siblings, 0 replies; 6+ messages in thread
From: Boris Ostrovsky @ 2017-08-21 19:30 UTC (permalink / raw)
To: Liang Yan, xen-devel, Juergen Gross, linux-kernel, Dmitry Torokhov
Adding maintainer (Dmitry).
-boris
On 08/21/2017 11:41 AM, Liang Yan wrote:
> Long pressed key could not show right in XEN vncviewer after tigervnc
> client changed the way how to send repeat keys, from "Down Up Down Up
> ..." to "Down Down Dow." By enable EV_REP bit here, XEN keyboard
> device will trigger default auto repeat process from input subsystem,
> and make auto repeat keys work correctly.
>
> Signed-off-by: Liang Yan <lyan@suse.com>
> ---
> drivers/input/misc/xen-kbdfront.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/input/misc/xen-kbdfront.c
> b/drivers/input/misc/xen-kbdfront.c
> index fa130e7b734c..0dce9830e2f4 100644
> --- a/drivers/input/misc/xen-kbdfront.c
> +++ b/drivers/input/misc/xen-kbdfront.c
> @@ -248,6 +248,7 @@ static int xenkbd_probe(struct xenbus_device *dev,
> kbd->id.product = 0xffff;
>
> __set_bit(EV_KEY, kbd->evbit);
> +__set_bit(EV_REP, kbd->evbit);
> for (i = KEY_ESC; i < KEY_UNKNOWN; i++)
> __set_bit(i, kbd->keybit);
> for (i = KEY_OK; i < KEY_MAX; i++)
> --
> 2.14.0
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] XEN/xen-kbdfront: Enable auto repeat for xen keyboard front driver
2017-08-21 19:30 ` Boris Ostrovsky
@ 2017-08-21 20:28 ` Dmitry Torokhov
2017-08-21 20:28 ` Dmitry Torokhov
1 sibling, 0 replies; 6+ messages in thread
From: Dmitry Torokhov @ 2017-08-21 20:28 UTC (permalink / raw)
To: Boris Ostrovsky; +Cc: Liang Yan, xen-devel, Juergen Gross, lkml
On Mon, Aug 21, 2017 at 12:30 PM, Boris Ostrovsky
<boris.ostrovsky@oracle.com> wrote:
>
> Adding maintainer (Dmitry).
I can't seem to find the original in my mailbox nor in patchwork. Can
you please resend?
>
>
> -boris
>
> On 08/21/2017 11:41 AM, Liang Yan wrote:
> > Long pressed key could not show right in XEN vncviewer after tigervnc
> > client changed the way how to send repeat keys, from "Down Up Down Up
> > ..." to "Down Down Dow." By enable EV_REP bit here, XEN keyboard
> > device will trigger default auto repeat process from input subsystem,
> > and make auto repeat keys work correctly.
> >
> > Signed-off-by: Liang Yan <lyan@suse.com>
> > ---
> > drivers/input/misc/xen-kbdfront.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/input/misc/xen-kbdfront.c
> > b/drivers/input/misc/xen-kbdfront.c
> > index fa130e7b734c..0dce9830e2f4 100644
> > --- a/drivers/input/misc/xen-kbdfront.c
> > +++ b/drivers/input/misc/xen-kbdfront.c
> > @@ -248,6 +248,7 @@ static int xenkbd_probe(struct xenbus_device *dev,
> > kbd->id.product = 0xffff;
> >
> > __set_bit(EV_KEY, kbd->evbit);
> > +__set_bit(EV_REP, kbd->evbit);
> > for (i = KEY_ESC; i < KEY_UNKNOWN; i++)
> > __set_bit(i, kbd->keybit);
> > for (i = KEY_OK; i < KEY_MAX; i++)
> > --
> > 2.14.0
> >
>
Thanks.
--
Dmitry
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] XEN/xen-kbdfront: Enable auto repeat for xen keyboard front driver
2017-08-21 19:30 ` Boris Ostrovsky
2017-08-21 20:28 ` Dmitry Torokhov
@ 2017-08-21 20:28 ` Dmitry Torokhov
1 sibling, 0 replies; 6+ messages in thread
From: Dmitry Torokhov @ 2017-08-21 20:28 UTC (permalink / raw)
To: Boris Ostrovsky; +Cc: Liang Yan, xen-devel, Juergen Gross, lkml
On Mon, Aug 21, 2017 at 12:30 PM, Boris Ostrovsky
<boris.ostrovsky@oracle.com> wrote:
>
> Adding maintainer (Dmitry).
I can't seem to find the original in my mailbox nor in patchwork. Can
you please resend?
>
>
> -boris
>
> On 08/21/2017 11:41 AM, Liang Yan wrote:
> > Long pressed key could not show right in XEN vncviewer after tigervnc
> > client changed the way how to send repeat keys, from "Down Up Down Up
> > ..." to "Down Down Dow." By enable EV_REP bit here, XEN keyboard
> > device will trigger default auto repeat process from input subsystem,
> > and make auto repeat keys work correctly.
> >
> > Signed-off-by: Liang Yan <lyan@suse.com>
> > ---
> > drivers/input/misc/xen-kbdfront.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/input/misc/xen-kbdfront.c
> > b/drivers/input/misc/xen-kbdfront.c
> > index fa130e7b734c..0dce9830e2f4 100644
> > --- a/drivers/input/misc/xen-kbdfront.c
> > +++ b/drivers/input/misc/xen-kbdfront.c
> > @@ -248,6 +248,7 @@ static int xenkbd_probe(struct xenbus_device *dev,
> > kbd->id.product = 0xffff;
> >
> > __set_bit(EV_KEY, kbd->evbit);
> > +__set_bit(EV_REP, kbd->evbit);
> > for (i = KEY_ESC; i < KEY_UNKNOWN; i++)
> > __set_bit(i, kbd->keybit);
> > for (i = KEY_OK; i < KEY_MAX; i++)
> > --
> > 2.14.0
> >
>
Thanks.
--
Dmitry
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] XEN/xen-kbdfront: Enable auto repeat for xen keyboard front driver
2017-08-21 15:41 [PATCH] XEN/xen-kbdfront: Enable auto repeat for xen keyboard front driver Liang Yan
2017-08-21 19:30 ` Boris Ostrovsky
2017-08-21 19:30 ` Boris Ostrovsky
@ 2017-08-22 1:54 ` Liang Yan
2 siblings, 0 replies; 6+ messages in thread
From: Liang Yan @ 2017-08-22 1:54 UTC (permalink / raw)
To: dmitry.torokhov, xen-devel, boris.ostrovsky, Juergen Gross, linux-kernel
[-- Attachment #1.1: Type: text/plain, Size: 961 bytes --]
Long pressed key could not show right in XEN vncviewer after tigervnc client changed the way how to send repeat keys, from "Down Up Down Up ..." to "Down Down ... Up". By enable EV_REP bit here, XEN keyboard device will trigger default auto repeat process from input subsystem, and make auto repeat keys work correctly.
Signed-off-by: Liang Yan <lyan@suse.com>
---
drivers/input/misc/xen-kbdfront.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/input/misc/xen-kbdfront.c b/drivers/input/misc/xen-kbdfront.c
index fa130e7b734c..0dce9830e2f4 100644
--- a/drivers/input/misc/xen-kbdfront.c
+++ b/drivers/input/misc/xen-kbdfront.c
@@ -248,6 +248,7 @@ static int xenkbd_probe(struct xenbus_device *dev,
kbd->id.product = 0xffff;
__set_bit(EV_KEY, kbd->evbit);
+ __set_bit(EV_REP, kbd->evbit);
for (i = KEY_ESC; i < KEY_UNKNOWN; i++)
__set_bit(i, kbd->keybit);
for (i = KEY_OK; i < KEY_MAX; i++)
--
2.14.0
[-- Attachment #1.2: HTML --]
[-- Type: text/html, Size: 1864 bytes --]
[-- Attachment #2: Type: text/plain, Size: 127 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-08-22 1:54 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-21 15:41 [PATCH] XEN/xen-kbdfront: Enable auto repeat for xen keyboard front driver Liang Yan
2017-08-21 19:30 ` Boris Ostrovsky
2017-08-21 19:30 ` Boris Ostrovsky
2017-08-21 20:28 ` Dmitry Torokhov
2017-08-21 20:28 ` Dmitry Torokhov
2017-08-22 1:54 ` Liang Yan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.