Re: [PATCH] kobject: fix suppressing modalias in uevents delivered over netlink

From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Casey Leedom <leedom@chelsio.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Eric Dumazet <eric.dumazet@gmail.com>,
	Eric Dumazet <edumazet@google.com>,
	Tariq Toukan <tariqt@mellanox.com>,
	"David S . Miller" <davem@davemloft.net>,
	Komali Katari <komali@chelsio.com>,
	"Luis R. Rodriguez" <mcgrof@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] kobject: fix suppressing modalias in uevents delivered over netlink
Date: Fri, 15 Dec 2017 10:53:10 -0800	[thread overview]
Message-ID: <CAKdAkRRMFVBGvXJnU0EsQV3j4WRUjPKK6vdG=w5Ft3ruHaObBw@mail.gmail.com> (raw)
In-Reply-To: <SN1PR12MB0352EE3210E82569520D8BCAC80B0@SN1PR12MB0352.namprd12.prod.outlook.com>

On Fri, Dec 15, 2017 at 10:17 AM, Casey Leedom <leedom@chelsio.com> wrote:
> Hi Dmitry,
>
>   Komali reports that she still sees the originally reported issue with your
> latest patch.  This issue started with kernel.org commit
> 1455cf8dbfd06aa7651dcfccbadb7a093944ca65 (Wed Jul 19 17:24:30 2017 -0700).
>
>   cxgb4vf is getting loaded in the Hypervisor when a cxgb4 Virtual Function
> is assigned to a Virtual Machine, and the VM is brought up.  We may need to
> do some debuging ...  How would you like to proceed?

Hmm, can she collect output of 'udevadm monitor -p' at the time you
assign the adapter to the VM? Also, do you have any udev rules that is
specific to cxgb? Or any other custom udev rules?

Also, we only suppress the modalias string on driver unbind, could it
be that for you module loading is happening when driver is bound to
the device? Actually, as far as I can see, you share PCI IDs between
cxgb4 and cxgb4vf drivers, so they have similar modalias entries. How
do you normally decide what driver is to be loaded for a given device?

Thanks.

-- 
Dmitry