From: Vincent Guittot <vincent.guittot@linaro.org> To: Ricardo Neri <ricardo.neri-calderon@linux.intel.com> Cc: "Peter Zijlstra (Intel)" <peterz@infradead.org>, Ingo Molnar <mingo@kernel.org>, Juri Lelli <juri.lelli@redhat.com>, Srikar Dronamraju <srikar@linux.vnet.ibm.com>, Nicholas Piggin <npiggin@gmail.com>, Dietmar Eggemann <dietmar.eggemann@arm.com>, Steven Rostedt <rostedt@goodmis.org>, Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>, Len Brown <len.brown@intel.com>, Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>, Tim Chen <tim.c.chen@linux.intel.com>, Aubrey Li <aubrey.li@linux.intel.com>, "Ravi V. Shankar" <ravi.v.shankar@intel.com>, Ricardo Neri <ricardo.neri@intel.com>, Quentin Perret <qperret@google.com>, "Joel Fernandes (Google)" <joel@joelfernandes.org>, linuxppc-dev@lists.ozlabs.org, linux-kernel <linux-kernel@vger.kernel.org>, Aubrey Li <aubrey.li@intel.com>, Daniel Bristot de Oliveira <bristot@redhat.com>, "Rafael J . Wysocki" <rafael.j.wysocki@intel.com> Subject: Re: [PATCH v5 3/6] sched/fair: Optimize checking for group_asym_packing Date: Fri, 17 Sep 2021 17:26:26 +0200 [thread overview] Message-ID: <CAKfTPtCHFgaWWdxSuRKPrp4cSLA+pTzXAmsGn9N3LrFn0x4B1w@mail.gmail.com> (raw) In-Reply-To: <20210911011819.12184-4-ricardo.neri-calderon@linux.intel.com> On Sat, 11 Sept 2021 at 03:19, Ricardo Neri <ricardo.neri-calderon@linux.intel.com> wrote: > > sched_asmy_prefer() always returns false when called on the local group. By > checking local_group, we can avoid additional checks and invoking > sched_asmy_prefer() when it is not needed. No functional changes are > introduced. > > Cc: Aubrey Li <aubrey.li@intel.com> > Cc: Ben Segall <bsegall@google.com> > Cc: Daniel Bristot de Oliveira <bristot@redhat.com> > Cc: Dietmar Eggemann <dietmar.eggemann@arm.com> > Cc: Mel Gorman <mgorman@suse.de> > Cc: Quentin Perret <qperret@google.com> > Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> > Cc: Steven Rostedt <rostedt@goodmis.org> > Cc: Tim Chen <tim.c.chen@linux.intel.com> > Reviewed-by: Joel Fernandes (Google) <joel@joelfernandes.org> > Reviewed-by: Len Brown <len.brown@intel.com> > Signed-off-by: Ricardo Neri <ricardo.neri-calderon@linux.intel.com> Reviewed-by: Vincent Guittot <vincent.guittot@linaro.org> > --- > Changes since v4: > * None > > Changes since v3: > * Further rewording of the commit message. (Len) > > Changes since v2: > * Reworded the commit message for clarity. (Peter Z) > > Changes since v1: > * None > --- > kernel/sched/fair.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c > index ff69f245b939..7a054f528bcc 100644 > --- a/kernel/sched/fair.c > +++ b/kernel/sched/fair.c > @@ -8657,7 +8657,7 @@ static inline void update_sg_lb_stats(struct lb_env *env, > } > > /* Check if dst CPU is idle and preferred to this group */ > - if (env->sd->flags & SD_ASYM_PACKING && > + if (!local_group && env->sd->flags & SD_ASYM_PACKING && > env->idle != CPU_NOT_IDLE && > sgs->sum_h_nr_running && > sched_asym_prefer(env->dst_cpu, group->asym_prefer_cpu)) { > -- > 2.17.1 >
WARNING: multiple messages have this Message-ID (diff)
From: Vincent Guittot <vincent.guittot@linaro.org> To: Ricardo Neri <ricardo.neri-calderon@linux.intel.com> Cc: Juri Lelli <juri.lelli@redhat.com>, Aubrey Li <aubrey.li@linux.intel.com>, Srikar Dronamraju <srikar@linux.vnet.ibm.com>, "Ravi V. Shankar" <ravi.v.shankar@intel.com>, "Peter Zijlstra \(Intel\)" <peterz@infradead.org>, Ricardo Neri <ricardo.neri@intel.com>, Ben Segall <bsegall@google.com>, Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>, "Joel Fernandes \(Google\)" <joel@joelfernandes.org>, Ingo Molnar <mingo@kernel.org>, "Rafael J . Wysocki" <rafael.j.wysocki@intel.com>, Steven Rostedt <rostedt@goodmis.org>, Mel Gorman <mgorman@suse.de>, Len Brown <len.brown@intel.com>, Nicholas Piggin <npiggin@gmail.com>, Aubrey Li <aubrey.li@intel.com>, Dietmar Eggemann <dietmar.eggemann@arm.com>, Tim Chen <tim.c.chen@linux.intel.com>, Quentin Perret <qperret@google.com>, Daniel Bristot de Oliveira <bristot@redhat.com>, linux-kernel <linux-kernel@vger.kernel.org>, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH v5 3/6] sched/fair: Optimize checking for group_asym_packing Date: Fri, 17 Sep 2021 17:26:26 +0200 [thread overview] Message-ID: <CAKfTPtCHFgaWWdxSuRKPrp4cSLA+pTzXAmsGn9N3LrFn0x4B1w@mail.gmail.com> (raw) In-Reply-To: <20210911011819.12184-4-ricardo.neri-calderon@linux.intel.com> On Sat, 11 Sept 2021 at 03:19, Ricardo Neri <ricardo.neri-calderon@linux.intel.com> wrote: > > sched_asmy_prefer() always returns false when called on the local group. By > checking local_group, we can avoid additional checks and invoking > sched_asmy_prefer() when it is not needed. No functional changes are > introduced. > > Cc: Aubrey Li <aubrey.li@intel.com> > Cc: Ben Segall <bsegall@google.com> > Cc: Daniel Bristot de Oliveira <bristot@redhat.com> > Cc: Dietmar Eggemann <dietmar.eggemann@arm.com> > Cc: Mel Gorman <mgorman@suse.de> > Cc: Quentin Perret <qperret@google.com> > Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> > Cc: Steven Rostedt <rostedt@goodmis.org> > Cc: Tim Chen <tim.c.chen@linux.intel.com> > Reviewed-by: Joel Fernandes (Google) <joel@joelfernandes.org> > Reviewed-by: Len Brown <len.brown@intel.com> > Signed-off-by: Ricardo Neri <ricardo.neri-calderon@linux.intel.com> Reviewed-by: Vincent Guittot <vincent.guittot@linaro.org> > --- > Changes since v4: > * None > > Changes since v3: > * Further rewording of the commit message. (Len) > > Changes since v2: > * Reworded the commit message for clarity. (Peter Z) > > Changes since v1: > * None > --- > kernel/sched/fair.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c > index ff69f245b939..7a054f528bcc 100644 > --- a/kernel/sched/fair.c > +++ b/kernel/sched/fair.c > @@ -8657,7 +8657,7 @@ static inline void update_sg_lb_stats(struct lb_env *env, > } > > /* Check if dst CPU is idle and preferred to this group */ > - if (env->sd->flags & SD_ASYM_PACKING && > + if (!local_group && env->sd->flags & SD_ASYM_PACKING && > env->idle != CPU_NOT_IDLE && > sgs->sum_h_nr_running && > sched_asym_prefer(env->dst_cpu, group->asym_prefer_cpu)) { > -- > 2.17.1 >
next prev parent reply other threads:[~2021-09-17 15:26 UTC|newest] Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-09-11 1:18 [PATCH v5 0/6] sched/fair: Fix load balancing of SMT siblings with ASYM_PACKING Ricardo Neri 2021-09-11 1:18 ` Ricardo Neri 2021-09-11 1:18 ` [PATCH v5 1/6] x86/sched: Decrease further the priorities of SMT siblings Ricardo Neri 2021-09-11 1:18 ` Ricardo Neri 2021-09-21 7:27 ` [tip: sched/core] " tip-bot2 for Ricardo Neri 2021-10-05 14:12 ` tip-bot2 for Ricardo Neri 2021-09-11 1:18 ` [PATCH v5 2/6] sched/topology: Introduce sched_group::flags Ricardo Neri 2021-09-11 1:18 ` Ricardo Neri 2021-09-17 15:26 ` Vincent Guittot 2021-09-17 15:26 ` Vincent Guittot 2021-09-21 7:27 ` [tip: sched/core] " tip-bot2 for Ricardo Neri 2021-10-05 14:12 ` tip-bot2 for Ricardo Neri 2023-05-23 10:59 ` Peter Zijlstra 2023-05-24 13:02 ` Vincent Guittot 2021-09-11 1:18 ` [PATCH v5 3/6] sched/fair: Optimize checking for group_asym_packing Ricardo Neri 2021-09-11 1:18 ` Ricardo Neri 2021-09-17 15:26 ` Vincent Guittot [this message] 2021-09-17 15:26 ` Vincent Guittot 2021-09-21 7:27 ` [tip: sched/core] " tip-bot2 for Ricardo Neri 2021-10-05 14:12 ` tip-bot2 for Ricardo Neri 2021-09-11 1:18 ` [PATCH v5 4/6] sched/fair: Provide update_sg_lb_stats() with sched domain statistics Ricardo Neri 2021-09-11 1:18 ` Ricardo Neri 2021-09-17 15:27 ` Vincent Guittot 2021-09-17 15:27 ` Vincent Guittot 2021-09-21 7:27 ` [tip: sched/core] " tip-bot2 for Ricardo Neri 2021-10-05 14:12 ` tip-bot2 for Ricardo Neri 2021-09-11 1:18 ` [PATCH v5 5/6] sched/fair: Carve out logic to mark a group for asymmetric packing Ricardo Neri 2021-09-11 1:18 ` Ricardo Neri 2021-09-17 15:27 ` Vincent Guittot 2021-09-17 15:27 ` Vincent Guittot 2021-09-21 7:27 ` [tip: sched/core] " tip-bot2 for Ricardo Neri 2021-10-05 14:12 ` tip-bot2 for Ricardo Neri 2021-09-11 1:18 ` [PATCH v5 6/6] sched/fair: Consider SMT in ASYM_PACKING load balance Ricardo Neri 2021-09-11 1:18 ` Ricardo Neri 2021-09-15 15:43 ` Vincent Guittot 2021-09-15 15:43 ` Vincent Guittot 2021-09-17 1:00 ` Ricardo Neri 2021-09-17 1:00 ` Ricardo Neri 2021-09-17 7:41 ` Vincent Guittot 2021-09-17 7:41 ` Vincent Guittot 2021-09-17 15:25 ` Vincent Guittot 2021-09-17 15:25 ` Vincent Guittot 2021-09-17 18:46 ` Peter Zijlstra 2021-09-17 18:46 ` Peter Zijlstra 2021-09-18 9:33 ` Vincent Guittot 2021-09-18 9:33 ` Vincent Guittot 2021-09-21 7:27 ` [tip: sched/core] " tip-bot2 for Ricardo Neri 2021-10-01 9:33 ` [PATCH v5 6/6] " Guillaume Tucker 2021-10-01 9:33 ` Guillaume Tucker 2021-10-01 9:40 ` Guillaume Tucker 2021-10-01 9:40 ` Guillaume Tucker 2021-10-01 10:25 ` Vincent Guittot 2021-10-01 10:25 ` Vincent Guittot 2021-10-01 17:43 ` Ricardo Neri 2021-10-01 17:43 ` Ricardo Neri 2021-10-05 14:12 ` [tip: sched/core] " tip-bot2 for Ricardo Neri
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAKfTPtCHFgaWWdxSuRKPrp4cSLA+pTzXAmsGn9N3LrFn0x4B1w@mail.gmail.com \ --to=vincent.guittot@linaro.org \ --cc=aubrey.li@intel.com \ --cc=aubrey.li@linux.intel.com \ --cc=bristot@redhat.com \ --cc=bsegall@google.com \ --cc=dietmar.eggemann@arm.com \ --cc=joel@joelfernandes.org \ --cc=juri.lelli@redhat.com \ --cc=len.brown@intel.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=mgorman@suse.de \ --cc=mingo@kernel.org \ --cc=npiggin@gmail.com \ --cc=peterz@infradead.org \ --cc=qperret@google.com \ --cc=rafael.j.wysocki@intel.com \ --cc=ravi.v.shankar@intel.com \ --cc=ricardo.neri-calderon@linux.intel.com \ --cc=ricardo.neri@intel.com \ --cc=rostedt@goodmis.org \ --cc=srikar@linux.vnet.ibm.com \ --cc=srinivas.pandruvada@linux.intel.com \ --cc=tim.c.chen@linux.intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.