From: Alexander Duyck <alexander.duyck@gmail.com> To: Vinicius Costa Gomes <vinicius.gomes@intel.com> Cc: intel-wired-lan <intel-wired-lan@lists.osuosl.org>, Netdev <netdev@vger.kernel.org>, Jesus Sanchez-Palencia <jesus.sanchez-palencia@intel.com> Subject: Re: [Intel-wired-lan] [next-queue PATCH 3/8] igb: Enable the hardware traffic class feature bit for igb models Date: Sun, 25 Feb 2018 14:37:28 -0800 [thread overview] Message-ID: <CAKgT0Ufuyf1_9RZe2yqSC404p-i3VpRAqP-2w0mUysCJGq5NKA@mail.gmail.com> (raw) In-Reply-To: <20180224012036.5834-4-vinicius.gomes@intel.com> On Fri, Feb 23, 2018 at 5:20 PM, Vinicius Costa Gomes <vinicius.gomes@intel.com> wrote: > This will allow functionality depending on the hardware being traffic > class aware to work. In particular the tc-flower offloading checks > verifies that this bit is set. > > Signed-off-by: Vinicius Costa Gomes <vinicius.gomes@intel.com> > --- > drivers/net/ethernet/intel/igb/igb_main.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c > index 0ea32be07d71..543aa99892eb 100644 > --- a/drivers/net/ethernet/intel/igb/igb_main.c > +++ b/drivers/net/ethernet/intel/igb/igb_main.c > @@ -2820,8 +2820,10 @@ static int igb_probe(struct pci_dev *pdev, const struct pci_device_id *ent) > NETIF_F_HW_VLAN_CTAG_TX | > NETIF_F_RXALL; > > - if (hw->mac.type >= e1000_i350) > - netdev->hw_features |= NETIF_F_NTUPLE; > + if (hw->mac.type >= e1000_i350) { > + netdev->hw_features |= (NETIF_F_NTUPLE | NETIF_F_HW_TC); > + netdev->features |= NETIF_F_HW_TC; The parens aren't needed. Also you might consider moving this block up to where we have a similar one for 82576. Then you wouldn't need to set both features and hw_features in the case of the HW_TC flag. > + } > > if (pci_using_dac) > netdev->features |= NETIF_F_HIGHDMA; > -- > 2.16.2 > > _______________________________________________ > Intel-wired-lan mailing list > Intel-wired-lan@osuosl.org > https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
WARNING: multiple messages have this Message-ID (diff)
From: Alexander Duyck <alexander.duyck@gmail.com> To: intel-wired-lan@osuosl.org Subject: [Intel-wired-lan] [next-queue PATCH 3/8] igb: Enable the hardware traffic class feature bit for igb models Date: Sun, 25 Feb 2018 14:37:28 -0800 [thread overview] Message-ID: <CAKgT0Ufuyf1_9RZe2yqSC404p-i3VpRAqP-2w0mUysCJGq5NKA@mail.gmail.com> (raw) In-Reply-To: <20180224012036.5834-4-vinicius.gomes@intel.com> On Fri, Feb 23, 2018 at 5:20 PM, Vinicius Costa Gomes <vinicius.gomes@intel.com> wrote: > This will allow functionality depending on the hardware being traffic > class aware to work. In particular the tc-flower offloading checks > verifies that this bit is set. > > Signed-off-by: Vinicius Costa Gomes <vinicius.gomes@intel.com> > --- > drivers/net/ethernet/intel/igb/igb_main.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c > index 0ea32be07d71..543aa99892eb 100644 > --- a/drivers/net/ethernet/intel/igb/igb_main.c > +++ b/drivers/net/ethernet/intel/igb/igb_main.c > @@ -2820,8 +2820,10 @@ static int igb_probe(struct pci_dev *pdev, const struct pci_device_id *ent) > NETIF_F_HW_VLAN_CTAG_TX | > NETIF_F_RXALL; > > - if (hw->mac.type >= e1000_i350) > - netdev->hw_features |= NETIF_F_NTUPLE; > + if (hw->mac.type >= e1000_i350) { > + netdev->hw_features |= (NETIF_F_NTUPLE | NETIF_F_HW_TC); > + netdev->features |= NETIF_F_HW_TC; The parens aren't needed. Also you might consider moving this block up to where we have a similar one for 82576. Then you wouldn't need to set both features and hw_features in the case of the HW_TC flag. > + } > > if (pci_using_dac) > netdev->features |= NETIF_F_HIGHDMA; > -- > 2.16.2 > > _______________________________________________ > Intel-wired-lan mailing list > Intel-wired-lan at osuosl.org > https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
next prev parent reply other threads:[~2018-02-25 22:37 UTC|newest] Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-02-24 1:20 [next-queue PATCH 0/8] igb: offloading of receive filters Vinicius Costa Gomes 2018-02-24 1:20 ` [Intel-wired-lan] " Vinicius Costa Gomes 2018-02-24 1:20 ` [next-queue PATCH 1/8] igb: Fix not adding filter elements to the list Vinicius Costa Gomes 2018-02-24 1:20 ` [Intel-wired-lan] " Vinicius Costa Gomes 2018-02-24 1:20 ` [next-queue PATCH 2/8] igb: Fix queue selection on MAC filters on i210 and i211 Vinicius Costa Gomes 2018-02-24 1:20 ` [Intel-wired-lan] " Vinicius Costa Gomes 2018-02-24 1:20 ` [next-queue PATCH 3/8] igb: Enable the hardware traffic class feature bit for igb models Vinicius Costa Gomes 2018-02-24 1:20 ` [Intel-wired-lan] " Vinicius Costa Gomes 2018-02-25 22:37 ` Alexander Duyck [this message] 2018-02-25 22:37 ` Alexander Duyck 2018-02-26 18:49 ` Vinicius Costa Gomes 2018-02-26 18:49 ` Vinicius Costa Gomes 2018-02-24 1:20 ` [next-queue PATCH 4/8] igb: Add support for MAC address filters specifying source addresses Vinicius Costa Gomes 2018-02-24 1:20 ` [Intel-wired-lan] " Vinicius Costa Gomes 2018-02-25 22:42 ` Alexander Duyck 2018-02-25 22:42 ` Alexander Duyck 2018-02-26 19:24 ` Vinicius Costa Gomes 2018-02-26 19:24 ` Vinicius Costa Gomes 2018-02-24 1:20 ` [next-queue PATCH 5/8] igb: Add support for ethtool MAC address filters Vinicius Costa Gomes 2018-02-24 1:20 ` [Intel-wired-lan] " Vinicius Costa Gomes 2018-02-24 4:38 ` Florian Fainelli 2018-02-24 4:38 ` [Intel-wired-lan] " Florian Fainelli 2018-02-26 19:30 ` Vinicius Costa Gomes 2018-02-26 19:30 ` [Intel-wired-lan] " Vinicius Costa Gomes 2018-02-24 1:20 ` [next-queue PATCH 6/8] igb: Add the skeletons for tc-flower offloading Vinicius Costa Gomes 2018-02-24 1:20 ` [Intel-wired-lan] " Vinicius Costa Gomes 2018-02-24 1:20 ` [next-queue PATCH 7/8] igb: Add support for adding offloaded clsflower filters Vinicius Costa Gomes 2018-02-24 1:20 ` [Intel-wired-lan] " Vinicius Costa Gomes 2018-02-24 4:45 ` Florian Fainelli 2018-02-24 4:45 ` [Intel-wired-lan] " Florian Fainelli 2018-02-27 0:40 ` Vinicius Costa Gomes 2018-02-27 0:40 ` [Intel-wired-lan] " Vinicius Costa Gomes 2018-02-27 0:51 ` Florian Fainelli 2018-02-27 0:51 ` [Intel-wired-lan] " Florian Fainelli 2018-02-27 1:51 ` Vinicius Costa Gomes 2018-02-27 1:51 ` [Intel-wired-lan] " Vinicius Costa Gomes 2018-02-26 0:12 ` kbuild test robot 2018-02-26 0:12 ` kbuild test robot 2018-02-24 1:20 ` [next-queue PATCH 8/8] igb: Add support for removing offloaded tc-flower filters Vinicius Costa Gomes 2018-02-24 1:20 ` [Intel-wired-lan] " Vinicius Costa Gomes 2018-02-24 4:36 ` Florian Fainelli 2018-02-24 4:36 ` [Intel-wired-lan] " Florian Fainelli 2018-02-26 20:59 ` Vinicius Costa Gomes 2018-02-26 20:59 ` [Intel-wired-lan] " Vinicius Costa Gomes
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAKgT0Ufuyf1_9RZe2yqSC404p-i3VpRAqP-2w0mUysCJGq5NKA@mail.gmail.com \ --to=alexander.duyck@gmail.com \ --cc=intel-wired-lan@lists.osuosl.org \ --cc=jesus.sanchez-palencia@intel.com \ --cc=netdev@vger.kernel.org \ --cc=vinicius.gomes@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.