Patch for custom imager plugin in wic.

Patch for custom imager plugin in wic.

[Paul Knopf]

[-- Attachment #1: Type: text/plain, Size: 1524 bytes --]

From 136d6214b6fc2c1118dac5b7f3e029ed006fab8a Mon Sep 17 00:00:00 2001
From: Paul Knopf <pauldotknopf@gmail.com>
Date: Mon, 21 May 2018 16:56:51 -0400
Subject: [PATCH] Support for changing the imager used in wic.

---
 scripts/lib/wic/engine.py | 2 +-
 scripts/wic               | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/scripts/lib/wic/engine.py b/scripts/lib/wic/engine.py
index edcfab3..d7c5c11 100644
--- a/scripts/lib/wic/engine.py
+++ b/scripts/lib/wic/engine.py
@@ -191,7 +191,7 @@ def wic_create(wks_file, rootfs_dir, bootimg_dir,
kernel_dir,
     if not os.path.exists(options.outdir):
         os.makedirs(options.outdir)

-    pname = 'direct'
+    pname = options.imager
     plugin_class = PluginMgr.get_plugins('imager').get(pname)
     if not plugin_class:
         raise WicError('Unknown plugin: %s' % pname)
diff --git a/scripts/wic b/scripts/wic
index 7392bc4..255e524 100755
--- a/scripts/wic
+++ b/scripts/wic
@@ -360,6 +360,7 @@ def wic_init_parser_create(subparser):
     subparser.add_argument("-v", "--vars", dest='vars_dir',
                       help="directory with <image>.env files that store "
                            "bitbake variables")
+    subparser.add_argument("-i", "--imager", dest="imager",
default="direct", help="the wic imager plugin")
     subparser.add_argument("-D", "--debug", dest="debug",
action="store_true",
                       default=False, help="output debug information")
     return
-- 
2.7.4

[-- Attachment #2: Type: text/html, Size: 2213 bytes --]

Re: Patch for custom imager plugin in wic.

[Paul Knopf]

[-- Attachment #1: Type: text/plain, Size: 1727 bytes --]

Can this change be merged into master?

On Mon, May 21, 2018 at 5:00 PM, Paul Knopf <pauldotknopf@gmail.com> wrote:

> From 136d6214b6fc2c1118dac5b7f3e029ed006fab8a Mon Sep 17 00:00:00 2001
> From: Paul Knopf <pauldotknopf@gmail.com>
> Date: Mon, 21 May 2018 16:56:51 -0400
> Subject: [PATCH] Support for changing the imager used in wic.
>
> ---
>  scripts/lib/wic/engine.py | 2 +-
>  scripts/wic               | 1 +
>  2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/scripts/lib/wic/engine.py b/scripts/lib/wic/engine.py
> index edcfab3..d7c5c11 100644
> --- a/scripts/lib/wic/engine.py
> +++ b/scripts/lib/wic/engine.py
> @@ -191,7 +191,7 @@ def wic_create(wks_file, rootfs_dir, bootimg_dir,
> kernel_dir,
>      if not os.path.exists(options.outdir):
>          os.makedirs(options.outdir)
>
> -    pname = 'direct'
> +    pname = options.imager
>      plugin_class = PluginMgr.get_plugins('imager').get(pname)
>      if not plugin_class:
>          raise WicError('Unknown plugin: %s' % pname)
> diff --git a/scripts/wic b/scripts/wic
> index 7392bc4..255e524 100755
> --- a/scripts/wic
> +++ b/scripts/wic
> @@ -360,6 +360,7 @@ def wic_init_parser_create(subparser):
>      subparser.add_argument("-v", "--vars", dest='vars_dir',
>                        help="directory with <image>.env files that store "
>                             "bitbake variables")
> +    subparser.add_argument("-i", "--imager", dest="imager",
> default="direct", help="the wic imager plugin")
>      subparser.add_argument("-D", "--debug", dest="debug",
> action="store_true",
>                        default=False, help="output debug information")
>      return
> --
> 2.7.4
>
>

[-- Attachment #2: Type: text/html, Size: 2720 bytes --]

Re: Patch for custom imager plugin in wic.

[Paul Knopf]

[-- Attachment #1: Type: text/plain, Size: 1931 bytes --]

Can someone instruct me on the proper protocol to request a change?

On Wed, May 23, 2018 at 1:37 PM, Paul Knopf <pauldotknopf@gmail.com> wrote:

> Can this change be merged into master?
>
> On Mon, May 21, 2018 at 5:00 PM, Paul Knopf <pauldotknopf@gmail.com>
> wrote:
>
>> From 136d6214b6fc2c1118dac5b7f3e029ed006fab8a Mon Sep 17 00:00:00 2001
>> From: Paul Knopf <pauldotknopf@gmail.com>
>> Date: Mon, 21 May 2018 16:56:51 -0400
>> Subject: [PATCH] Support for changing the imager used in wic.
>>
>> ---
>>  scripts/lib/wic/engine.py | 2 +-
>>  scripts/wic               | 1 +
>>  2 files changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/scripts/lib/wic/engine.py b/scripts/lib/wic/engine.py
>> index edcfab3..d7c5c11 100644
>> --- a/scripts/lib/wic/engine.py
>> +++ b/scripts/lib/wic/engine.py
>> @@ -191,7 +191,7 @@ def wic_create(wks_file, rootfs_dir, bootimg_dir,
>> kernel_dir,
>>      if not os.path.exists(options.outdir):
>>          os.makedirs(options.outdir)
>>
>> -    pname = 'direct'
>> +    pname = options.imager
>>      plugin_class = PluginMgr.get_plugins('imager').get(pname)
>>      if not plugin_class:
>>          raise WicError('Unknown plugin: %s' % pname)
>> diff --git a/scripts/wic b/scripts/wic
>> index 7392bc4..255e524 100755
>> --- a/scripts/wic
>> +++ b/scripts/wic
>> @@ -360,6 +360,7 @@ def wic_init_parser_create(subparser):
>>      subparser.add_argument("-v", "--vars", dest='vars_dir',
>>                        help="directory with <image>.env files that store "
>>                             "bitbake variables")
>> +    subparser.add_argument("-i", "--imager", dest="imager",
>> default="direct", help="the wic imager plugin")
>>      subparser.add_argument("-D", "--debug", dest="debug",
>> action="store_true",
>>                        default=False, help="output debug information")
>>      return
>> --
>> 2.7.4
>>
>>
>

[-- Attachment #2: Type: text/html, Size: 3232 bytes --]

Re: Patch for custom imager plugin in wic.

[Paul Knopf]

[-- Attachment #1: Type: text/plain, Size: 2112 bytes --]

Can anybody see this message? lol

On Tue, Jun 5, 2018 at 10:05 AM, Paul Knopf <pauldotknopf@gmail.com> wrote:

> Can someone instruct me on the proper protocol to request a change?
>
> On Wed, May 23, 2018 at 1:37 PM, Paul Knopf <pauldotknopf@gmail.com>
> wrote:
>
>> Can this change be merged into master?
>>
>> On Mon, May 21, 2018 at 5:00 PM, Paul Knopf <pauldotknopf@gmail.com>
>> wrote:
>>
>>> From 136d6214b6fc2c1118dac5b7f3e029ed006fab8a Mon Sep 17 00:00:00 2001
>>> From: Paul Knopf <pauldotknopf@gmail.com>
>>> Date: Mon, 21 May 2018 16:56:51 -0400
>>> Subject: [PATCH] Support for changing the imager used in wic.
>>>
>>> ---
>>>  scripts/lib/wic/engine.py | 2 +-
>>>  scripts/wic               | 1 +
>>>  2 files changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/scripts/lib/wic/engine.py b/scripts/lib/wic/engine.py
>>> index edcfab3..d7c5c11 100644
>>> --- a/scripts/lib/wic/engine.py
>>> +++ b/scripts/lib/wic/engine.py
>>> @@ -191,7 +191,7 @@ def wic_create(wks_file, rootfs_dir, bootimg_dir,
>>> kernel_dir,
>>>      if not os.path.exists(options.outdir):
>>>          os.makedirs(options.outdir)
>>>
>>> -    pname = 'direct'
>>> +    pname = options.imager
>>>      plugin_class = PluginMgr.get_plugins('imager').get(pname)
>>>      if not plugin_class:
>>>          raise WicError('Unknown plugin: %s' % pname)
>>> diff --git a/scripts/wic b/scripts/wic
>>> index 7392bc4..255e524 100755
>>> --- a/scripts/wic
>>> +++ b/scripts/wic
>>> @@ -360,6 +360,7 @@ def wic_init_parser_create(subparser):
>>>      subparser.add_argument("-v", "--vars", dest='vars_dir',
>>>                        help="directory with <image>.env files that store
>>> "
>>>                             "bitbake variables")
>>> +    subparser.add_argument("-i", "--imager", dest="imager",
>>> default="direct", help="the wic imager plugin")
>>>      subparser.add_argument("-D", "--debug", dest="debug",
>>> action="store_true",
>>>                        default=False, help="output debug information")
>>>      return
>>> --
>>> 2.7.4
>>>
>>>
>>
>

[-- Attachment #2: Type: text/html, Size: 3752 bytes --]

Re: Patch for custom imager plugin in wic.

[Anuj Mittal]

On 06/13/2018 02:47 AM, Paul Knopf wrote:
> From 136d6214b6fc2c1118dac5b7f3e029ed006fab8a Mon Sep 17 00:00:00 2001
> From: Paul Knopf <pauldotknopf@gmail.com <mailto:pauldotknopf@gmail.com>>
> Date: Mon, 21 May 2018 16:56:51 -0400
> Subject: [PATCH] Support for changing the imager used in wic.
> 
> ---
>  scripts/lib/wic/engine.py | 2 +-
>  scripts/wic               | 1 +
>  2 files changed, 2 insertions(+), 1 deletion(-)

Patches to OE-core should be sent to
openembedded-core@lists.openembedded.org. Are you using a custom imager
plugin?