All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alistair Francis <alistair23@gmail.com>
To: Bin Meng <bmeng.cn@gmail.com>
Cc: "open list:RISC-V" <qemu-riscv@nongnu.org>,
	"Alistair Francis" <Alistair.Francis@wdc.com>,
	"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>
Subject: Re: [PATCH 2/3] hw/char: shakti_uart: Register device in 'input' category
Date: Tue, 28 Sep 2021 16:54:06 +1000	[thread overview]
Message-ID: <CAKmqyKM_kDHkpHqM3662rZhz+yy8Ef3wADzO6f7r84dEA=62NQ@mail.gmail.com> (raw)
In-Reply-To: <20210926105003.2716-2-bmeng.cn@gmail.com>

On Sun, Sep 26, 2021 at 8:56 PM Bin Meng <bmeng.cn@gmail.com> wrote:
>
> The category of shakti_uart device is not set. Put it into the
> 'input' category.
>
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>

Reviewed-by: Alistair Francis <alistair.francis@wdc.com>

Alistair

> ---
>
>  hw/char/shakti_uart.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/hw/char/shakti_uart.c b/hw/char/shakti_uart.c
> index 6870821325..98b142c7df 100644
> --- a/hw/char/shakti_uart.c
> +++ b/hw/char/shakti_uart.c
> @@ -168,6 +168,7 @@ static void shakti_uart_class_init(ObjectClass *klass, void *data)
>      dc->reset = shakti_uart_reset;
>      dc->realize = shakti_uart_realize;
>      device_class_set_props(dc, shakti_uart_properties);
> +    set_bit(DEVICE_CATEGORY_INPUT, dc->categories);
>  }
>
>  static const TypeInfo shakti_uart_info = {
> --
> 2.25.1
>
>


WARNING: multiple messages have this Message-ID (diff)
From: Alistair Francis <alistair23@gmail.com>
To: Bin Meng <bmeng.cn@gmail.com>
Cc: "Alistair Francis" <Alistair.Francis@wdc.com>,
	"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>,
	"open list:RISC-V" <qemu-riscv@nongnu.org>,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>
Subject: Re: [PATCH 2/3] hw/char: shakti_uart: Register device in 'input' category
Date: Tue, 28 Sep 2021 16:54:06 +1000	[thread overview]
Message-ID: <CAKmqyKM_kDHkpHqM3662rZhz+yy8Ef3wADzO6f7r84dEA=62NQ@mail.gmail.com> (raw)
In-Reply-To: <20210926105003.2716-2-bmeng.cn@gmail.com>

On Sun, Sep 26, 2021 at 8:56 PM Bin Meng <bmeng.cn@gmail.com> wrote:
>
> The category of shakti_uart device is not set. Put it into the
> 'input' category.
>
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>

Reviewed-by: Alistair Francis <alistair.francis@wdc.com>

Alistair

> ---
>
>  hw/char/shakti_uart.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/hw/char/shakti_uart.c b/hw/char/shakti_uart.c
> index 6870821325..98b142c7df 100644
> --- a/hw/char/shakti_uart.c
> +++ b/hw/char/shakti_uart.c
> @@ -168,6 +168,7 @@ static void shakti_uart_class_init(ObjectClass *klass, void *data)
>      dc->reset = shakti_uart_reset;
>      dc->realize = shakti_uart_realize;
>      device_class_set_props(dc, shakti_uart_properties);
> +    set_bit(DEVICE_CATEGORY_INPUT, dc->categories);
>  }
>
>  static const TypeInfo shakti_uart_info = {
> --
> 2.25.1
>
>


  parent reply	other threads:[~2021-09-28  6:56 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-26 10:50 [PATCH 1/3] hw/char: ibex_uart: Register device in 'input' category Bin Meng
2021-09-26 10:50 ` [PATCH 2/3] hw/char: shakti_uart: " Bin Meng
2021-09-26 14:40   ` Philippe Mathieu-Daudé
2021-09-28  6:54   ` Alistair Francis [this message]
2021-09-28  6:54     ` Alistair Francis
2021-09-26 10:50 ` [PATCH 3/3] hw/char: sifive_uart: " Bin Meng
2021-09-26 14:40   ` Philippe Mathieu-Daudé
2021-09-28  6:54   ` Alistair Francis
2021-09-28  6:54     ` Alistair Francis
2021-09-28  9:18   ` Alistair Francis
2021-09-28  9:18     ` Alistair Francis
2021-09-26 14:40 ` [PATCH 1/3] hw/char: ibex_uart: " Philippe Mathieu-Daudé
2021-09-28  6:52 ` Alistair Francis
2021-09-28  6:52   ` Alistair Francis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKmqyKM_kDHkpHqM3662rZhz+yy8Ef3wADzO6f7r84dEA=62NQ@mail.gmail.com' \
    --to=alistair23@gmail.com \
    --cc=Alistair.Francis@wdc.com \
    --cc=bmeng.cn@gmail.com \
    --cc=f4bug@amsat.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-riscv@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.