All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alistair Francis <alistair23@gmail.com>
To: LIU Zhiwei <zhiwei_liu@c-sky.com>
Cc: Kito Cheng <kito.cheng@sifive.com>,
	"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>,
	Bug 1923629 <1923629@bugs.launchpad.net>
Subject: Re: [Bug 1923629] [NEW] RISC-V Vector Instruction vssub.vv not saturating
Date: Thu, 15 Apr 2021 14:42:29 +1000	[thread overview]
Message-ID: <CAKmqyKMsnAYFx5FDtO3kghtv96RQMFGzvaDgpzjGpo9Zu32Gnw@mail.gmail.com> (raw)
In-Reply-To: <d8a3da4f-69d5-d254-497b-c2a0397db029@c-sky.com>

On Thu, Apr 15, 2021 at 2:18 PM LIU Zhiwei <zhiwei_liu@c-sky.com> wrote:
>
> Hi Alistair,
>
> I think that this bug has been resolved in my packed-extension patch set[1].
>
> Would you mind to have a test and merge it before the whole patch set?

Great! Thanks

I have applied patch 3 for the next PR.

Alistair

>
> Thanks.
>
>
> Best Regards,
>
> Zhiwei
>
> [1]: https://www.mail-archive.com/qemu-devel@nongnu.org/msg782125.html
>
>
>
> On 2021/4/15 上午11:57, Alistair Francis wrote:
> > + LIU Zhiwei and Kito Cheng
> >
> > Alistair
> >
> > On Wed, Apr 14, 2021 at 1:31 AM Tony Cole <1923629@bugs.launchpad.net> wrote:
> >> Public bug reported:
> >>
> >> I noticed doing a negate ( 0 – 0x80000000 ) using vssub.vv produces an
> >> incorrect result of 0x80000000 (should saturate to 0x7FFFFFFF).
> >>
> >> Here is the bit of the code:
> >>
> >>                  vmv.v.i         v16, 0
> >>                  …
> >> 8f040457        vssub.vv        v8,v16,v8
> >>
> >> I believe the instruction encoding is correct (vssub.vv with vd = v8,
> >> vs2 = v16, rs1 = v8), but the result does not saturate in QEMU.
> >>
> >> I’ve just tested with what I think is the latest branch (
> >> https://github.com/sifive/qemu/tree/rvv-1.0-upstream-v7 commit 26 Feb
> >> 2021: 1151361fa7d45cc90d69086ccf1a4d8397931811 ) and the problem still
> >> exists.
> >>
> >> ** Affects: qemu
> >>       Importance: Undecided
> >>           Status: New
> >>
> >>
> >> ** Tags: riscv vector
> >>
> >> --
> >> You received this bug notification because you are a member of qemu-
> >> devel-ml, which is subscribed to QEMU.
> >> https://bugs.launchpad.net/bugs/1923629
> >>
> >> Title:
> >>    RISC-V Vector Instruction vssub.vv not saturating
> >>
> >> Status in QEMU:
> >>    New
> >>
> >> Bug description:
> >>    I noticed doing a negate ( 0 – 0x80000000 ) using vssub.vv produces an
> >>    incorrect result of 0x80000000 (should saturate to 0x7FFFFFFF).
> >>
> >>    Here is the bit of the code:
> >>
> >>                  vmv.v.i         v16, 0
> >>                  …
> >>    8f040457      vssub.vv        v8,v16,v8
> >>
> >>    I believe the instruction encoding is correct (vssub.vv with vd = v8,
> >>    vs2 = v16, rs1 = v8), but the result does not saturate in QEMU.
> >>
> >>    I’ve just tested with what I think is the latest branch (
> >>    https://github.com/sifive/qemu/tree/rvv-1.0-upstream-v7 commit 26 Feb
> >>    2021: 1151361fa7d45cc90d69086ccf1a4d8397931811 ) and the problem still
> >>    exists.
> >>
> >> To manage notifications about this bug go to:
> >> https://bugs.launchpad.net/qemu/+bug/1923629/+subscriptions
> >>


  reply	other threads:[~2021-04-15  4:43 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-13 15:21 [Bug 1923629] [NEW] RISC-V Vector Instruction vssub.vv not saturating Tony Cole
2021-04-15  3:57 ` Alistair Francis
2021-04-15  4:00   ` Kito Cheng
2021-04-15  4:18   ` LIU Zhiwei
2021-04-15  4:42     ` Alistair Francis [this message]
2021-04-15  4:42 ` [Bug 1923629] " Alistair Francis
2021-04-15  7:31 ` Frank Chang
2021-05-12 23:58 ` Alistair Francis
2021-08-25  7:18 ` Thomas Huth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKmqyKMsnAYFx5FDtO3kghtv96RQMFGzvaDgpzjGpo9Zu32Gnw@mail.gmail.com \
    --to=alistair23@gmail.com \
    --cc=1923629@bugs.launchpad.net \
    --cc=kito.cheng@sifive.com \
    --cc=qemu-devel@nongnu.org \
    --cc=zhiwei_liu@c-sky.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.