All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alistair Francis <alistair23@gmail.com>
To: Julien Grall <julien.grall@arm.com>
Cc: Alistair Francis <alistair.francis@wdc.com>,
	Wei Liu <wei.liu2@citrix.com>,
	Ian Jackson <Ian.Jackson@eu.citrix.com>,
	Jan Beulich <JBeulich@suse.com>,
	xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH 2/3] xen/drivers/char: Don't require vpl011 for all non-x86 archs
Date: Fri, 17 May 2019 15:01:01 -0700	[thread overview]
Message-ID: <CAKmqyKN=HCwitx7StNKLmNhjVeXq0cEawyi+j9VJf5dkhfi=jQ@mail.gmail.com> (raw)
In-Reply-To: <b3621bcf-89d0-22a0-2416-4cf5a341d13a@arm.com>

On Fri, May 17, 2019 at 1:46 AM Julien Grall <julien.grall@arm.com> wrote:
>
>
>
> On 16/05/2019 20:30, Alistair Francis wrote:
> > On Thu, May 16, 2019 at 3:32 AM Jan Beulich <JBeulich@suse.com> wrote:
> >>
> >>>>> On 16.05.19 at 02:02, <alistair.francis@wdc.com> wrote:
> >>> Make the asm/vpl011.h dependent on the ARM architecture.
> >>
> >> But we only have x86 and Arm right now. A word more about
> >> your motivation would help.
> >
> > As the code currently is no one can add another architecture. This is
> > just a general fixup as assuming Xen will only ever support two archs
> > seems strange.
>
> At which point, wouldn't it be better to avoid #ifdef ARCH in common code?
> Instead, we could provide arch helper and/or more meaning CONFIG name.

I'm not sure if the arch helpers are any easier to understand. Maybe
that is worth looking into, at the moment though I still think it
makes sense to fix this #ifdef.

Alistair

>
> Cheers,
>
> --
> Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

WARNING: multiple messages have this Message-ID (diff)
From: Alistair Francis <alistair23@gmail.com>
To: Julien Grall <julien.grall@arm.com>
Cc: Alistair Francis <alistair.francis@wdc.com>,
	Wei Liu <wei.liu2@citrix.com>,
	Ian Jackson <Ian.Jackson@eu.citrix.com>,
	Jan Beulich <JBeulich@suse.com>,
	xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [Xen-devel] [PATCH 2/3] xen/drivers/char: Don't require vpl011 for all non-x86 archs
Date: Fri, 17 May 2019 15:01:01 -0700	[thread overview]
Message-ID: <CAKmqyKN=HCwitx7StNKLmNhjVeXq0cEawyi+j9VJf5dkhfi=jQ@mail.gmail.com> (raw)
Message-ID: <20190517220101.rlYWFY8VTNaowzTWvRMYATCyKEhhwTIRBo4dqClqevg@z> (raw)
In-Reply-To: <b3621bcf-89d0-22a0-2416-4cf5a341d13a@arm.com>

On Fri, May 17, 2019 at 1:46 AM Julien Grall <julien.grall@arm.com> wrote:
>
>
>
> On 16/05/2019 20:30, Alistair Francis wrote:
> > On Thu, May 16, 2019 at 3:32 AM Jan Beulich <JBeulich@suse.com> wrote:
> >>
> >>>>> On 16.05.19 at 02:02, <alistair.francis@wdc.com> wrote:
> >>> Make the asm/vpl011.h dependent on the ARM architecture.
> >>
> >> But we only have x86 and Arm right now. A word more about
> >> your motivation would help.
> >
> > As the code currently is no one can add another architecture. This is
> > just a general fixup as assuming Xen will only ever support two archs
> > seems strange.
>
> At which point, wouldn't it be better to avoid #ifdef ARCH in common code?
> Instead, we could provide arch helper and/or more meaning CONFIG name.

I'm not sure if the arch helpers are any easier to understand. Maybe
that is worth looking into, at the moment though I still think it
makes sense to fix this #ifdef.

Alistair

>
> Cheers,
>
> --
> Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  reply	other threads:[~2019-05-17 22:03 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-16  0:02 [PATCH 1/3] config.sub: Update config.sub to latest version Alistair Francis
2019-05-16  0:02 ` [Xen-devel] " Alistair Francis
2019-05-16  0:02 ` [PATCH 2/3] xen/drivers/char: Don't require vpl011 for all non-x86 archs Alistair Francis
2019-05-16  0:02   ` [Xen-devel] " Alistair Francis
2019-05-16 10:32   ` Jan Beulich
2019-05-16 10:32     ` [Xen-devel] " Jan Beulich
2019-05-16 19:30     ` Alistair Francis
2019-05-16 19:30       ` [Xen-devel] " Alistair Francis
2019-05-17  6:26       ` Jan Beulich
2019-05-17  6:26         ` [Xen-devel] " Jan Beulich
2019-05-17 22:02         ` Alistair Francis
2019-05-17 22:02           ` [Xen-devel] " Alistair Francis
2019-05-17  8:46       ` Julien Grall
2019-05-17  8:46         ` [Xen-devel] " Julien Grall
2019-05-17 22:01         ` Alistair Francis [this message]
2019-05-17 22:01           ` Alistair Francis
2019-05-20  9:56           ` Julien Grall
2019-05-20  9:56             ` [Xen-devel] " Julien Grall
2019-05-16  0:02 ` [PATCH 3/3] xen/rwlock: Include lib.h Alistair Francis
2019-05-16  0:02   ` [Xen-devel] " Alistair Francis
2019-05-16 10:34   ` Jan Beulich
2019-05-16 10:34     ` [Xen-devel] " Jan Beulich
2019-05-16 10:31 ` [PATCH 1/3] config.sub: Update config.sub to latest version Jan Beulich
2019-05-16 10:31   ` [Xen-devel] " Jan Beulich
2019-05-16 11:13   ` Olaf Hering
2019-05-16 11:13     ` [Xen-devel] " Olaf Hering
2019-05-16 11:39     ` Wei Liu
2019-05-16 11:39       ` [Xen-devel] " Wei Liu
2019-05-16 11:44       ` Olaf Hering
2019-05-16 11:44         ` [Xen-devel] " Olaf Hering
2019-05-16 12:47         ` Wei Liu
2019-05-16 12:47           ` [Xen-devel] " Wei Liu
2019-05-16 13:18       ` Olaf Hering
2019-05-16 13:18         ` [Xen-devel] " Olaf Hering
2019-05-16 13:30         ` Wei Liu
2019-05-16 13:30           ` [Xen-devel] " Wei Liu
2019-05-16 19:27           ` Alistair Francis
2019-05-16 19:27             ` [Xen-devel] " Alistair Francis
2019-05-17 16:37             ` Wei Liu
2019-05-17 16:37               ` [Xen-devel] " Wei Liu
2019-05-17 22:38               ` Alistair Francis
2019-05-17 22:38                 ` [Xen-devel] " Alistair Francis
2019-05-18  9:51                 ` Wei Liu
2019-05-18  9:51                   ` [Xen-devel] " Wei Liu
2019-05-16 19:25   ` Alistair Francis
2019-05-16 19:25     ` [Xen-devel] " Alistair Francis
2019-05-17 16:37     ` Wei Liu
2019-05-17 16:37       ` [Xen-devel] " Wei Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKmqyKN=HCwitx7StNKLmNhjVeXq0cEawyi+j9VJf5dkhfi=jQ@mail.gmail.com' \
    --to=alistair23@gmail.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=JBeulich@suse.com \
    --cc=alistair.francis@wdc.com \
    --cc=julien.grall@arm.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.