All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alistair Francis <alistair23@gmail.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: "open list:RISC-V" <qemu-riscv@nongnu.org>,
	QEMU Trivial <qemu-trivial@nongnu.org>,
	Bin Meng <bin.meng@windriver.com>,
	Richard Henderson <richard.henderson@linaro.org>,
	"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>,
	"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
	Alistair Francis <alistair.francis@wdc.com>,
	Palmer Dabbelt <palmer@dabbelt.com>
Subject: Re: [PATCH] target/riscv: Remove obsolete 'CPU unmigratable' comment
Date: Tue, 18 May 2021 16:11:16 +1000	[thread overview]
Message-ID: <CAKmqyKNB4Tb2sMg9B17s3Ad_TZy9MY02_JRPS-1r1C1mjvq1bw@mail.gmail.com> (raw)
In-Reply-To: <20210517070851.857841-1-f4bug@amsat.org>

On Mon, May 17, 2021 at 5:09 PM Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>
> The RISCV CPU is migratable since commit f7697f0e629
> ("target/riscv: Add basic vmstate description of CPU"),
> so remove an obsolete comment which is now incorrect.
>
> Reported-by: Richard Henderson <richard.henderson@linaro.org>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

Thanks!

Applied to riscv-to-apply.next

Alistair

> ---
>  target/riscv/cpu.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c
> index 3191fd00822..d459e8427e2 100644
> --- a/target/riscv/cpu.c
> +++ b/target/riscv/cpu.c
> @@ -638,7 +638,6 @@ static void riscv_cpu_class_init(ObjectClass *c, void *data)
>      cc->disas_set_info = riscv_cpu_disas_set_info;
>  #ifndef CONFIG_USER_ONLY
>      cc->get_phys_page_debug = riscv_cpu_get_phys_page_debug;
> -    /* For now, mark unmigratable: */
>      cc->vmsd = &vmstate_riscv_cpu;
>      cc->write_elf64_note = riscv_cpu_write_elf64_note;
>      cc->write_elf32_note = riscv_cpu_write_elf32_note;
> --
> 2.26.3
>
>


WARNING: multiple messages have this Message-ID (diff)
From: Alistair Francis <alistair23@gmail.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: "qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>,
	"open list:RISC-V" <qemu-riscv@nongnu.org>,
	 QEMU Trivial <qemu-trivial@nongnu.org>,
	Bin Meng <bin.meng@windriver.com>,
	 Richard Henderson <richard.henderson@linaro.org>,
	 "Dr . David Alan Gilbert" <dgilbert@redhat.com>,
	Alistair Francis <alistair.francis@wdc.com>,
	 Palmer Dabbelt <palmer@dabbelt.com>
Subject: Re: [PATCH] target/riscv: Remove obsolete 'CPU unmigratable' comment
Date: Tue, 18 May 2021 16:11:16 +1000	[thread overview]
Message-ID: <CAKmqyKNB4Tb2sMg9B17s3Ad_TZy9MY02_JRPS-1r1C1mjvq1bw@mail.gmail.com> (raw)
In-Reply-To: <20210517070851.857841-1-f4bug@amsat.org>

On Mon, May 17, 2021 at 5:09 PM Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>
> The RISCV CPU is migratable since commit f7697f0e629
> ("target/riscv: Add basic vmstate description of CPU"),
> so remove an obsolete comment which is now incorrect.
>
> Reported-by: Richard Henderson <richard.henderson@linaro.org>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

Thanks!

Applied to riscv-to-apply.next

Alistair

> ---
>  target/riscv/cpu.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c
> index 3191fd00822..d459e8427e2 100644
> --- a/target/riscv/cpu.c
> +++ b/target/riscv/cpu.c
> @@ -638,7 +638,6 @@ static void riscv_cpu_class_init(ObjectClass *c, void *data)
>      cc->disas_set_info = riscv_cpu_disas_set_info;
>  #ifndef CONFIG_USER_ONLY
>      cc->get_phys_page_debug = riscv_cpu_get_phys_page_debug;
> -    /* For now, mark unmigratable: */
>      cc->vmsd = &vmstate_riscv_cpu;
>      cc->write_elf64_note = riscv_cpu_write_elf64_note;
>      cc->write_elf32_note = riscv_cpu_write_elf32_note;
> --
> 2.26.3
>
>


  parent reply	other threads:[~2021-05-18  6:32 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-17  7:08 [PATCH] target/riscv: Remove obsolete 'CPU unmigratable' comment Philippe Mathieu-Daudé
2021-05-17  7:08 ` Philippe Mathieu-Daudé
2021-05-17 12:09 ` Bin Meng
2021-05-17 12:09   ` Bin Meng
2021-05-17 17:38 ` Richard Henderson
2021-05-17 17:38   ` Richard Henderson
2021-05-17 22:38 ` Alistair Francis
2021-05-17 22:38   ` Alistair Francis
2021-05-18  6:11 ` Alistair Francis [this message]
2021-05-18  6:11   ` Alistair Francis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKmqyKNB4Tb2sMg9B17s3Ad_TZy9MY02_JRPS-1r1C1mjvq1bw@mail.gmail.com \
    --to=alistair23@gmail.com \
    --cc=alistair.francis@wdc.com \
    --cc=bin.meng@windriver.com \
    --cc=dgilbert@redhat.com \
    --cc=f4bug@amsat.org \
    --cc=palmer@dabbelt.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-riscv@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.