* [Qemu-devel] [PATCH] cadence_gem: Don't define GEM_INT_Q1_MASK twice
@ 2019-05-13 19:43 Jonathan Behrens
2019-05-13 23:04 ` Alistair Francis
2019-05-14 9:05 ` Philippe Mathieu-Daudé
0 siblings, 2 replies; 3+ messages in thread
From: Jonathan Behrens @ 2019-05-13 19:43 UTC (permalink / raw)
To: qemu-devel
Cc: Peter Maydell, Jonathan Behrens, Jason Wang, Alistair Francis,
Jonathan Behrens, open list:Xilinx Zynq, Edgar E. Iglesias
Signed-off-by: Jonathan Behrens <jonathan@fintelia.io>
---
hw/net/cadence_gem.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/net/cadence_gem.c b/hw/net/cadence_gem.c
index 7f63411430..37cb8a4e5c 100644
--- a/hw/net/cadence_gem.c
+++ b/hw/net/cadence_gem.c
@@ -146,7 +146,6 @@
#define GEM_DESCONF7 (0x00000298/4)
#define GEM_INT_Q1_STATUS (0x00000400 / 4)
-#define GEM_INT_Q1_MASK (0x00000640 / 4)
#define GEM_TRANSMIT_Q1_PTR (0x00000440 / 4)
#define GEM_TRANSMIT_Q7_PTR (GEM_TRANSMIT_Q1_PTR + 6)
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] cadence_gem: Don't define GEM_INT_Q1_MASK twice
2019-05-13 19:43 [Qemu-devel] [PATCH] cadence_gem: Don't define GEM_INT_Q1_MASK twice Jonathan Behrens
@ 2019-05-13 23:04 ` Alistair Francis
2019-05-14 9:05 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Alistair Francis @ 2019-05-13 23:04 UTC (permalink / raw)
To: Jonathan Behrens
Cc: Peter Maydell, Jason Wang, Alistair Francis,
qemu-devel@nongnu.org Developers, Jonathan Behrens,
open list:Xilinx Zynq, Edgar E. Iglesias
On Mon, May 13, 2019 at 12:57 PM Jonathan Behrens <jonathan@fintelia.io> wrote:
>
> Signed-off-by: Jonathan Behrens <jonathan@fintelia.io>
Good find. Thanks for the patch!
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Can this go via your tree Jason?
Alistair
> ---
> hw/net/cadence_gem.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/hw/net/cadence_gem.c b/hw/net/cadence_gem.c
> index 7f63411430..37cb8a4e5c 100644
> --- a/hw/net/cadence_gem.c
> +++ b/hw/net/cadence_gem.c
> @@ -146,7 +146,6 @@
> #define GEM_DESCONF7 (0x00000298/4)
>
> #define GEM_INT_Q1_STATUS (0x00000400 / 4)
> -#define GEM_INT_Q1_MASK (0x00000640 / 4)
>
> #define GEM_TRANSMIT_Q1_PTR (0x00000440 / 4)
> #define GEM_TRANSMIT_Q7_PTR (GEM_TRANSMIT_Q1_PTR + 6)
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] cadence_gem: Don't define GEM_INT_Q1_MASK twice
2019-05-13 19:43 [Qemu-devel] [PATCH] cadence_gem: Don't define GEM_INT_Q1_MASK twice Jonathan Behrens
2019-05-13 23:04 ` Alistair Francis
@ 2019-05-14 9:05 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-05-14 9:05 UTC (permalink / raw)
To: Jonathan Behrens, qemu-devel
Cc: Peter Maydell, Jason Wang, Alistair Francis, Jonathan Behrens,
open list:Xilinx Zynq, Edgar E. Iglesias
On 5/13/19 9:43 PM, Jonathan Behrens wrote:
> Signed-off-by: Jonathan Behrens <jonathan@fintelia.io>
> ---
> hw/net/cadence_gem.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/hw/net/cadence_gem.c b/hw/net/cadence_gem.c
> index 7f63411430..37cb8a4e5c 100644
> --- a/hw/net/cadence_gem.c
> +++ b/hw/net/cadence_gem.c
> @@ -146,7 +146,6 @@
> #define GEM_DESCONF7 (0x00000298/4)
>
> #define GEM_INT_Q1_STATUS (0x00000400 / 4)
> -#define GEM_INT_Q1_MASK (0x00000640 / 4)
>
> #define GEM_TRANSMIT_Q1_PTR (0x00000440 / 4)
> #define GEM_TRANSMIT_Q7_PTR (GEM_TRANSMIT_Q1_PTR + 6)
>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-05-14 9:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-13 19:43 [Qemu-devel] [PATCH] cadence_gem: Don't define GEM_INT_Q1_MASK twice Jonathan Behrens
2019-05-13 23:04 ` Alistair Francis
2019-05-14 9:05 ` Philippe Mathieu-Daudé
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.