* [PATCH v2] libinput: Enable gui PACKAGECONFIG by default
@ 2019-01-10 19:51 Alistair Francis
2019-01-10 20:04 ` Burton, Ross
0 siblings, 1 reply; 7+ messages in thread
From: Alistair Francis @ 2019-01-10 19:51 UTC (permalink / raw)
To: openembedded-core
Most users are going to be using libinput with some sort of display, so
enable gui in the PACKAGECONFIG by default.
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
---
meta/recipes-graphics/wayland/libinput_1.12.3.bb | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/recipes-graphics/wayland/libinput_1.12.3.bb b/meta/recipes-graphics/wayland/libinput_1.12.3.bb
index 3d1ab59309..d3f34c5040 100644
--- a/meta/recipes-graphics/wayland/libinput_1.12.3.bb
+++ b/meta/recipes-graphics/wayland/libinput_1.12.3.bb
@@ -15,7 +15,7 @@ SRC_URI[sha256sum] = "f266ff861a2e7a97e1402c4345e3547b900efde68adbd40e56403e2617
UPSTREAM_CHECK_REGEX = "libinput-(?P<pver>\d+\.\d+\.(?!9\d+)\d+)"
inherit meson pkgconfig lib_package
-PACKAGECONFIG ??= ""
+PACKAGECONFIG ??= "gui"
PACKAGECONFIG[libwacom] = "-Dlibwacom=true,-Dlibwacom=false,libwacom"
PACKAGECONFIG[gui] = "-Ddebug-gui=true,-Ddebug-gui=false,cairo gtk+3"
--
2.19.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v2] libinput: Enable gui PACKAGECONFIG by default
2019-01-10 19:51 [PATCH v2] libinput: Enable gui PACKAGECONFIG by default Alistair Francis
@ 2019-01-10 20:04 ` Burton, Ross
2019-01-10 22:08 ` Alistair Francis
0 siblings, 1 reply; 7+ messages in thread
From: Burton, Ross @ 2019-01-10 20:04 UTC (permalink / raw)
To: Alistair Francis; +Cc: openembedded-core
[-- Attachment #1: Type: text/plain, Size: 485 bytes --]
On Thu, 10 Jan 2019 at 19:51, Alistair Francis <Alistair.Francis@wdc.com>
wrote:
> Most users are going to be using libinput with some sort of display, so
> enable gui in the PACKAGECONFIG by default.
Whilst the assertion that people will be using libinput with a display is
true, this turns on a debug mode (and promptly pulled gtk+3 into the
dependency tree). Is this something that is universally useful? I'm
leaning towards thinking it should remain as-is.
Ross
[-- Attachment #2: Type: text/html, Size: 830 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] libinput: Enable gui PACKAGECONFIG by default
2019-01-10 20:04 ` Burton, Ross
@ 2019-01-10 22:08 ` Alistair Francis
2019-01-10 23:04 ` Burton, Ross
0 siblings, 1 reply; 7+ messages in thread
From: Alistair Francis @ 2019-01-10 22:08 UTC (permalink / raw)
To: Burton, Ross; +Cc: openembedded-core
On Thu, Jan 10, 2019 at 12:04 PM Burton, Ross <ross.burton@intel.com> wrote:
>
> On Thu, 10 Jan 2019 at 19:51, Alistair Francis <Alistair.Francis@wdc.com> wrote:
>>
>> Most users are going to be using libinput with some sort of display, so
>> enable gui in the PACKAGECONFIG by default.
>
>
> Whilst the assertion that people will be using libinput with a display is true, this turns on a debug mode (and promptly pulled gtk+3 into the dependency tree). Is this something that is universally useful? I'm leaning towards thinking it should remain as-is.
I would argue that it is universally useful and that libinput is not
really useful without it.
Alistair
>
> Ross
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] libinput: Enable gui PACKAGECONFIG by default
2019-01-10 22:08 ` Alistair Francis
@ 2019-01-10 23:04 ` Burton, Ross
2019-01-10 23:14 ` Alistair Francis
0 siblings, 1 reply; 7+ messages in thread
From: Burton, Ross @ 2019-01-10 23:04 UTC (permalink / raw)
To: Alistair Francis; +Cc: openembedded-core
[-- Attachment #1: Type: text/plain, Size: 561 bytes --]
On Thu, 10 Jan 2019 at 22:09, Alistair Francis <alistair23@gmail.com> wrote:
> > Whilst the assertion that people will be using libinput with a display
> is true, this turns on a debug mode (and promptly pulled gtk+3 into the
> dependency tree). Is this something that is universally useful? I'm
> leaning towards thinking it should remain as-is.
>
> I would argue that it is universally useful and that libinput is not
> really useful without it.
libinput isn't useful without a graphical debugging tool? That seems quite
a stretch.
Ross
[-- Attachment #2: Type: text/html, Size: 912 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] libinput: Enable gui PACKAGECONFIG by default
2019-01-10 23:04 ` Burton, Ross
@ 2019-01-10 23:14 ` Alistair Francis
2019-01-10 23:53 ` Burton, Ross
0 siblings, 1 reply; 7+ messages in thread
From: Alistair Francis @ 2019-01-10 23:14 UTC (permalink / raw)
To: Burton, Ross; +Cc: openembedded-core
On Thu, Jan 10, 2019 at 3:04 PM Burton, Ross <ross.burton@intel.com> wrote:
>
> On Thu, 10 Jan 2019 at 22:09, Alistair Francis <alistair23@gmail.com> wrote:
>>
>> > Whilst the assertion that people will be using libinput with a display is true, this turns on a debug mode (and promptly pulled gtk+3 into the dependency tree). Is this something that is universally useful? I'm leaning towards thinking it should remain as-is.
>>
>> I would argue that it is universally useful and that libinput is not
>> really useful without it.
>
>
> libinput isn't useful without a graphical debugging tool? That seems quite a stretch.
I meant that libinput isn't useful without the gui support.
I think that this is worth having the extra packages as libinput is
not really useful without gui support.
Alistair
>
> Ross
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] libinput: Enable gui PACKAGECONFIG by default
2019-01-10 23:14 ` Alistair Francis
@ 2019-01-10 23:53 ` Burton, Ross
2019-01-12 1:32 ` Alistair Francis
0 siblings, 1 reply; 7+ messages in thread
From: Burton, Ross @ 2019-01-10 23:53 UTC (permalink / raw)
To: Alistair Francis; +Cc: openembedded-core
[-- Attachment #1: Type: text/plain, Size: 509 bytes --]
On Thu, 10 Jan 2019 at 23:14, Alistair Francis <alistair23@gmail.com> wrote:
> > libinput isn't useful without a graphical debugging tool? That seems
> quite a stretch.
>
> I meant that libinput isn't useful without the gui support.
>
> I think that this is worth having the extra packages as libinput is
> not really useful without gui support.
Sure, but the gui packageconfig just does -Ddebug-gui=yes, which just
builds the libinput-debug-gui binary. Surely that isn't essential?
Ross
[-- Attachment #2: Type: text/html, Size: 1053 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] libinput: Enable gui PACKAGECONFIG by default
2019-01-10 23:53 ` Burton, Ross
@ 2019-01-12 1:32 ` Alistair Francis
0 siblings, 0 replies; 7+ messages in thread
From: Alistair Francis @ 2019-01-12 1:32 UTC (permalink / raw)
To: Burton, Ross; +Cc: openembedded-core
On Thu, Jan 10, 2019 at 3:54 PM Burton, Ross <ross.burton@intel.com> wrote:
>
> On Thu, 10 Jan 2019 at 23:14, Alistair Francis <alistair23@gmail.com> wrote:
>>
>> > libinput isn't useful without a graphical debugging tool? That seems quite a stretch.
>>
>> I meant that libinput isn't useful without the gui support.
>>
>> I think that this is worth having the extra packages as libinput is
>> not really useful without gui support.
>
>
> Sure, but the gui packageconfig just does -Ddebug-gui=yes, which just builds the libinput-debug-gui binary. Surely that isn't essential?
Hmm... I thought it was, but apparently it isn't. Looks like we don't
need this then.
Alistair
>
> Ross
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-01-12 1:32 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-10 19:51 [PATCH v2] libinput: Enable gui PACKAGECONFIG by default Alistair Francis
2019-01-10 20:04 ` Burton, Ross
2019-01-10 22:08 ` Alistair Francis
2019-01-10 23:04 ` Burton, Ross
2019-01-10 23:14 ` Alistair Francis
2019-01-10 23:53 ` Burton, Ross
2019-01-12 1:32 ` Alistair Francis
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.