From: Alistair Francis <alistair23@gmail.com>
To: "~eopxd" <yueh.ting.chen@gmail.com>
Cc: "qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>,
"open list:RISC-V" <qemu-riscv@nongnu.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
Alistair Francis <alistair.francis@wdc.com>,
Bin Meng <bin.meng@windriver.com>,
Frank Chang <frank.chang@sifive.com>,
WeiWei Li <liweiwei@iscas.ac.cn>, eop Chen <eop.chen@sifive.com>
Subject: Re: [PATCH qemu v14 12/15] target/riscv: rvv: Add tail agnostic for vector reduction instructions
Date: Tue, 10 May 2022 11:58:36 +0200 [thread overview]
Message-ID: <CAKmqyKPJq4TSJtFGb2uHP5pmPY5BPWZkxLncFwU1FG8LZGJWpw@mail.gmail.com> (raw)
In-Reply-To: <165156202959.27941.9731161369415852149-12@git.sr.ht>
On Tue, May 3, 2022 at 9:30 AM ~eopxd <eopxd@git.sr.ht> wrote:
>
> From: eopXD <eop.chen@sifive.com>
>
> Signed-off-by: eop Chen <eop.chen@sifive.com>
> Reviewed-by: Frank Chang <frank.chang@sifive.com>
> Reviewed-by: Weiwei Li <liweiwei@iscas.ac.cn>
Acked-by: Alistair Francis <alistair.francis@wdc.com>
Alistair
> ---
> target/riscv/vector_helper.c | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
>
> diff --git a/target/riscv/vector_helper.c b/target/riscv/vector_helper.c
> index f67ec1f249..a319cda969 100644
> --- a/target/riscv/vector_helper.c
> +++ b/target/riscv/vector_helper.c
> @@ -4537,6 +4537,9 @@ void HELPER(NAME)(void *vd, void *v0, void *vs1, \
> { \
> uint32_t vm = vext_vm(desc); \
> uint32_t vl = env->vl; \
> + uint32_t esz = sizeof(TD); \
> + uint32_t vlenb = simd_maxsz(desc); \
> + uint32_t vta = vext_vta(desc); \
> uint32_t i; \
> TD s1 = *((TD *)vs1 + HD(0)); \
> \
> @@ -4549,6 +4552,8 @@ void HELPER(NAME)(void *vd, void *v0, void *vs1, \
> } \
> *((TD *)vd + HD(0)) = s1; \
> env->vstart = 0; \
> + /* set tail elements to 1s */ \
> + vext_set_elems_1s(vd, vta, esz, vlenb); \
> }
>
> /* vd[0] = sum(vs1[0], vs2[*]) */
> @@ -4618,6 +4623,9 @@ void HELPER(NAME)(void *vd, void *v0, void *vs1, \
> { \
> uint32_t vm = vext_vm(desc); \
> uint32_t vl = env->vl; \
> + uint32_t esz = sizeof(TD); \
> + uint32_t vlenb = simd_maxsz(desc); \
> + uint32_t vta = vext_vta(desc); \
> uint32_t i; \
> TD s1 = *((TD *)vs1 + HD(0)); \
> \
> @@ -4630,6 +4638,8 @@ void HELPER(NAME)(void *vd, void *v0, void *vs1, \
> } \
> *((TD *)vd + HD(0)) = s1; \
> env->vstart = 0; \
> + /* set tail elements to 1s */ \
> + vext_set_elems_1s(vd, vta, esz, vlenb); \
> }
>
> /* Unordered sum */
> @@ -4654,6 +4664,9 @@ void HELPER(vfwredsum_vs_h)(void *vd, void *v0, void *vs1,
> {
> uint32_t vm = vext_vm(desc);
> uint32_t vl = env->vl;
> + uint32_t esz = sizeof(uint32_t);
> + uint32_t vlenb = simd_maxsz(desc);
> + uint32_t vta = vext_vta(desc);
> uint32_t i;
> uint32_t s1 = *((uint32_t *)vs1 + H4(0));
>
> @@ -4667,6 +4680,8 @@ void HELPER(vfwredsum_vs_h)(void *vd, void *v0, void *vs1,
> }
> *((uint32_t *)vd + H4(0)) = s1;
> env->vstart = 0;
> + /* set tail elements to 1s */
> + vext_set_elems_1s(vd, vta, esz, vlenb);
> }
>
> void HELPER(vfwredsum_vs_w)(void *vd, void *v0, void *vs1,
> @@ -4674,6 +4689,9 @@ void HELPER(vfwredsum_vs_w)(void *vd, void *v0, void *vs1,
> {
> uint32_t vm = vext_vm(desc);
> uint32_t vl = env->vl;
> + uint32_t esz = sizeof(uint64_t);
> + uint32_t vlenb = simd_maxsz(desc);
> + uint32_t vta = vext_vta(desc);
> uint32_t i;
> uint64_t s1 = *((uint64_t *)vs1);
>
> @@ -4687,6 +4705,8 @@ void HELPER(vfwredsum_vs_w)(void *vd, void *v0, void *vs1,
> }
> *((uint64_t *)vd) = s1;
> env->vstart = 0;
> + /* set tail elements to 1s */
> + vext_set_elems_1s(vd, vta, esz, vlenb);
> }
>
> /*
> --
> 2.34.2
>
>
next prev parent reply other threads:[~2022-05-10 10:08 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-03 7:13 [PATCH qemu v14 00/15] Add tail agnostic behavior for rvv instructions ~eopxd
2022-03-01 9:07 ` [PATCH qemu v14 04/15] target/riscv: rvv: Add tail agnostic for vv instructions ~eopxd
2022-05-03 7:13 ` ~eopxd
2022-05-10 8:50 ` Alistair Francis
2022-03-07 7:10 ` [PATCH qemu v14 05/15] target/riscv: rvv: Add tail agnostic for vector load / store instructions ~eopxd
2022-05-03 7:13 ` ~eopxd
2022-05-10 8:59 ` Alistair Francis
2022-03-07 7:32 ` [PATCH qemu v14 06/15] target/riscv: rvv: Add tail agnostic for vx, vvm, vxm instructions ~eopxd
2022-05-03 7:13 ` ~eopxd
2022-05-10 9:01 ` Alistair Francis
2022-03-07 9:38 ` [PATCH qemu v14 07/15] target/riscv: rvv: Add tail agnostic for vector integer shift instructions ~eopxd
2022-05-03 7:13 ` ~eopxd
2022-05-10 9:19 ` Alistair Francis
2022-03-07 9:43 ` [PATCH qemu v14 08/15] target/riscv: rvv: Add tail agnostic for vector integer comparison instructions ~eopxd
2022-05-03 7:13 ` ~eopxd
2022-05-10 9:33 ` Alistair Francis
2022-03-07 9:53 ` [PATCH qemu v14 09/15] target/riscv: rvv: Add tail agnostic for vector integer merge and move instructions ~eopxd
2022-05-03 7:14 ` ~eopxd
2022-05-10 9:48 ` Alistair Francis
2022-03-07 10:04 ` [PATCH qemu v14 10/15] target/riscv: rvv: Add tail agnostic for vector fix-point arithmetic instructions ~eopxd
2022-05-03 7:14 ` ~eopxd
2022-05-10 9:36 ` Alistair Francis
2022-03-07 10:05 ` [PATCH qemu v14 11/15] target/riscv: rvv: Add tail agnostic for vector floating-point instructions ~eopxd
2022-05-03 7:14 ` ~eopxd
2022-05-10 9:56 ` Alistair Francis
2022-03-07 12:21 ` [PATCH qemu v14 12/15] target/riscv: rvv: Add tail agnostic for vector reduction instructions ~eopxd
2022-05-03 7:14 ` ~eopxd
2022-05-10 9:58 ` Alistair Francis [this message]
2022-03-07 15:26 ` [PATCH qemu v14 13/15] target/riscv: rvv: Add tail agnostic for vector mask instructions ~eopxd
2022-05-03 7:14 ` ~eopxd
2022-05-10 10:00 ` Alistair Francis
2022-03-07 15:59 ` [PATCH qemu v14 14/15] target/riscv: rvv: Add tail agnostic for vector permutation instructions ~eopxd
2022-05-03 7:14 ` ~eopxd
2022-05-10 10:11 ` Alistair Francis
2022-03-09 8:34 ` [PATCH qemu v14 02/15] target/riscv: rvv: Rename ambiguous esz ~eopxd
2022-05-03 7:13 ` ~eopxd
2022-03-12 6:28 ` [PATCH qemu v14 03/15] target/riscv: rvv: Early exit when vstart >= vl ~eopxd
2022-05-03 7:13 ` ~eopxd
2022-03-14 7:38 ` [PATCH qemu v14 01/15] target/riscv: rvv: Prune redundant ESZ, DSZ parameter passed ~eopxd
2022-05-03 7:13 ` ~eopxd
2022-04-28 3:26 ` [PATCH qemu v14 15/15] target/riscv: rvv: Add option 'rvv_ta_all_1s' to enable optional tail agnostic behavior ~eopxd
2022-05-10 10:12 ` Alistair Francis
2022-05-10 11:41 ` [PATCH qemu v14 00/15] Add tail agnostic behavior for rvv instructions Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKmqyKPJq4TSJtFGb2uHP5pmPY5BPWZkxLncFwU1FG8LZGJWpw@mail.gmail.com \
--to=alistair23@gmail.com \
--cc=alistair.francis@wdc.com \
--cc=bin.meng@windriver.com \
--cc=eop.chen@sifive.com \
--cc=frank.chang@sifive.com \
--cc=liweiwei@iscas.ac.cn \
--cc=palmer@dabbelt.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=yueh.ting.chen@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.