All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] glib-2.0: Remove recommend shared-mime-info for MinGW
@ 2017-09-25 22:56 Alistair Francis
  2017-10-04 21:50 ` Alistair Francis
  0 siblings, 1 reply; 4+ messages in thread
From: Alistair Francis @ 2017-09-25 22:56 UTC (permalink / raw)
  To: openembedded-core

Commit glib-2.0: recommend shared-mime-info
(51e4f9ca5368af5cefa26f4ca50b282e858982f8) broke compilation when cross
compiling for Windows. This patch removes the recommendation for
shared-mime-info when using MinGW cross compile.

Signed-off-by: Alistair Francis <alistair.francis@xilinx.com>
Cc: Ross Burton <ross.burton@intel.com>
Cc: Richard Purdie <richard.purdie@linuxfoundation.org>
---
 meta/recipes-core/glib-2.0/glib.inc | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/meta/recipes-core/glib-2.0/glib.inc b/meta/recipes-core/glib-2.0/glib.inc
index ce15ccefc3..8434b7dae3 100644
--- a/meta/recipes-core/glib-2.0/glib.inc
+++ b/meta/recipes-core/glib-2.0/glib.inc
@@ -74,6 +74,8 @@ FILES_${PN}-codegen = "${datadir}/glib-2.0/codegen/*.py \
 FILES_${PN}-utils = "${bindir}/*"
 
 RRECOMMENDS_${PN} += "shared-mime-info"
+# When cross compiling for Windows we don't want to include this
+RRECOMMENDS_${PN}_remove_mingw32 = "shared-mime-info"
 
 ARM_INSTRUCTION_SET_armv4 = "arm"
 ARM_INSTRUCTION_SET_armv5 = "arm"
-- 
2.11.0



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] glib-2.0: Remove recommend shared-mime-info for MinGW
  2017-09-25 22:56 [PATCH] glib-2.0: Remove recommend shared-mime-info for MinGW Alistair Francis
@ 2017-10-04 21:50 ` Alistair Francis
  2017-10-04 22:23   ` Burton, Ross
  0 siblings, 1 reply; 4+ messages in thread
From: Alistair Francis @ 2017-10-04 21:50 UTC (permalink / raw)
  To: Alistair Francis; +Cc: OE-core

On Mon, Sep 25, 2017 at 3:56 PM, Alistair Francis
<alistair.francis@xilinx.com> wrote:
> Commit glib-2.0: recommend shared-mime-info
> (51e4f9ca5368af5cefa26f4ca50b282e858982f8) broke compilation when cross
> compiling for Windows. This patch removes the recommendation for
> shared-mime-info when using MinGW cross compile.
>
> Signed-off-by: Alistair Francis <alistair.francis@xilinx.com>
> Cc: Ross Burton <ross.burton@intel.com>
> Cc: Richard Purdie <richard.purdie@linuxfoundation.org>

Ping!

Thanks,
Alistair

> ---
>  meta/recipes-core/glib-2.0/glib.inc | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/meta/recipes-core/glib-2.0/glib.inc b/meta/recipes-core/glib-2.0/glib.inc
> index ce15ccefc3..8434b7dae3 100644
> --- a/meta/recipes-core/glib-2.0/glib.inc
> +++ b/meta/recipes-core/glib-2.0/glib.inc
> @@ -74,6 +74,8 @@ FILES_${PN}-codegen = "${datadir}/glib-2.0/codegen/*.py \
>  FILES_${PN}-utils = "${bindir}/*"
>
>  RRECOMMENDS_${PN} += "shared-mime-info"
> +# When cross compiling for Windows we don't want to include this
> +RRECOMMENDS_${PN}_remove_mingw32 = "shared-mime-info"
>
>  ARM_INSTRUCTION_SET_armv4 = "arm"
>  ARM_INSTRUCTION_SET_armv5 = "arm"
> --
> 2.11.0
>


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] glib-2.0: Remove recommend shared-mime-info for MinGW
  2017-10-04 21:50 ` Alistair Francis
@ 2017-10-04 22:23   ` Burton, Ross
  2017-10-04 22:29     ` Alistair Francis
  0 siblings, 1 reply; 4+ messages in thread
From: Burton, Ross @ 2017-10-04 22:23 UTC (permalink / raw)
  To: Alistair Francis; +Cc: OE-core

[-- Attachment #1: Type: text/plain, Size: 1447 bytes --]

Already queued for master and probably rocko.

Ross

On 4 October 2017 at 22:50, Alistair Francis <alistair23@gmail.com> wrote:

> On Mon, Sep 25, 2017 at 3:56 PM, Alistair Francis
> <alistair.francis@xilinx.com> wrote:
> > Commit glib-2.0: recommend shared-mime-info
> > (51e4f9ca5368af5cefa26f4ca50b282e858982f8) broke compilation when cross
> > compiling for Windows. This patch removes the recommendation for
> > shared-mime-info when using MinGW cross compile.
> >
> > Signed-off-by: Alistair Francis <alistair.francis@xilinx.com>
> > Cc: Ross Burton <ross.burton@intel.com>
> > Cc: Richard Purdie <richard.purdie@linuxfoundation.org>
>
> Ping!
>
> Thanks,
> Alistair
>
> > ---
> >  meta/recipes-core/glib-2.0/glib.inc | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/meta/recipes-core/glib-2.0/glib.inc
> b/meta/recipes-core/glib-2.0/glib.inc
> > index ce15ccefc3..8434b7dae3 100644
> > --- a/meta/recipes-core/glib-2.0/glib.inc
> > +++ b/meta/recipes-core/glib-2.0/glib.inc
> > @@ -74,6 +74,8 @@ FILES_${PN}-codegen = "${datadir}/glib-2.0/codegen/*.py
> \
> >  FILES_${PN}-utils = "${bindir}/*"
> >
> >  RRECOMMENDS_${PN} += "shared-mime-info"
> > +# When cross compiling for Windows we don't want to include this
> > +RRECOMMENDS_${PN}_remove_mingw32 = "shared-mime-info"
> >
> >  ARM_INSTRUCTION_SET_armv4 = "arm"
> >  ARM_INSTRUCTION_SET_armv5 = "arm"
> > --
> > 2.11.0
> >
>

[-- Attachment #2: Type: text/html, Size: 2316 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] glib-2.0: Remove recommend shared-mime-info for MinGW
  2017-10-04 22:23   ` Burton, Ross
@ 2017-10-04 22:29     ` Alistair Francis
  0 siblings, 0 replies; 4+ messages in thread
From: Alistair Francis @ 2017-10-04 22:29 UTC (permalink / raw)
  To: Burton, Ross; +Cc: OE-core

On Wed, Oct 4, 2017 at 3:23 PM, Burton, Ross <ross.burton@intel.com> wrote:
> Already queued for master and probably rocko.

Thanks for that.

Alistair

>
> Ross
>
> On 4 October 2017 at 22:50, Alistair Francis <alistair23@gmail.com> wrote:
>>
>> On Mon, Sep 25, 2017 at 3:56 PM, Alistair Francis
>> <alistair.francis@xilinx.com> wrote:
>> > Commit glib-2.0: recommend shared-mime-info
>> > (51e4f9ca5368af5cefa26f4ca50b282e858982f8) broke compilation when cross
>> > compiling for Windows. This patch removes the recommendation for
>> > shared-mime-info when using MinGW cross compile.
>> >
>> > Signed-off-by: Alistair Francis <alistair.francis@xilinx.com>
>> > Cc: Ross Burton <ross.burton@intel.com>
>> > Cc: Richard Purdie <richard.purdie@linuxfoundation.org>
>>
>> Ping!
>>
>> Thanks,
>> Alistair
>>
>> > ---
>> >  meta/recipes-core/glib-2.0/glib.inc | 2 ++
>> >  1 file changed, 2 insertions(+)
>> >
>> > diff --git a/meta/recipes-core/glib-2.0/glib.inc
>> > b/meta/recipes-core/glib-2.0/glib.inc
>> > index ce15ccefc3..8434b7dae3 100644
>> > --- a/meta/recipes-core/glib-2.0/glib.inc
>> > +++ b/meta/recipes-core/glib-2.0/glib.inc
>> > @@ -74,6 +74,8 @@ FILES_${PN}-codegen =
>> > "${datadir}/glib-2.0/codegen/*.py \
>> >  FILES_${PN}-utils = "${bindir}/*"
>> >
>> >  RRECOMMENDS_${PN} += "shared-mime-info"
>> > +# When cross compiling for Windows we don't want to include this
>> > +RRECOMMENDS_${PN}_remove_mingw32 = "shared-mime-info"
>> >
>> >  ARM_INSTRUCTION_SET_armv4 = "arm"
>> >  ARM_INSTRUCTION_SET_armv5 = "arm"
>> > --
>> > 2.11.0
>> >
>
>


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2017-10-04 22:30 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-25 22:56 [PATCH] glib-2.0: Remove recommend shared-mime-info for MinGW Alistair Francis
2017-10-04 21:50 ` Alistair Francis
2017-10-04 22:23   ` Burton, Ross
2017-10-04 22:29     ` Alistair Francis

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.