* [PATCH qemu] target/riscv/cpu.c: Fix elen check
@ 2022-12-15 8:27 ~elta
2023-01-09 23:04 ` Alistair Francis
0 siblings, 1 reply; 6+ messages in thread
From: ~elta @ 2022-12-15 8:27 UTC (permalink / raw)
To: qemu-devel, Alistair Francis
Cc: Palmer Dabbelt, Alistair Francis, Bin Meng, qemu-riscv,
qemu-devel, Dongxue Zhang
From: Dongxue Zhang <elta.era@gmail.com>
Should be cpu->cfg.elen in range [8, 64].
Signed-off-by: Dongxue Zhang <elta.era@gmail.com>
Reviewed-by: LIU Zhiwei <zhiwe_liu@linux.alibaba.com>
Message-ID: <bcdd7992-e3ff-de17-22c4-1319e3816e8b@linux.alibaba.com>
Reviewed-by: Frank Chang <frank.chang@sifive.com>
Message-ID: <CANzO1D0du4TSza=-bnqZ+N9cGVfZ6P4xwYaiJg6doTzo7_MdYg@mail.gmail.com>
---
target/riscv/cpu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c
index 6fe176e483..5dc51f7912 100644
--- a/target/riscv/cpu.c
+++ b/target/riscv/cpu.c
@@ -872,7 +872,7 @@ static void riscv_cpu_realize(DeviceState *dev, Error **errp)
"Vector extension ELEN must be power of 2");
return;
}
- if (cpu->cfg.elen > 64 || cpu->cfg.vlen < 8) {
+ if (cpu->cfg.elen > 64 || cpu->cfg.elen < 8) {
error_setg(errp,
"Vector extension implementation only supports ELEN "
"in the range [8, 64]");
--
2.34.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH qemu] target/riscv/cpu.c: Fix elen check
2022-12-15 8:27 [PATCH qemu] target/riscv/cpu.c: Fix elen check ~elta
@ 2023-01-09 23:04 ` Alistair Francis
0 siblings, 0 replies; 6+ messages in thread
From: Alistair Francis @ 2023-01-09 23:04 UTC (permalink / raw)
To: ~elta
Cc: qemu-devel, Palmer Dabbelt, Alistair Francis, Bin Meng,
qemu-riscv, Dongxue Zhang
On Fri, Dec 30, 2022 at 12:26 PM ~elta <elta@git.sr.ht> wrote:
>
> From: Dongxue Zhang <elta.era@gmail.com>
>
> Should be cpu->cfg.elen in range [8, 64].
>
> Signed-off-by: Dongxue Zhang <elta.era@gmail.com>
> Reviewed-by: LIU Zhiwei <zhiwe_liu@linux.alibaba.com>
> Message-ID: <bcdd7992-e3ff-de17-22c4-1319e3816e8b@linux.alibaba.com>
> Reviewed-by: Frank Chang <frank.chang@sifive.com>
> Message-ID: <CANzO1D0du4TSza=-bnqZ+N9cGVfZ6P4xwYaiJg6doTzo7_MdYg@mail.gmail.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Thanks!
Applied to riscv-to-apply.next
Alistair
> ---
> target/riscv/cpu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c
> index 6fe176e483..5dc51f7912 100644
> --- a/target/riscv/cpu.c
> +++ b/target/riscv/cpu.c
> @@ -872,7 +872,7 @@ static void riscv_cpu_realize(DeviceState *dev, Error **errp)
> "Vector extension ELEN must be power of 2");
> return;
> }
> - if (cpu->cfg.elen > 64 || cpu->cfg.vlen < 8) {
> + if (cpu->cfg.elen > 64 || cpu->cfg.elen < 8) {
> error_setg(errp,
> "Vector extension implementation only supports ELEN "
> "in the range [8, 64]");
> --
> 2.34.5
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH qemu] target/riscv/cpu.c: Fix elen check
2022-12-15 8:27 ~elta
@ 2022-12-29 22:32 ` Alistair Francis
0 siblings, 0 replies; 6+ messages in thread
From: Alistair Francis @ 2022-12-29 22:32 UTC (permalink / raw)
To: ~elta; +Cc: qemu-devel, Palmer Dabbelt, Alistair Francis, Bin Meng, qemu-riscv
On Thu, Dec 29, 2022 at 12:34 AM ~elta <elta@git.sr.ht> wrote:
>
> From: Dongxue Zhang <elta.era@gmail.com>
>
> Should be cpu->cfg.elen in range [8, 64].
>
> Signed-off-by: Dongxue Zhang <elta.era@gmail.com>
When sending a new version can you please add any previous reviewed tags.
Alistair
> ---
> target/riscv/cpu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c
> index 6fe176e483..5dc51f7912 100644
> --- a/target/riscv/cpu.c
> +++ b/target/riscv/cpu.c
> @@ -872,7 +872,7 @@ static void riscv_cpu_realize(DeviceState *dev, Error **errp)
> "Vector extension ELEN must be power of 2");
> return;
> }
> - if (cpu->cfg.elen > 64 || cpu->cfg.vlen < 8) {
> + if (cpu->cfg.elen > 64 || cpu->cfg.elen < 8) {
> error_setg(errp,
> "Vector extension implementation only supports ELEN "
> "in the range [8, 64]");
> --
> 2.34.5
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH qemu] target/riscv/cpu.c: Fix elen check
@ 2022-12-15 8:27 ~elta
2022-12-29 22:32 ` Alistair Francis
0 siblings, 1 reply; 6+ messages in thread
From: ~elta @ 2022-12-15 8:27 UTC (permalink / raw)
To: qemu-devel
Cc: Palmer Dabbelt, Alistair Francis, Bin Meng, qemu-riscv, qemu-devel
From: Dongxue Zhang <elta.era@gmail.com>
Should be cpu->cfg.elen in range [8, 64].
Signed-off-by: Dongxue Zhang <elta.era@gmail.com>
---
target/riscv/cpu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c
index 6fe176e483..5dc51f7912 100644
--- a/target/riscv/cpu.c
+++ b/target/riscv/cpu.c
@@ -872,7 +872,7 @@ static void riscv_cpu_realize(DeviceState *dev, Error **errp)
"Vector extension ELEN must be power of 2");
return;
}
- if (cpu->cfg.elen > 64 || cpu->cfg.vlen < 8) {
+ if (cpu->cfg.elen > 64 || cpu->cfg.elen < 8) {
error_setg(errp,
"Vector extension implementation only supports ELEN "
"in the range [8, 64]");
--
2.34.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH qemu] target/riscv/cpu.c: Fix elen check
@ 2022-12-15 8:27 ~elta
0 siblings, 0 replies; 6+ messages in thread
From: ~elta @ 2022-12-15 8:27 UTC (permalink / raw)
To: qemu-devel
Cc: Palmer Dabbelt, Alistair Francis, Bin Meng, qemu-riscv,
qemu-devel, Dongxue Zhang
From: Dongxue Zhang <elta.era@gmail.com>
Should be cpu->cfg.elen in range [8, 64].
Signed-off-by: Dongxue Zhang <elta.era@gmail.com>
---
target/riscv/cpu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c
index 6fe176e483..5dc51f7912 100644
--- a/target/riscv/cpu.c
+++ b/target/riscv/cpu.c
@@ -872,7 +872,7 @@ static void riscv_cpu_realize(DeviceState *dev, Error **errp)
"Vector extension ELEN must be power of 2");
return;
}
- if (cpu->cfg.elen > 64 || cpu->cfg.vlen < 8) {
+ if (cpu->cfg.elen > 64 || cpu->cfg.elen < 8) {
error_setg(errp,
"Vector extension implementation only supports ELEN "
"in the range [8, 64]");
--
2.34.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH qemu] target/riscv/cpu.c: Fix elen check
@ 2022-12-15 8:27 ~elta
0 siblings, 0 replies; 6+ messages in thread
From: ~elta @ 2022-12-15 8:27 UTC (permalink / raw)
To: qemu-devel, Alistair Francis
Cc: Palmer Dabbelt, Alistair Francis, Bin Meng, qemu-riscv,
qemu-devel, Dongxue Zhang
From: Dongxue Zhang <elta.era@gmail.com>
Should be cpu->cfg.elen in range [8, 64].
Signed-off-by: Dongxue Zhang <elta.era@gmail.com>
Reviewed-by: LIU Zhiwei <zhiwe_liu@linux.alibaba.com>
Reviewed-by: Frank Chang <frank.chang@sifive.com>
---
target/riscv/cpu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c
index 6fe176e483..5dc51f7912 100644
--- a/target/riscv/cpu.c
+++ b/target/riscv/cpu.c
@@ -872,7 +872,7 @@ static void riscv_cpu_realize(DeviceState *dev, Error **errp)
"Vector extension ELEN must be power of 2");
return;
}
- if (cpu->cfg.elen > 64 || cpu->cfg.vlen < 8) {
+ if (cpu->cfg.elen > 64 || cpu->cfg.elen < 8) {
error_setg(errp,
"Vector extension implementation only supports ELEN "
"in the range [8, 64]");
--
2.34.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-01-09 23:05 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-15 8:27 [PATCH qemu] target/riscv/cpu.c: Fix elen check ~elta
2023-01-09 23:04 ` Alistair Francis
-- strict thread matches above, loose matches on Subject: below --
2022-12-15 8:27 ~elta
2022-12-29 22:32 ` Alistair Francis
2022-12-15 8:27 ~elta
2022-12-15 8:27 ~elta
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.