All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shuah Khan <shuahkhan@gmail.com>
To: scameron@beardog.cce.hp.com
Cc: Davidlohr Bueso <davidlohr@hp.com>,
	Bjorn Helgaas <bhelgaas@google.com>,
	James Bottomley <James.Bottomley@hansenpartnership.com>,
	Baoquan He <bhe@redhat.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	linux-scsi <linux-scsi@vger.kernel.org>,
	"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
	Joerg Roedel <joro@8bytes.org>,
	"open list:INTEL IOMMU (VT-d)" <iommu@lists.linux-foundation.org>,
	Jiang Liu <jiang.liu@linux.intel.com>
Subject: Re: hpsa driver bug crack kernel down!
Date: Thu, 10 Apr 2014 17:17:44 -0600	[thread overview]
Message-ID: <CAKocOONaqGAaiesf_MUFXEOMDtX8R8kYuPQYAxLBfth7nAx3Jg@mail.gmail.com> (raw)
In-Reply-To: <20140410204525.GC21815@beardog.cce.hp.com>

On Thu, Apr 10, 2014 at 2:45 PM,  <scameron@beardog.cce.hp.com> wrote:
>> > 3f583bc21977 BAD ("Merge tag 'iommu-updates-v3.15'")
>>
>> Yes, specifically (finally done bisecting):
>>
>> commit 2e45528930388658603ea24d49cf52867b928d3e
>> Author: Jiang Liu <jiang.liu@linux.intel.com>
>> Date:   Wed Feb 19 14:07:36 2014 +0800
>>
>>     iommu/vt-d: Unify the way to process DMAR device scope array
>>
>>     Now we have a PCI bus notification based mechanism to update DMAR
>>     device scope array, we could extend the mechanism to support boot
>>     time initialization too, which will help to unify and simplify
>>     the implementation.
>>
>>     Signed-off-by: Jiang Liu <jiang.liu@linux.intel.com>
>>     Signed-off-by: Joerg Roedel <joro@8bytes.org>
>
> My git bisect appears to be converging on something else, something
> within the hpsa patches that I sent up recently, unfortunately for
> me.  Will let you all know when it converges.
>

This smells very much like the problem that was solved couple of years
ago for SI domain. It is likely that path is broken with the DMAR
device scope array change. Please take a look to see if the following
no longer occurs. Looks like BIOS could be expecting this RMRR to be
still mapped.

               /*
                 * We want to prevent any device associated with an RMRR from
                 * getting placed into the SI Domain. This is done because
                 * problems exist when devices are moved in and out of domains
                 * and their respective RMRR info is lost. We exempt USB devices
                 * from this process due to their usage of RMRRs that are known
                 * to not be needed after BIOS hand-off to OS.
                 */
                if (device_has_rmrr(dev) &&
                    (pdev->class >> 8) != PCI_CLASS_SERIAL_USB)
                        return 0;

-- Shuah

WARNING: multiple messages have this Message-ID (diff)
From: Shuah Khan <shuahkhan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: scameron-3C9H9nn4BS4HL6m8NFMY+dBPR1lH4CV8@public.gmane.org
Cc: linux-scsi <linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Baoquan He <bhe-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	"linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	James Bottomley
	<James.Bottomley-JuX6DAaQMKPCXq6kfMZ53/egYHeGw8Jk@public.gmane.org>,
	"open list:INTEL IOMMU (VT-d)"
	<iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>,
	Davidlohr Bueso <davidlohr-VXdhtT5mjnY@public.gmane.org>,
	Bjorn Helgaas <bhelgaas-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
	Jiang Liu <jiang.liu-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Subject: Re: hpsa driver bug crack kernel down!
Date: Thu, 10 Apr 2014 17:17:44 -0600	[thread overview]
Message-ID: <CAKocOONaqGAaiesf_MUFXEOMDtX8R8kYuPQYAxLBfth7nAx3Jg@mail.gmail.com> (raw)
In-Reply-To: <20140410204525.GC21815-3C9H9nn4BS4HL6m8NFMY+dBPR1lH4CV8@public.gmane.org>

On Thu, Apr 10, 2014 at 2:45 PM,  <scameron-3C9H9nn4BS4HL6m8NFMY+dBPR1lH4CV8@public.gmane.org> wrote:
>> > 3f583bc21977 BAD ("Merge tag 'iommu-updates-v3.15'")
>>
>> Yes, specifically (finally done bisecting):
>>
>> commit 2e45528930388658603ea24d49cf52867b928d3e
>> Author: Jiang Liu <jiang.liu-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
>> Date:   Wed Feb 19 14:07:36 2014 +0800
>>
>>     iommu/vt-d: Unify the way to process DMAR device scope array
>>
>>     Now we have a PCI bus notification based mechanism to update DMAR
>>     device scope array, we could extend the mechanism to support boot
>>     time initialization too, which will help to unify and simplify
>>     the implementation.
>>
>>     Signed-off-by: Jiang Liu <jiang.liu-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
>>     Signed-off-by: Joerg Roedel <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
>
> My git bisect appears to be converging on something else, something
> within the hpsa patches that I sent up recently, unfortunately for
> me.  Will let you all know when it converges.
>

This smells very much like the problem that was solved couple of years
ago for SI domain. It is likely that path is broken with the DMAR
device scope array change. Please take a look to see if the following
no longer occurs. Looks like BIOS could be expecting this RMRR to be
still mapped.

               /*
                 * We want to prevent any device associated with an RMRR from
                 * getting placed into the SI Domain. This is done because
                 * problems exist when devices are moved in and out of domains
                 * and their respective RMRR info is lost. We exempt USB devices
                 * from this process due to their usage of RMRRs that are known
                 * to not be needed after BIOS hand-off to OS.
                 */
                if (device_has_rmrr(dev) &&
                    (pdev->class >> 8) != PCI_CLASS_SERIAL_USB)
                        return 0;

-- Shuah

  reply	other threads:[~2014-04-10 23:17 UTC|newest]

Thread overview: 74+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-09  2:39 hpsa driver bug crack kernel down! Baoquan He
2014-04-09 22:49 ` Davidlohr Bueso
2014-04-09 23:08   ` James Bottomley
2014-04-09 23:10     ` James Bottomley
2014-04-09 23:40       ` Davidlohr Bueso
2014-04-09 23:50         ` James Bottomley
2014-04-10  0:19           ` Davidlohr Bueso
2014-04-10  4:03             ` Bjorn Helgaas
2014-04-10  4:03               ` Bjorn Helgaas
2014-04-10  6:32               ` Davidlohr Bueso
2014-04-10  7:15                 ` Joerg Roedel
2014-04-10  7:15                   ` Joerg Roedel
2014-04-10  8:46                   ` Woodhouse, David
2014-04-10  8:46                     ` Woodhouse, David
2014-04-10  8:46                     ` Woodhouse, David
2014-04-10 15:14                     ` Bjorn Helgaas
2014-04-10 15:14                       ` Bjorn Helgaas
2014-04-10 15:14                       ` Bjorn Helgaas
2014-04-10 15:34                       ` Woodhouse, David
2014-04-10 15:34                         ` Woodhouse, David
2014-04-10 15:36                       ` Linda Knippers
2014-04-10 15:36                         ` Linda Knippers
2014-04-10 16:19                     ` Davidlohr Bueso
2014-04-10 16:19                       ` Davidlohr Bueso
2014-04-10 16:19                       ` Davidlohr Bueso
2014-04-10 16:30                       ` Woodhouse, David
2014-04-10 16:30                         ` Woodhouse, David
2014-04-11  9:18                       ` Woodhouse, David
2014-04-11  9:18                         ` Woodhouse, David
2014-04-14 15:45                         ` Davidlohr Bueso
2014-04-14 15:45                           ` Davidlohr Bueso
2014-04-14 15:45                           ` Davidlohr Bueso
2014-04-14 16:19                           ` Jiang Liu
2014-04-14 16:19                             ` Jiang Liu
2014-04-14 16:19                             ` Jiang Liu
2014-04-14 16:44                             ` Davidlohr Bueso
2014-04-14 16:44                               ` Davidlohr Bueso
2014-04-14 16:44                               ` Davidlohr Bueso
2014-04-14 16:47                               ` Davidlohr Bueso
2014-04-14 16:47                                 ` Davidlohr Bueso
2014-04-14 16:47                                 ` Davidlohr Bueso
2014-04-14 17:03                                 ` Woodhouse, David
2014-04-14 17:03                                   ` Woodhouse, David
2014-04-16 13:37                                   ` joro
2014-04-16 13:37                                     ` joro-zLv9SwRftAIdnm+yROfE0A
2014-04-16 13:37                                     ` joro
2014-04-16 13:58                                     ` Woodhouse, David
2014-04-16 13:58                                       ` Woodhouse, David
2014-04-16 14:13                                       ` joro
2014-04-16 14:13                                         ` joro
2014-04-14  7:01                       ` Jiang Liu
2014-04-14  7:01                         ` Jiang Liu
2014-04-14  8:57                       ` Jiang Liu
2014-04-14  8:57                         ` Jiang Liu
2014-04-14 18:08                         ` Davidlohr Bueso
2014-04-14 18:08                           ` Davidlohr Bueso
2014-04-14 18:08                           ` Davidlohr Bueso
2014-04-10 20:45                 ` scameron
2014-04-10 23:17                   ` Shuah Khan [this message]
2014-04-10 23:17                     ` Shuah Khan
2014-04-11  8:57                     ` David Woodhouse
2014-04-11  8:57                       ` David Woodhouse
2014-04-10  8:34               ` Jiang Liu
2014-04-10  8:34                 ` Jiang Liu
2014-04-10 15:54                 ` Davidlohr Bueso
2014-04-10 15:54                   ` Davidlohr Bueso
2014-04-10 16:02                 ` Davidlohr Bueso
2014-04-10 16:02                   ` Davidlohr Bueso
2014-04-11  1:34                 ` Baoquan He
2014-04-11  1:34                   ` Baoquan He
2014-04-11  3:14                 ` Baoquan He
2014-04-11  3:14                   ` Baoquan He
2014-04-10 15:43 ` Bjorn Helgaas
2014-04-10 16:02   ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKocOONaqGAaiesf_MUFXEOMDtX8R8kYuPQYAxLBfth7nAx3Jg@mail.gmail.com \
    --to=shuahkhan@gmail.com \
    --cc=James.Bottomley@hansenpartnership.com \
    --cc=bhe@redhat.com \
    --cc=bhelgaas@google.com \
    --cc=davidlohr@hp.com \
    --cc=iommu@lists.linux-foundation.org \
    --cc=jiang.liu@linux.intel.com \
    --cc=joro@8bytes.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=scameron@beardog.cce.hp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.