All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shuah Khan <shuahkhan@gmail.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: Jean-Michel Hautbois <jhautbois@gmail.com>,
	B_B_Singh@dell.com, Greg KH <gregkh@linuxfoundation.org>,
	Arnd Bergmann <arnd@arndb.de>, Kay Sievers <kay@vrfy.org>,
	Ming Lei <ming.lei@canonical.com>, Stefan Roese <sr@denx.de>,
	Tom Gundersen <teg@jklm.no>,
	Stuart_Hayes@dell.com, Srinivas_G_Gowda@dell.com,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: patch "firmware loader: allow disabling of udev as firmware loader" added to driver-core tree
Date: Thu, 7 Aug 2014 07:23:47 -0600	[thread overview]
Message-ID: <CAKocOONv97=XvciQCT3qJ-e01YVGmJsz0e-N9P2iJrsBw8eeCQ@mail.gmail.com> (raw)
In-Reply-To: <s5hegws3f6m.wl%tiwai@suse.de>

On Thu, Aug 7, 2014 at 1:57 AM, Takashi Iwai <tiwai@suse.de> wrote:
>> >> Hm?  3.16 doesn't contain my patch yet.  It's merged for 3.17-rc1.
>> >
>> > Oh, you are right of course, I am on upstream kernel and I have your
>> > patch. I don't mean your match is causing the issue though ;-).
>> >
>>
>> I think this is what is going on and this patch is the cause:
>> fw_load_from_user_helper() is a stub that returns -ENOENT with this
>> patch.
>
> ... unless specifying the new Kconfig
> CONFIG_FW_LOADER_USER_HELPER_FALLBACK=y.  This is exactly the purpose
> of the commit.

Right - I figured that is the intent.

>
>> As a result, in _request_firmware() after fw_get_filesystem_firmware()
>> fails to find the file, fw_load_from_user_helper() gets called and it
>> returns right
>> away with -ENOENT.
>>
>> In some cases if rootfs mount is in progress, fw_load_from_user_helper()
>> steps into load the firmware.
>
> When a module in initrd requires a firmware, it should be put in
> initrd, too.

Right. This is something drivers have to watch out for with this change.

-- Shuah

      reply	other threads:[~2014-08-07 13:23 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <14048583172593@kroah.com>
     [not found] ` <8B2F6FFD0BD1E448853114367400A37306FD6FBBE9@BLRX7MCDC203.AMER.DELL.COM>
     [not found]   ` <20140710143144.GA17639@kroah.com>
     [not found]     ` <8B2F6FFD0BD1E448853114367400A37306FD6FBBF0@BLRX7MCDC203.AMER.DELL.COM>
2014-07-10 14:54       ` patch "firmware loader: allow disabling of udev as firmware loader" added to driver-core tree Greg KH
2014-07-10 15:24         ` B_B_Singh
     [not found]   ` <s5h38e9mg5v.wl%tiwai@suse.de>
     [not found]     ` <8B2F6FFD0BD1E448853114367400A37306FD6FBBF8@BLRX7MCDC203.AMER.DELL.COM>
     [not found]       ` <s5hy4w1l0s3.wl%tiwai@suse.de>
     [not found]         ` <8B2F6FFD0BD1E448853114367400A37306FD6FBC06@BLRX7MCDC203.AMER.DELL.COM>
     [not found]           ` <s5hpphdkyi6.wl%tiwai@suse.de>
     [not found]             ` <8B2F6FFD0BD1E448853114367400A37306FD6FBDAB@BLRX7MCDC203.AMER.DELL.COM>
     [not found]               ` <s5hoawvkimg.wl%tiwai@suse.de>
     [not found]                 ` <8B2F6FFD0BD1E448853114367400A37306FE07C773@BLRX7MCDC203.AMER.DELL.COM>
     [not found]                   ` <s5h7g3frmg7.wl%tiwai@suse.de>
     [not found]                     ` <8B2F6FFD0BD1E448853114367400A37306FE07CC64@BLRX7MCDC203.AMER.DELL.COM>
     [not found]                       ` <s5hlhrrizbq.wl%tiwai@suse.de>
2014-08-01 20:01                         ` B_B_Singh
2014-08-05 15:43                           ` Jean-Michel Hautbois
2014-08-05 15:53                             ` Takashi Iwai
2014-08-05 15:55                               ` Jean-Michel Hautbois
2014-08-05 16:01                                 ` Takashi Iwai
2014-08-05 19:22                                   ` Shuah Khan
2014-08-06  9:10                                     ` Jean-Michel Hautbois
2014-08-06  9:24                                       ` Takashi Iwai
2014-08-06  9:44                                         ` Jean-Michel Hautbois
2014-08-06 10:21                                           ` Takashi Iwai
2014-08-06 10:50                                             ` Jean-Michel Hautbois
2014-08-06 10:52                                               ` Takashi Iwai
2014-08-06 11:24                                                 ` Jean-Michel Hautbois
2014-08-06 12:24                                                   ` Takashi Iwai
2014-08-06 19:00                                           ` Shuah Khan
2014-08-07  7:57                                             ` Takashi Iwai
2014-08-07 13:23                                               ` Shuah Khan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKocOONv97=XvciQCT3qJ-e01YVGmJsz0e-N9P2iJrsBw8eeCQ@mail.gmail.com' \
    --to=shuahkhan@gmail.com \
    --cc=B_B_Singh@dell.com \
    --cc=Srinivas_G_Gowda@dell.com \
    --cc=Stuart_Hayes@dell.com \
    --cc=arnd@arndb.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=jhautbois@gmail.com \
    --cc=kay@vrfy.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ming.lei@canonical.com \
    --cc=sr@denx.de \
    --cc=teg@jklm.no \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.