All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jean-Michel Hautbois <jhautbois@gmail.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: B_B_Singh@dell.com, Greg KH <gregkh@linuxfoundation.org>,
	Abhay_Salunke@dell.com, Arnd Bergmann <arnd@arndb.de>,
	kay@vrfy.org, ming.lei@canonical.com, Stefan Roese <sr@denx.de>,
	teg@jklm.no, Stuart_Hayes@dell.com, Srinivas_G_Gowda@dell.com,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: patch "firmware loader: allow disabling of udev as firmware loader" added to driver-core tree
Date: Tue, 5 Aug 2014 17:55:40 +0200	[thread overview]
Message-ID: <CAL8zT=jzFmPZ2jizrPXMGBwNReOnDw7wLHZDashavNBh9vhe2g@mail.gmail.com> (raw)
In-Reply-To: <s5hvbq753w2.wl%tiwai@suse.de>

2014-08-05 17:53 GMT+02:00 Takashi Iwai <tiwai@suse.de>:
> At Tue, 5 Aug 2014 17:43:17 +0200,
> Jean-Michel Hautbois wrote:
>>
>> 2014-08-01 22:01 GMT+02:00  <B_B_Singh@dell.com>:
>> > Hi Takashi,
>> >
>> > Sorry for the late response,  I tried with latest stable kernel 3.15.8.  surprisingly the BIOS update works even without applying the patch in both the cases.
>>
>> Hi,I'm sorry for my late answer too, but I didn't try this patch recently...
>>
>> I have a Lattice FPGA on my board, and it seems that your patch breaks
>> the firmware loading.
>> I have the following config :
>> CONFIG_FW_LOADER=y
>> CONFIG_FW_LOADER_USER_HELPER=n
>> FW_LOADER_USER_HELPER_FALLBACK=n
>> LATTICE_ECP3_CONFIG=y
>
> It worked before applying my patch properly...?
>
> The kernel Oops itself is a bug in lattice-ecp3-config driver.
> It blindly assumes that the returned firmware is non-NULL.
> firmware_load() must have a NULL check of fw at the beginning.
>
>
> thanks,
>
> Takashi

Yes, it worked, if the firmware was in the /lib/firmware directory.
You are right, it lacks a NULL check, I will fix that.

Thanks,
JM

  reply	other threads:[~2014-08-05 15:55 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <14048583172593@kroah.com>
     [not found] ` <8B2F6FFD0BD1E448853114367400A37306FD6FBBE9@BLRX7MCDC203.AMER.DELL.COM>
     [not found]   ` <20140710143144.GA17639@kroah.com>
     [not found]     ` <8B2F6FFD0BD1E448853114367400A37306FD6FBBF0@BLRX7MCDC203.AMER.DELL.COM>
2014-07-10 14:54       ` patch "firmware loader: allow disabling of udev as firmware loader" added to driver-core tree Greg KH
2014-07-10 15:24         ` B_B_Singh
     [not found]   ` <s5h38e9mg5v.wl%tiwai@suse.de>
     [not found]     ` <8B2F6FFD0BD1E448853114367400A37306FD6FBBF8@BLRX7MCDC203.AMER.DELL.COM>
     [not found]       ` <s5hy4w1l0s3.wl%tiwai@suse.de>
     [not found]         ` <8B2F6FFD0BD1E448853114367400A37306FD6FBC06@BLRX7MCDC203.AMER.DELL.COM>
     [not found]           ` <s5hpphdkyi6.wl%tiwai@suse.de>
     [not found]             ` <8B2F6FFD0BD1E448853114367400A37306FD6FBDAB@BLRX7MCDC203.AMER.DELL.COM>
     [not found]               ` <s5hoawvkimg.wl%tiwai@suse.de>
     [not found]                 ` <8B2F6FFD0BD1E448853114367400A37306FE07C773@BLRX7MCDC203.AMER.DELL.COM>
     [not found]                   ` <s5h7g3frmg7.wl%tiwai@suse.de>
     [not found]                     ` <8B2F6FFD0BD1E448853114367400A37306FE07CC64@BLRX7MCDC203.AMER.DELL.COM>
     [not found]                       ` <s5hlhrrizbq.wl%tiwai@suse.de>
2014-08-01 20:01                         ` B_B_Singh
2014-08-05 15:43                           ` Jean-Michel Hautbois
2014-08-05 15:53                             ` Takashi Iwai
2014-08-05 15:55                               ` Jean-Michel Hautbois [this message]
2014-08-05 16:01                                 ` Takashi Iwai
2014-08-05 19:22                                   ` Shuah Khan
2014-08-06  9:10                                     ` Jean-Michel Hautbois
2014-08-06  9:24                                       ` Takashi Iwai
2014-08-06  9:44                                         ` Jean-Michel Hautbois
2014-08-06 10:21                                           ` Takashi Iwai
2014-08-06 10:50                                             ` Jean-Michel Hautbois
2014-08-06 10:52                                               ` Takashi Iwai
2014-08-06 11:24                                                 ` Jean-Michel Hautbois
2014-08-06 12:24                                                   ` Takashi Iwai
2014-08-06 19:00                                           ` Shuah Khan
2014-08-07  7:57                                             ` Takashi Iwai
2014-08-07 13:23                                               ` Shuah Khan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAL8zT=jzFmPZ2jizrPXMGBwNReOnDw7wLHZDashavNBh9vhe2g@mail.gmail.com' \
    --to=jhautbois@gmail.com \
    --cc=Abhay_Salunke@dell.com \
    --cc=B_B_Singh@dell.com \
    --cc=Srinivas_G_Gowda@dell.com \
    --cc=Stuart_Hayes@dell.com \
    --cc=arnd@arndb.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=kay@vrfy.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ming.lei@canonical.com \
    --cc=sr@denx.de \
    --cc=teg@jklm.no \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.