From: Viresh Kumar <viresh.kumar@linaro.org> To: Stephen Boyd <sboyd@codeaurora.org> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>, Shawn Guo <shawn.guo@linaro.org>, Lists linaro-kernel <linaro-kernel@lists.linaro.org>, "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Arvind Chauhan <arvind.chauhan@arm.com>, Mike Turquette <mturquette@linaro.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, linux-arm-msm@vger.kernel.org, Sachin Kamat <spk.linux@gmail.com>, Thomas P Abraham <thomas.ab@samsung.com>, Nishanth Menon <nm@ti.com>, Tomasz Figa <t.figa@samsung.com>, Mark Brown <broonie@kernel.org>, Mark Rutland <Mark.Rutland@arm.com> Subject: Re: [PATCH 2/2] cpufreq: cpu0: Extend support beyond CPU0 Date: Fri, 27 Jun 2014 07:56:39 +0530 [thread overview] Message-ID: <CAKohpo=a6y1=aRi_7kZLQx56HXzvDJ-B2j8YiMevD8Wt6BvsEw@mail.gmail.com> (raw) In-Reply-To: <53ACB568.4000903@codeaurora.org> On 27 June 2014 05:36, Stephen Boyd <sboyd@codeaurora.org> wrote: > I gave it a spin. It looks mostly good except for the infinite loop: Great !! > diff --git a/drivers/cpufreq/cpufreq-cpu0.c b/drivers/cpufreq/cpufreq-cpu0.c > index b7ee67c4d1c0..6744321ae33d 100644 > --- a/drivers/cpufreq/cpufreq-cpu0.c > +++ b/drivers/cpufreq/cpufreq-cpu0.c > @@ -138,8 +138,10 @@ try_again: > } > > /* Try with "cpu-supply" */ > - if (reg == reg_cpu0) > + if (reg == reg_cpu0) { > + reg = reg_cpu; > goto try_again; > + } > > dev_warn(cpu_dev, "failed to get cpu%d regulator: %ld\n", > cpu, PTR_ERR(cpu_reg)); Awesome code, I wrote it. Thanks for fixing it. > and I think we just want reg_cpu to be "cpu", not "cpu-supply" because I > think the regulator core adds in the "-supply" part already. Okay. > After fixing that I can get cpufreq going. I'm currently working on > populating the OPPs at runtime without relying on DT. So eventually I'll > need this patch: I see.. > diff --git a/drivers/cpufreq/cpufreq-cpu0.c b/drivers/cpufreq/cpufreq-cpu0.c > index b7ee67c4d1c0..6744321ae33d 100644 > --- a/drivers/cpufreq/cpufreq-cpu0.c > +++ b/drivers/cpufreq/cpufreq-cpu0.c > @@ -239,11 +241,6 @@ static int cpu0_cpufreq_init(struct cpufreq_policy *policy) > } > > ret = of_init_opp_table(cpu_dev); > - if (ret) { > - dev_err(cpu_dev, "failed to init OPP table: %d\n", ret); > - goto out_put_node; > - } > - > ret = dev_pm_opp_init_cpufreq_table(cpu_dev, &freq_table); > if (ret) { > dev_err(cpu_dev, "failed to init cpufreq table: %d\n", ret); > > which I hope is ok. I need to see details of these routines once again, but will surely make it work for you.
WARNING: multiple messages have this Message-ID (diff)
From: viresh.kumar@linaro.org (Viresh Kumar) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 2/2] cpufreq: cpu0: Extend support beyond CPU0 Date: Fri, 27 Jun 2014 07:56:39 +0530 [thread overview] Message-ID: <CAKohpo=a6y1=aRi_7kZLQx56HXzvDJ-B2j8YiMevD8Wt6BvsEw@mail.gmail.com> (raw) In-Reply-To: <53ACB568.4000903@codeaurora.org> On 27 June 2014 05:36, Stephen Boyd <sboyd@codeaurora.org> wrote: > I gave it a spin. It looks mostly good except for the infinite loop: Great !! > diff --git a/drivers/cpufreq/cpufreq-cpu0.c b/drivers/cpufreq/cpufreq-cpu0.c > index b7ee67c4d1c0..6744321ae33d 100644 > --- a/drivers/cpufreq/cpufreq-cpu0.c > +++ b/drivers/cpufreq/cpufreq-cpu0.c > @@ -138,8 +138,10 @@ try_again: > } > > /* Try with "cpu-supply" */ > - if (reg == reg_cpu0) > + if (reg == reg_cpu0) { > + reg = reg_cpu; > goto try_again; > + } > > dev_warn(cpu_dev, "failed to get cpu%d regulator: %ld\n", > cpu, PTR_ERR(cpu_reg)); Awesome code, I wrote it. Thanks for fixing it. > and I think we just want reg_cpu to be "cpu", not "cpu-supply" because I > think the regulator core adds in the "-supply" part already. Okay. > After fixing that I can get cpufreq going. I'm currently working on > populating the OPPs at runtime without relying on DT. So eventually I'll > need this patch: I see.. > diff --git a/drivers/cpufreq/cpufreq-cpu0.c b/drivers/cpufreq/cpufreq-cpu0.c > index b7ee67c4d1c0..6744321ae33d 100644 > --- a/drivers/cpufreq/cpufreq-cpu0.c > +++ b/drivers/cpufreq/cpufreq-cpu0.c > @@ -239,11 +241,6 @@ static int cpu0_cpufreq_init(struct cpufreq_policy *policy) > } > > ret = of_init_opp_table(cpu_dev); > - if (ret) { > - dev_err(cpu_dev, "failed to init OPP table: %d\n", ret); > - goto out_put_node; > - } > - > ret = dev_pm_opp_init_cpufreq_table(cpu_dev, &freq_table); > if (ret) { > dev_err(cpu_dev, "failed to init cpufreq table: %d\n", ret); > > which I hope is ok. I need to see details of these routines once again, but will surely make it work for you.
next prev parent reply other threads:[~2014-06-27 2:26 UTC|newest] Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-06-25 8:42 [PATCH 0/2] cpufreq: cpu0: Extend support beyond CPU0 Viresh Kumar 2014-06-25 8:42 ` Viresh Kumar 2014-06-25 8:42 ` [PATCH 1/2] cpufreq: Add support for per-policy driver data Viresh Kumar 2014-06-25 8:42 ` Viresh Kumar 2014-06-25 8:42 ` [PATCH 2/2] cpufreq: cpu0: Extend support beyond CPU0 Viresh Kumar 2014-06-25 8:42 ` Viresh Kumar 2014-06-25 19:02 ` Stephen Boyd 2014-06-25 19:02 ` Stephen Boyd 2014-06-26 1:55 ` Viresh Kumar 2014-06-26 1:55 ` Viresh Kumar 2014-06-26 1:55 ` Viresh Kumar 2014-06-26 7:34 ` Viresh Kumar 2014-06-26 7:34 ` Viresh Kumar 2014-06-26 7:34 ` Viresh Kumar 2014-06-26 10:52 ` Viresh Kumar 2014-06-26 10:52 ` Viresh Kumar 2014-06-26 10:52 ` Viresh Kumar 2014-06-27 0:06 ` Stephen Boyd 2014-06-27 0:06 ` Stephen Boyd 2014-06-27 0:06 ` Stephen Boyd 2014-06-27 1:53 ` Mike Turquette 2014-06-27 1:53 ` Mike Turquette 2014-06-27 1:53 ` Mike Turquette 2014-06-27 2:15 ` Viresh Kumar 2014-06-27 2:15 ` Viresh Kumar 2014-06-27 2:15 ` Viresh Kumar 2014-06-30 7:57 ` Viresh Kumar 2014-06-30 7:57 ` Viresh Kumar 2014-06-30 7:57 ` Viresh Kumar 2014-06-30 18:33 ` Rob Herring 2014-06-30 18:33 ` Rob Herring 2014-06-30 18:33 ` Rob Herring 2014-07-01 11:14 ` Viresh Kumar 2014-07-01 11:14 ` Viresh Kumar 2014-07-01 11:14 ` Viresh Kumar 2014-07-01 22:00 ` Mike Turquette 2014-07-01 22:00 ` Mike Turquette 2014-07-01 22:00 ` Mike Turquette 2014-07-02 3:32 ` Viresh Kumar 2014-07-02 3:32 ` Viresh Kumar 2014-07-02 3:32 ` Viresh Kumar 2014-06-27 2:26 ` Viresh Kumar [this message] 2014-06-27 2:26 ` Viresh Kumar 2014-06-27 2:26 ` Viresh Kumar 2014-06-26 22:08 ` Mark Brown 2014-06-26 22:08 ` Mark Brown 2014-06-28 14:52 ` Shawn Guo 2014-06-28 14:52 ` Shawn Guo 2014-06-28 14:52 ` Shawn Guo 2014-06-30 4:50 ` Viresh Kumar 2014-06-30 4:50 ` Viresh Kumar 2014-06-30 4:50 ` Viresh Kumar
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAKohpo=a6y1=aRi_7kZLQx56HXzvDJ-B2j8YiMevD8Wt6BvsEw@mail.gmail.com' \ --to=viresh.kumar@linaro.org \ --cc=Mark.Rutland@arm.com \ --cc=arvind.chauhan@arm.com \ --cc=broonie@kernel.org \ --cc=linaro-kernel@lists.linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=mturquette@linaro.org \ --cc=nm@ti.com \ --cc=rjw@rjwysocki.net \ --cc=sboyd@codeaurora.org \ --cc=shawn.guo@linaro.org \ --cc=spk.linux@gmail.com \ --cc=t.figa@samsung.com \ --cc=thomas.ab@samsung.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.